[GitHub] [superset] jinghua-qa edited a comment on pull request #16689: chore: refactor header menu to show in header grid component

[GitBox <gi...@apache.org>]

jinghua-qa edited a comment on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-919365797


   > > We got this feedback from a first time user feeback so we suggest that
   > > 1, to make trashcan icon show when hovering over for all components
   > > 2, when trashcan icon show for header and markdown, it will show in the right top conner inside the component so that it is clear to the user what is deleting.
   > 
   > based on your comment, this PR didn't do it correctly. it removed font-size and background menu, is it part of design?
   
   @graceguo-supercat I tried in the test env, the font-size and background menu will show by click. Is our plan to change the trashcan to show by hovering over in header and markdown sound good to you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org