You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by de...@apache.org on 2019/04/16 05:58:22 UTC
svn commit: r1857617 -
/ofbiz/ofbiz-framework/trunk/applications/product/widget/catalog/ProductScreens.xml
Author: deepak
Date: Tue Apr 16 05:58:22 2019
New Revision: 1857617
URL: http://svn.apache.org/viewvc?rev=1857617&view=rev
Log:
Fixed: Wrong permission check in ProductScreens#FindProduct
(OFBIZ-10925)
Thanks Dennis Balkir for your contribution
The permission service acctgAgreementPermissionCheck is used in the screen FindProduct in ProductScreens.xml.
This doesn't really make sense, since there is no connection to the accounting application here.
There was the service productGenericPermission which could have been used instead,
but this one calls the simple-method checkProductRelatedPermission,
which then check for the CATALOG permission. Since this is already done in the CommonProductDecorator before, it would not make any sense to do this a second time.
Modified:
ofbiz/ofbiz-framework/trunk/applications/product/widget/catalog/ProductScreens.xml
Modified: ofbiz/ofbiz-framework/trunk/applications/product/widget/catalog/ProductScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/widget/catalog/ProductScreens.xml?rev=1857617&r1=1857616&r2=1857617&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/widget/catalog/ProductScreens.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/widget/catalog/ProductScreens.xml Tue Apr 16 05:58:22 2019
@@ -96,9 +96,6 @@ under the License.
<decorator-screen name="CommonProductDecorator" location="${parameters.productDecoratorLocation}">
<decorator-section name="body">
<section>
- <condition>
- <if-service-permission service-name="acctgAgreementPermissionCheck" main-action="VIEW"/>
- </condition>
<widgets>
<decorator-screen name="FindScreenDecorator" location="component://common/widget/CommonScreens.xml">
<decorator-section name="search-options">
@@ -109,9 +106,6 @@ under the License.
</decorator-section>
</decorator-screen>
</widgets>
- <fail-widgets>
- <label style="h3">${uiLabelMap.AccountingViewPermissionError}</label>
- </fail-widgets>
</section>
</decorator-section>
</decorator-screen>