You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 22:59:02 UTC

[GitHub] [airflow] jedcunningham opened a new pull request #15686: Check chart labels on all objects

jedcunningham opened a new pull request #15686:
URL: https://github.com/apache/airflow/pull/15686


   We weren't checking labels on all of the objects our chart creates.
   Instead of making it fatal, I've added a warning so new objects that are
   forgotten are more visible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on pull request #15686: Check chart labels on all objects

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #15686:
URL: https://github.com/apache/airflow/pull/15686#issuecomment-833829438


   @ash, I removed some of them. I did leave them on the jobs, however, as we do have existing component labels on the `Job` objects.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #15686: Check chart labels on all objects

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #15686:
URL: https://github.com/apache/airflow/pull/15686#discussion_r627204030



##########
File path: chart/templates/secrets/metadata-connection-secret.yaml
##########
@@ -31,6 +31,8 @@ apiVersion: v1
 metadata:
   name: {{ .Release.Name }}-airflow-metadata
   labels:
+    tier: airflow
+    component: connection

Review comment:
       Yeah, this one feels wrong, especially as it used by all "components"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #15686: Check chart labels on all objects

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15686:
URL: https://github.com/apache/airflow/pull/15686


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15686: Check chart labels on all objects

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15686:
URL: https://github.com/apache/airflow/pull/15686#issuecomment-833841784


   [The Workflow run](https://github.com/apache/airflow/actions/runs/818158865) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on a change in pull request #15686: Check chart labels on all objects

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #15686:
URL: https://github.com/apache/airflow/pull/15686#discussion_r626972126



##########
File path: chart/templates/secrets/metadata-connection-secret.yaml
##########
@@ -31,6 +31,8 @@ apiVersion: v1
 metadata:
   name: {{ .Release.Name }}-airflow-metadata
   labels:
+    tier: airflow
+    component: connection

Review comment:
       I'm considering not setting a component for some of these, like this one. Thoughts on having it on "most but not all"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org