You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dabla (via GitHub)" <gi...@apache.org> on 2024/11/06 14:02:23 UTC
[PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
dabla opened a new pull request, #43747:
URL: https://github.com/apache/airflow/pull/43747
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: [#41327](https://github.com/apache/airflow/pull/41327)
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR is linked to the original [PR Introduce notion of dialects in DbApiHook](https://github.com/apache/airflow/pull/41327), but only contains a small refactoring in which the sql handlers of the common-sql -provider are moved from the sql module to a dedicated handler module, as this will be needed later on to avoid circular import issues. This is to make the review easier as asked by @potiuk. This PR only impacts the common-sql provider, also a dedicated unit test has been added for the handlers.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #43747:
URL: https://github.com/apache/airflow/pull/43747#discussion_r1836562105
##########
providers/src/airflow/providers/common/sql/provider.yaml:
##########
@@ -25,6 +25,7 @@ state: ready
source-date-epoch: 1730012422
# note that those versions are maintained by release manager - do not update them manually
versions:
+ - 1.19.1
Review Comment:
Please don't set versions unless explicitly asked by release manager.
It causes troubles during release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on PR #43747:
URL: https://github.com/apache/airflow/pull/43747#issuecomment-2461785505
> It seems like installing node to build packages is very unstable recently (connection reset by peer etc.) - we will get it cached soon WIP is here: #43329 cc: @bugraoz93 that should improve stability.
Isn't there a way to be able to re-run a failing step in the ci cd checks of github?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43747:
URL: https://github.com/apache/airflow/pull/43747#issuecomment-2461770395
It seems like installing node to build packages is very unstable recently (connection reset by peer etc.) - we will get it cached soon WIP is here: https://github.com/apache/airflow/pull/43329 cc: @bugraoz93 that should improve stability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43747:
URL: https://github.com/apache/airflow/pull/43747#issuecomment-2461771507
For now rebasing, commit--amend or close/reopening the PR should retry it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43747:
URL: https://github.com/apache/airflow/pull/43747#discussion_r1837326772
##########
providers/src/airflow/providers/common/sql/provider.yaml:
##########
@@ -25,6 +25,7 @@ state: ready
source-date-epoch: 1730012422
# note that those versions are maintained by release manager - do not update them manually
versions:
+ - 1.19.1
Review Comment:
I did it via Github UI / suggestions :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on code in PR #43747:
URL: https://github.com/apache/airflow/pull/43747#discussion_r1837245542
##########
providers/src/airflow/providers/common/sql/provider.yaml:
##########
@@ -25,6 +25,7 @@ state: ready
source-date-epoch: 1730012422
# note that those versions are maintained by release manager - do not update them manually
versions:
+ - 1.19.1
Review Comment:
Will revert that @eladkal had the same remark from @potiuk my bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43747:
URL: https://github.com/apache/airflow/pull/43747#discussion_r1837326582
##########
providers/src/airflow/providers/common/sql/provider.yaml:
##########
@@ -25,6 +25,7 @@ state: ready
source-date-epoch: 1730012422
# note that those versions are maintained by release manager - do not update them manually
versions:
+ - 1.19.1
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43747:
URL: https://github.com/apache/airflow/pull/43747#issuecomment-2486487099
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on PR #43747:
URL: https://github.com/apache/airflow/pull/43747#issuecomment-2461787884
> For now rebasing, commit--amend or close/reopening the PR should retry it.
Yeah just did it again, I was a bit worried cause my other PR didn't suffer from those random errors so I though maybe something was wrong in this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on PR #43747:
URL: https://github.com/apache/airflow/pull/43747#issuecomment-2486834562
> Nice!
Thx @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #43747:
URL: https://github.com/apache/airflow/pull/43747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on PR #43747:
URL: https://github.com/apache/airflow/pull/43747#issuecomment-2461500003
Some things are failing but dunno why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Moved common SQL handler methods of common-sql-provider into dedicated module [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #43747:
URL: https://github.com/apache/airflow/pull/43747#issuecomment-2462793309
> > For now rebasing, commit--amend or close/reopening the PR should retry it.
>
> Yeah just did it again, I was a bit worried cause my other PR didn't suffer from those random errors so I though maybe something was wrong in this one.
This is purely too many trials on node servers trying to download the dependencies and appear in random CI runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org