[GitHub] [incubator-superset] PeterCahn opened a new issue #8841: /shortner API does not take into account when Superset is behind a reverse proxy to be served over HTTPS

[GitBox <gi...@apache.org>]

PeterCahn opened a new issue #8841: /shortner API does not take into account when Superset is behind a reverse proxy to be served over HTTPS
URL: https://github.com/apache/incubator-superset/issues/8841
 
 
   When Superset is served over HTTPS by a reverse proxy (nginx/Apache), the generated URL has "http" as scheme instead of "https".
   The URL scheme is generated from the value of `request.scheme`, but it should take into account also headers like X-Forwarded-Proto and, in general, X-Forwarded-* headers (e.g for host).
   
   ### Expected results
   
   The URL starts with "https://"
   
   ### Actual results
   
   The URL starts with "http://"
   
   #### Screenshots
   
   #### How to reproduce the bug
   
   1. Put nginx or Apache in front of Superset to serve it over HTTPS 
   (Superset has config "ENABLE_PROXY_FIX = True" and the server adds the header X-Forwarded-Proto and sets it to "https")
   2. Go to a dashboard
   3. Click on the arrow on the right, then click to "Share dashboard"
   4. See error
   
   ### Environment
   
   - superset version: 0.34.0
   - python version: 3.6.9
   
   ### Checklist
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   HTTPS works as expected on all others urls without problems, the reverse proxy redirects all the requests from http to https.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org