You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/11 21:49:20 UTC

[GitHub] [spark] zero323 commented on a change in pull request #34226: [SPARK-36951][PYTHON] Inline type hints for python/pyspark/sql/column.py

zero323 commented on a change in pull request #34226:
URL: https://github.com/apache/spark/pull/34226#discussion_r726587759



##########
File path: python/pyspark/sql/column.py
##########
@@ -50,7 +68,11 @@ def _to_java_column(col):
     return jcol
 
 
-def _to_seq(sc, cols, converter=None):
+def _to_seq(
+    sc: SparkContext,
+    cols: Iterable["ColumnOrName"],
+    converter: Optional[Callable] = None,

Review comment:
       We could have more specific type here (`Callable[[ColumnOrName], JavaObject]`?), but it probably doesn't matter much




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org