You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/04 21:35:32 UTC

[GitHub] [airflow] vandonr-amz opened a new pull request, #27513: fix internal links in static code checks rst

vandonr-amz opened a new pull request, #27513:
URL: https://github.com/apache/airflow/pull/27513

   markdown doesn't recognize the link properly if there is no space


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #27513: fix internal links in static code checks rst

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27513:
URL: https://github.com/apache/airflow/pull/27513


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] XD-DENG commented on a diff in pull request #27513: fix internal links in static code checks rst

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on code in PR #27513:
URL: https://github.com/apache/airflow/pull/27513#discussion_r1014536663


##########
STATIC_CODE_CHECKS.rst:
##########
@@ -76,7 +76,7 @@ The current list of prerequisites is limited to ``xmllint``:
 
 Some pre-commit hooks also require the Docker Engine to be configured as the static
 checks are executed in the Docker environment (See table in the
-Available pre-commit checks<#available-pre-commit-checks>`_ . You should build the images
+Available pre-commit checks <#available-pre-commit-checks>`_ . You should build the images

Review Comment:
   A "`" is missing in front of "Available..." and this is still not rendered correctly. Maybe you can help fix it here too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] vandonr-amz commented on a diff in pull request #27513: fix internal links in static code checks rst

Posted by GitBox <gi...@apache.org>.
vandonr-amz commented on code in PR #27513:
URL: https://github.com/apache/airflow/pull/27513#discussion_r1014680025


##########
STATIC_CODE_CHECKS.rst:
##########
@@ -76,7 +76,7 @@ The current list of prerequisites is limited to ``xmllint``:
 
 Some pre-commit hooks also require the Docker Engine to be configured as the static
 checks are executed in the Docker environment (See table in the
-Available pre-commit checks<#available-pre-commit-checks>`_ . You should build the images
+Available pre-commit checks <#available-pre-commit-checks>`_ . You should build the images

Review Comment:
   oops you're right I was a bit too sloppy in checking that everything is ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org