Re: svn commit: r1044202 [1/5] - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet / applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/ applications/content/src/org/ofbiz/content/webapp/ftl/ app...

[Jacques Le Roux <ja...@les7arts.com>]

Hi Adam,

 From svn doc I see no reasons to force svn:eol-style property as you did at r1044202 (see below)
As said at http://svnbook.red-bean.com/en/1.7/svn.advanced.props.file-portability.html svn:eol-style is only a working copy feature, for instance:

     |native|

        This causes the file to contain the EOL markers that are native to the operating system on which Subversion was run. In other words, if a user on
        a Windows machine checks out a working copy that contains a file with an |svn:eol-style| property set to |native|, that file will contain |CRLF|
        EOL markers. A Unix user checking out a working copy that contains the same file will see |LF| EOL markers in his copy of the file.

        Note that Subversion will actually store the file in the repository using normalized |LF| EOL markers regardless of the operating system. This is
        basically transparent to the user, though.

So your commit has not effect on the repo where all is LF EOL anyway, nor on people working copies when they use our svn config file as explained at 
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices "Install the OFBIZ Subversion client configuration file".

Since several java files have been committed since w/o svn:eol-style property, I wonder if it has no impacts on working copies produced by users not 
using our svn config file. At least a case of Java files with mixed EOLs was reported to me (an user with Cygwin).
Anyway I think forcing svn:eol-style property just add confusion. But I guess you has a reason to do so?

Also you say in your commit comment:
 >Also, some files were committed to the repository with DOS line endings;
This makes non sense to me since in the repo all files are stored with Linux style EOL, could you explain why you did so? Were those files committed 
to a forced svn:eol-style value?

Thanks

Jacques
PS: I don't think this depends on Subversion version used locally (above doc is for 1.7, I use 1.8.11)

Le 10/12/2010 03:40, doogie@apache.org a écrit :
> Author: doogie
> Date: Fri Dec 10 02:40:02 2010
> New Revision: 1044202
>
> URL:http://svn.apache.org/viewvc?rev=1044202&view=rev
> Log:
> Setsvn:eol-style  properly on all java files.  This needs to be done on other text files as well, but that would cause undo conflicts in the jquery branch(due to .js being heavily modified there).  Also, some files were committed to the repository with DOS line endings; those are fixed as well.
>
> Modified:
>      ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMRespPositions.java   (props changed)
>      ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/CPRespPositions.java   (props changed)
>      ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/SecurePayPaymentServices.java   (props changed)
[...]