You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/04/02 22:33:25 UTC
[jira] [Commented] (FLUME-1090) JDBC Channel: Minimize logging
under nominal conditions
[ https://issues.apache.org/jira/browse/FLUME-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244570#comment-13244570 ]
jiraposter@reviews.apache.org commented on FLUME-1090:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4610/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
This patch changes loglevel to debug for stuff like successful event read & write. This should improve performance at the INFO level. Other similar changes have been made.
One additional change I have snuck into this patch is logging the event metrics at info level for the Null sink, to make it consistent with the Logger sink.
This addresses bug FLUME-1090.
https://issues.apache.org/jira/browse/FLUME-1090
Diffs
-----
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 307ae89
flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java c11a002
Diff: https://reviews.apache.org/r/4610/diff
Testing
-------
Unit tests pass.
Thanks,
Mike
> JDBC Channel: Minimize logging under nominal conditions
> -------------------------------------------------------
>
> Key: FLUME-1090
> URL: https://issues.apache.org/jira/browse/FLUME-1090
> Project: Flume
> Issue Type: Improvement
> Reporter: Mike Percy
> Assignee: Mike Percy
> Attachments: FLUME-1090-1.patch
>
>
> Minimize the logging that we do under normal conditions in JDBC channel, for performance and usability reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira