You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/15 15:24:16 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4161: sched/init: initialize all idle thread's tl_task
xiaoxiang781216 opened a new pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880871460
Without the commit:
http://ci.px4.io/blue/organizations/jenkins/PX4_misc%2FFirmware-hardware/detail/pr-nuttx-10.1.0%2B-upstream/26/pipeline
testing now
http://ci.px4.io/blue/organizations/jenkins/PX4_misc%2FFirmware-hardware/detail/pr-nuttx-10.1.0%2B-upstream/27/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880793991
@saramonteiro and @masayuki2009 could you test this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-881075591
@xiaoxiang781216
Thanks for the fix.
Let me merge the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] saramonteiro commented on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
saramonteiro commented on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880895065
Yes @davids5
Also tested here with esp32 smp config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880929027
>But I think we should wait for some test from @masayuki2009 as well
I would normally agree with you to wait. But master is very broken for non SMP. So I would propose this should come in now and if it does not fix some SMP issue, that can be addressed next.
This is the fault - deref of null pointer on idle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] saramonteiro edited a comment on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
saramonteiro edited a comment on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880895065
Yes @davids5
Also tested here with esp32 smp config.
But I think we should wait for some test from @masayuki2009 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] saramonteiro commented on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
saramonteiro commented on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880865029
`esp32s2-saola-1:nsh` is ok now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880929027
>But I think we should wait for some test from @masayuki2009 as well
I would normally agree with you to wait. But master is very broken for non SMP. So I would propose this should come in now and if it does not fix some SMP issue, that can be addressed next.
This is the fault - deref of null pointer on idle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880879252
@xiaoxiang781216 - what did you change in last force?
Can you please not force push in the middle testing without documenting what you are doing or better yet not fixup then squash at the end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880891662
@xiaoxiang781216 - this fixed the issue (I built the one the failed still locally and it is passing).
So lets merge this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] saramonteiro commented on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
saramonteiro commented on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880859834
> @saramonteiro and @masayuki2009 could you test this patch?
Yes. I am testing it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880946671
> @xiaoxiang781216 - what did you change in last force?
>
> Can you please not force push in the middle testing without documenting what you are doing or better yet not fixup then squash at the end?
Ok, the new change is fixed sim:smp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #4161: sched/init: initialize all idle thread's tl_task
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #4161:
URL: https://github.com/apache/incubator-nuttx/pull/4161#issuecomment-880892029
@saramonteiro - Are you satisfied that we can merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org