[GitHub] [spark] amaliujia commented on a change in pull request #35389: [SPARK-37943][SQL]Use error classes in the compilation errors of grouping

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #35389:
URL: https://github.com/apache/spark/pull/35389#discussion_r798913158



##########
File path: core/src/main/resources/error/error-classes.json
##########
@@ -153,6 +153,9 @@
     "message" : [ "The feature is not supported: %s" ],
     "sqlState" : "0A000"
   },
+  "UNSUPPORTED_GROUPING_EXPRESSION" : {
+    "message" : [ "grouping()/grouping_id() can only be used with GroupingSets/Cube/Rollup" ]

Review comment:
       I am thinking `GroupingSets/Cube/Rollup` is not easy to understand. Right now I cannot immediately recall what is grouping sets or cube or rollup. 
   
   Is it possible to use other way to explain grouping()/grouping_id()? Like they can only be used in syntax a, b, c 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org