You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/21 07:46:10 UTC

[GitHub] [apisix] kingluo commented on a diff in pull request #8006: feat(test): add default no_error_log

kingluo commented on code in PR #8006:
URL: https://github.com/apache/apisix/pull/8006#discussion_r1001474506


##########
t/control/discovery.t:
##########
@@ -77,6 +73,8 @@ GET /t
 --- response_body
 {}
 {"fetch_interval":3,"keepalive":true,"prefix":"upstreams","servers":["http://127.0.0.1:8500","http://127.0.0.1:8600"],"timeout":{"connect":2000,"read":2000,"wait":60},"weight":1}
+--- error_log
+connect consul

Review Comment:
   Because this whole test file is only used to verify the configuration set or not, but the configuratioin content is invalid, which contains non-exist consul server address.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org