You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/05/05 10:27:19 UTC
[GitHub] brooklyn-server pull request #669: Delete hazelcast datagrid (and delete dat...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/669
Delete hazelcast datagrid (and delete datagrid config)
This has not been documented, used in production, or recommended ever! It was more experimental, as an approach that might have replaced the existing persisted state approach but never did.
We can also delete the use of `BrooklynStorage`, but we can do that incrementally (i.e. in a subsequent PR) - that will be more intrusive (changing `AbstractEntity` etc). By first deleting/hiding the `Datagrid` code, it makes the next stage much simpler as we can be much more confident about what `BrooklynStorage` is doing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server delete-hazelcast-datagrid
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/669.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #669
----
commit 3c1a7805add0dd584a26b1a0174d8ced44b5c014
Author: Aled Sage <al...@gmail.com>
Date: 2017-05-03T19:43:23Z
Delete brooklyn-storage-hazelcast
This has not been documented, used or recommended ever! It was more
experimental, as an approach that might have replaced the existing
persisted state approach but never did.
commit 236afd7ab95a27e3a74fd28dc0337250c880ec32
Author: Aled Sage <al...@gmail.com>
Date: 2017-05-03T19:53:42Z
ManagementContext.dataGrid not configurable
commit 21c40ba0b9ab2eabe76ce834117964a1613a4677
Author: Aled Sage <al...@gmail.com>
Date: 2017-05-03T19:59:47Z
Delete DataGridFactory
commit 6b59fcb6a0c8e57dcdd00b8c95ea2b410c8fcf2d
Author: Aled Sage <al...@gmail.com>
Date: 2017-05-04T10:40:03Z
Hide DataGrid inside BrooklynStorageImpl
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #669: Delete hazelcast datagrid (and delete datagrid c...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the issue:
https://github.com/apache/brooklyn-server/pull/669
I agree with you, this should be removed as not used +1
fwiw, I think a datagrid was a good idea especially if we want to support "brooklyn of brooklyns" kind of approach, although maybe with the shift to karaf there is a better way.
> It was more experimental, as an approach that might have replaced the existing persisted state approach but never did.
I tried that as well but never finished the poc so either we need some experts or sounds unlikely to have it done correctly. We can always re-introduce datagrid in case needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #669: Delete hazelcast datagrid (and delete datagrid c...
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:
https://github.com/apache/brooklyn-server/pull/669
This looks good and agree about removal. The failure is an unrelated problem with the build server. I've run the tests manually and everything seems fine so I'm going to merge now. Thanks @aledsage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #669: Delete hazelcast datagrid (and delete dat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/669
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---