You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Phong Nguyen <pn...@gilt.com> on 2013/04/12 23:11:42 UTC
Review Request: Fix command for executing injectkeys.sh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10437/
-----------------------------------------------------------
Review request for cloudstack and Hugo Trippaers.
Description
-------
Management server unable to start (from rpm) due to invalid call to Script for injectkeys.sh.
2013-04-12 15:02:13,496 WARN [cloud.server.ConfigurationServerImpl] (Timer-1:null) Failed to inject generated public key into systemvm iso java.io.IOException: Cannot run program "/bin/bash /usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh": error=2, No such file or directory
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
at com.cloud.utils.script.Script.execute(Script.java:183)
Diffs
-----
server/src/com/cloud/server/ConfigurationServerImpl.java 596387f
Diff: https://reviews.apache.org/r/10437/diff/
Testing
-------
Rebuilt rpm and tested management server startup -- success
Thanks,
Phong Nguyen
Re: Review Request: Fix command for executing injectkeys.sh
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
> On April 15, 2013, 6:43 p.m., Hugo Trippaers wrote:
> > Ship It!
Commit on master 794e653c1325f6ba78b700f62e75c5a7b502c4eb
Thanks for fixing my bug ;-)
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10437/#review19205
-----------------------------------------------------------
On April 12, 2013, 9:11 p.m., Phong Nguyen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10437/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 9:11 p.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Description
> -------
>
> Management server unable to start (from rpm) due to invalid call to Script for injectkeys.sh.
>
> 2013-04-12 15:02:13,496 WARN [cloud.server.ConfigurationServerImpl] (Timer-1:null) Failed to inject generated public key into systemvm iso java.io.IOException: Cannot run program "/bin/bash /usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh": error=2, No such file or directory
> at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
> at com.cloud.utils.script.Script.execute(Script.java:183)
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ConfigurationServerImpl.java 596387f
>
> Diff: https://reviews.apache.org/r/10437/diff/
>
>
> Testing
> -------
>
> Rebuilt rpm and tested management server startup -- success
>
>
> Thanks,
>
> Phong Nguyen
>
>
Re: Review Request: Fix command for executing injectkeys.sh
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10437/#review19205
-----------------------------------------------------------
Ship it!
Ship It!
- Hugo Trippaers
On April 12, 2013, 9:11 p.m., Phong Nguyen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10437/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 9:11 p.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Description
> -------
>
> Management server unable to start (from rpm) due to invalid call to Script for injectkeys.sh.
>
> 2013-04-12 15:02:13,496 WARN [cloud.server.ConfigurationServerImpl] (Timer-1:null) Failed to inject generated public key into systemvm iso java.io.IOException: Cannot run program "/bin/bash /usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh": error=2, No such file or directory
> at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
> at com.cloud.utils.script.Script.execute(Script.java:183)
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ConfigurationServerImpl.java 596387f
>
> Diff: https://reviews.apache.org/r/10437/diff/
>
>
> Testing
> -------
>
> Rebuilt rpm and tested management server startup -- success
>
>
> Thanks,
>
> Phong Nguyen
>
>
Re: Review Request: Fix command for executing injectkeys.sh
Posted by Phong Nguyen <pn...@gilt.com>.
No, only need for master. I just checked 4.1 and it does not have the
changes from commit 5cd3608.
On Mon, Apr 15, 2013 at 1:07 PM, Chip Childers <ch...@sungard.com>wrote:
> Do I need a patch for this in 4.1?
>
> On Mon, Apr 15, 2013 at 05:02:07PM +0000, Chiradeep Vittal wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/10437/#review19193
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > Ship It!
> >
> > - Chiradeep Vittal
> >
> >
> > On April 12, 2013, 9:11 p.m., Phong Nguyen wrote:
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/10437/
> > > -----------------------------------------------------------
> > >
> > > (Updated April 12, 2013, 9:11 p.m.)
> > >
> > >
> > > Review request for cloudstack and Hugo Trippaers.
> > >
> > >
> > > Description
> > > -------
> > >
> > > Management server unable to start (from rpm) due to invalid call to
> Script for injectkeys.sh.
> > >
> > > 2013-04-12 15:02:13,496 WARN [cloud.server.ConfigurationServerImpl]
> (Timer-1:null) Failed to inject generated public key into systemvm iso
> java.io.IOException: Cannot run program "/bin/bash
> /usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh": error=2,
> No such file or directory
> > > at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
> > > at com.cloud.utils.script.Script.execute(Script.java:183)
> > >
> > >
> > > Diffs
> > > -----
> > >
> > > server/src/com/cloud/server/ConfigurationServerImpl.java 596387f
> > >
> > > Diff: https://reviews.apache.org/r/10437/diff/
> > >
> > >
> > > Testing
> > > -------
> > >
> > > Rebuilt rpm and tested management server startup -- success
> > >
> > >
> > > Thanks,
> > >
> > > Phong Nguyen
> > >
> > >
> >
>
Re: Review Request: Fix command for executing injectkeys.sh
Posted by Chiradeep Vittal <Ch...@citrix.com>.
Doesn't look like it
On 4/15/13 10:07 AM, "Chip Childers" <ch...@sungard.com> wrote:
>Do I need a patch for this in 4.1?
>
>On Mon, Apr 15, 2013 at 05:02:07PM +0000, Chiradeep Vittal wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/10437/#review19193
>> -----------------------------------------------------------
>>
>> Ship it!
>>
>>
>> Ship It!
>>
>> - Chiradeep Vittal
>>
>>
>> On April 12, 2013, 9:11 p.m., Phong Nguyen wrote:
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/10437/
>> > -----------------------------------------------------------
>> >
>> > (Updated April 12, 2013, 9:11 p.m.)
>> >
>> >
>> > Review request for cloudstack and Hugo Trippaers.
>> >
>> >
>> > Description
>> > -------
>> >
>> > Management server unable to start (from rpm) due to invalid call to
>>Script for injectkeys.sh.
>> >
>> > 2013-04-12 15:02:13,496 WARN [cloud.server.ConfigurationServerImpl]
>>(Timer-1:null) Failed to inject generated public key into systemvm iso
>>java.io.IOException: Cannot run program "/bin/bash
>>/usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh":
>>error=2, No such file or directory
>> > at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
>> > at com.cloud.utils.script.Script.execute(Script.java:183)
>> >
>> >
>> > Diffs
>> > -----
>> >
>> > server/src/com/cloud/server/ConfigurationServerImpl.java 596387f
>> >
>> > Diff: https://reviews.apache.org/r/10437/diff/
>> >
>> >
>> > Testing
>> > -------
>> >
>> > Rebuilt rpm and tested management server startup -- success
>> >
>> >
>> > Thanks,
>> >
>> > Phong Nguyen
>> >
>> >
>>
Re: Review Request: Fix command for executing injectkeys.sh
Posted by Chip Childers <ch...@sungard.com>.
Do I need a patch for this in 4.1?
On Mon, Apr 15, 2013 at 05:02:07PM +0000, Chiradeep Vittal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10437/#review19193
> -----------------------------------------------------------
>
> Ship it!
>
>
> Ship It!
>
> - Chiradeep Vittal
>
>
> On April 12, 2013, 9:11 p.m., Phong Nguyen wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/10437/
> > -----------------------------------------------------------
> >
> > (Updated April 12, 2013, 9:11 p.m.)
> >
> >
> > Review request for cloudstack and Hugo Trippaers.
> >
> >
> > Description
> > -------
> >
> > Management server unable to start (from rpm) due to invalid call to Script for injectkeys.sh.
> >
> > 2013-04-12 15:02:13,496 WARN [cloud.server.ConfigurationServerImpl] (Timer-1:null) Failed to inject generated public key into systemvm iso java.io.IOException: Cannot run program "/bin/bash /usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh": error=2, No such file or directory
> > at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
> > at com.cloud.utils.script.Script.execute(Script.java:183)
> >
> >
> > Diffs
> > -----
> >
> > server/src/com/cloud/server/ConfigurationServerImpl.java 596387f
> >
> > Diff: https://reviews.apache.org/r/10437/diff/
> >
> >
> > Testing
> > -------
> >
> > Rebuilt rpm and tested management server startup -- success
> >
> >
> > Thanks,
> >
> > Phong Nguyen
> >
> >
>
Re: Review Request: Fix command for executing injectkeys.sh
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10437/#review19193
-----------------------------------------------------------
Ship it!
Ship It!
- Chiradeep Vittal
On April 12, 2013, 9:11 p.m., Phong Nguyen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10437/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 9:11 p.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Description
> -------
>
> Management server unable to start (from rpm) due to invalid call to Script for injectkeys.sh.
>
> 2013-04-12 15:02:13,496 WARN [cloud.server.ConfigurationServerImpl] (Timer-1:null) Failed to inject generated public key into systemvm iso java.io.IOException: Cannot run program "/bin/bash /usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh": error=2, No such file or directory
> at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
> at com.cloud.utils.script.Script.execute(Script.java:183)
>
>
> Diffs
> -----
>
> server/src/com/cloud/server/ConfigurationServerImpl.java 596387f
>
> Diff: https://reviews.apache.org/r/10437/diff/
>
>
> Testing
> -------
>
> Rebuilt rpm and tested management server startup -- success
>
>
> Thanks,
>
> Phong Nguyen
>
>
Re: Review Request: Fix command for executing injectkeys.sh
Posted by Phong Nguyen <pn...@gilt.com>.
This fixes an bug introduced in that commit.
I also want to point out that line 669 in ConfigurationServerImpl.java
traps exceptions thrown in development mode, hence this bug would not have
surfaced when ran in development mode. This 669 line appears to have been
committed months ago, removing it now results in not being able to find
vms/injectkeys.sh on startup (which seems related to another thread about
injectkeys.sh a few days ago).
-Phong
On Fri, Apr 12, 2013 at 6:50 PM, Chiradeep Vittal <
Chiradeep.Vittal@citrix.com> wrote:
> Does this conflict with
> 5cd3608 Remove the chmod solution and replace with an explicit call to
> /bin/bash. This way the file will only need read permissions.
>
>
>
> On 4/12/13 2:11 PM, "Phong Nguyen" <pn...@gilt.com> wrote:
>
> >
> >-----------------------------------------------------------
> >This is an automatically generated e-mail. To reply, visit:
> >https://reviews.apache.org/r/10437/
> >-----------------------------------------------------------
> >
> >Review request for cloudstack and Hugo Trippaers.
> >
> >
> >Description
> >-------
> >
> >Management server unable to start (from rpm) due to invalid call to
> >Script for injectkeys.sh.
> >
> >2013-04-12 15:02:13,496 WARN [cloud.server.ConfigurationServerImpl]
> >(Timer-1:null) Failed to inject generated public key into systemvm iso
> >java.io.IOException: Cannot run program "/bin/bash
> >/usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh": error=2,
> >No such file or directory
> > at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
> > at com.cloud.utils.script.Script.execute(Script.java:183)
> >
> >
> >Diffs
> >-----
> >
> > server/src/com/cloud/server/ConfigurationServerImpl.java 596387f
> >
> >Diff: https://reviews.apache.org/r/10437/diff/
> >
> >
> >Testing
> >-------
> >
> >Rebuilt rpm and tested management server startup -- success
> >
> >
> >Thanks,
> >
> >Phong Nguyen
> >
>
>
Re: Review Request: Fix command for executing injectkeys.sh
Posted by Chiradeep Vittal <Ch...@citrix.com>.
Does this conflict with
5cd3608 Remove the chmod solution and replace with an explicit call to
/bin/bash. This way the file will only need read permissions.
On 4/12/13 2:11 PM, "Phong Nguyen" <pn...@gilt.com> wrote:
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/10437/
>-----------------------------------------------------------
>
>Review request for cloudstack and Hugo Trippaers.
>
>
>Description
>-------
>
>Management server unable to start (from rpm) due to invalid call to
>Script for injectkeys.sh.
>
>2013-04-12 15:02:13,496 WARN [cloud.server.ConfigurationServerImpl]
>(Timer-1:null) Failed to inject generated public key into systemvm iso
>java.io.IOException: Cannot run program "/bin/bash
>/usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh": error=2,
>No such file or directory
> at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
> at com.cloud.utils.script.Script.execute(Script.java:183)
>
>
>Diffs
>-----
>
> server/src/com/cloud/server/ConfigurationServerImpl.java 596387f
>
>Diff: https://reviews.apache.org/r/10437/diff/
>
>
>Testing
>-------
>
>Rebuilt rpm and tested management server startup -- success
>
>
>Thanks,
>
>Phong Nguyen
>