You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/06 12:01:56 UTC
[GitHub] [flink] zentol commented on a diff in pull request #20170: [FLINK-28405][Connector/Kafka] Update Confluent Platform images used for testing to v7.2.2
zentol commented on code in PR #20170:
URL: https://github.com/apache/flink/pull/20170#discussion_r988947010
##########
flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml:
##########
@@ -156,6 +156,11 @@ under the License.
<version>${project.version}</version>
<type>test-jar</type>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>30.1.1-jre</version>
+ </dependency>
Review Comment:
So who actually needs this?
##########
flink-connectors/flink-connector-kafka/pom.xml:
##########
@@ -111,11 +111,12 @@ under the License.
</dependency>
<!-- Required to execute the kafka server for testing. Please change the zookeeper version accordingly when changing the Kafka version
+ Currently synced with Kafka 3.2.1
https://github.com/apache/kafka/blob/839b886f9b732b151e1faeace7303c80641c08c4/gradle/dependencies.gradle#L122 -->
<dependency>
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
- <version>3.5.9</version>
+ <version>3.6.3</version>
Review Comment:
Ideally this sticks with `${zookeeper.version}` if possible.
##########
flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientSchemaRegistryITCase.java:
##########
@@ -84,7 +86,7 @@ public class SQLClientSchemaRegistryITCase {
@ClassRule
public static final SchemaRegistryContainer REGISTRY =
- new SchemaRegistryContainer("6.2.2")
+ new SchemaRegistryContainer("7.2.2")
Review Comment:
Can we change this constructor to accept a full image name, and add it to DockerImageVersions for caching purposes?
##########
flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientSchemaRegistryITCase.java:
##########
@@ -71,6 +71,8 @@ public class SQLClientSchemaRegistryITCase {
private static final Path sqlToolBoxJar = ResourceTestUtils.getResource(".*SqlToolbox.jar");
private final Path sqlConnectorKafkaJar = ResourceTestUtils.getResource(".*kafka.jar");
+ private final Path sqlGuavaJar = ResourceTestUtils.getResource(".*guava.jar");
Review Comment:
```suggestion
private final Path guavaJar = ResourceTestUtils.getResource(".*guava.jar");
```
This isn't a sql jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org