[GitHub] [spark] pan3793 commented on a diff in pull request #43064: [SPARK-45265][SQL][WIP] Supporting Hive 4.0 metastore

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #43064:
URL: https://github.com/apache/spark/pull/43064#discussion_r1335221474


##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala:
##########
@@ -131,8 +131,16 @@ package object client {
         "org.pentaho:pentaho-aggdesigner-algorithm",
         "org.apache.hive:hive-vector-code-gen"))
 
+    // Since HIVE-14496, Hive.java uses calcite-core
+    case object v4_0 extends HiveVersion("4.0.0",
+      extraDeps = Seq("org.apache.derby:derby:10.14.2.0"),
+      exclusions = Seq("org.apache.calcite:calcite-druid",
+        "org.apache.curator:*",
+        "org.pentaho:pentaho-aggdesigner-algorithm",

Review Comment:
   Hive 4.0-beta1 depends on calcite 1.25, since CALCITE-1474 (calcite 1.11), `org.pentaho:pentaho-aggdesigner`(available in Conjar, which already sunset) was upgraded to `net.hydromatic:aggdesigner`(available in Maven Central), thus I think this exclusion is invalid, simply remove it would be fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org