You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Joel Wiegman (JIRA)" <de...@tapestry.apache.org> on 2007/09/12 00:14:32 UTC
[jira] Created: (TAPESTRY-1745) Palette javascript errors in
Internet Explorer
Palette javascript errors in Internet Explorer
----------------------------------------------
Key: TAPESTRY-1745
URL: https://issues.apache.org/jira/browse/TAPESTRY-1745
Project: Tapestry
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.0.5
Reporter: Joel Wiegman
A very simple <t:palette/> doesn't load properly in Internet Explorer (6.0 and 7.0). Javascript errors abound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1745) Palette javascript errors in
Internet Explorer
Posted by "Robert Zeigler (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532215 ]
Robert Zeigler commented on TAPESTRY-1745:
------------------------------------------
After some tracking (caveat: only have access to IE 7 at the moment, so there could be further issues on IE 6...), I found two places where IE is choking.
1) in palette.js; IE reports it as line 183 (last line in the file), but it's actually line 182. Looks like:
...
reorderSelected : function(movers, before) {
movers.each(function(option) { this.selected.add(option, before); }.bind(this));
this.updateHidden();
this.updateButtons();
},
};
The culprit is the last comma; IE is apparently unforgiving of trailing commas in map/array definitions.
Once you do that, the palette loads correctly, and almost functions correctly, too.
But there's another issue at line 132:
to.add(option, before);
An innocuous line. But according to:
http://www.quirksmode.org/dom/w3c_html.html#selects
There's some disagreement about the "before" argument among the major browsers.
W3C says it should be an option object, and mozilla, safari, and opera agree. Mozilla requires the extra argument; safari and opera allow it.
IE allows the 2nd argument, but expects it to be the /index/ before which to insert the option, rather than an option argument. Hence, the line above generates a "Type mismatch" error in IE.
I'll try to attach a patch later today.
> Palette javascript errors in Internet Explorer
> ----------------------------------------------
>
> Key: TAPESTRY-1745
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1745
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: Joel Wiegman
>
> A very simple <t:palette/> doesn't load properly in Internet Explorer (6.0 and 7.0). Javascript errors abound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAPESTRY-1745) Palette javascript errors in
Internet Explorer
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAPESTRY-1745.
------------------------------------------
Resolution: Fixed
Fix Version/s: 5.0.7
Assignee: Howard M. Lewis Ship
> Palette javascript errors in Internet Explorer
> ----------------------------------------------
>
> Key: TAPESTRY-1745
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1745
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: Joel Wiegman
> Assignee: Howard M. Lewis Ship
> Fix For: 5.0.7
>
> Attachments: 1745_patch.txt
>
>
> A very simple <t:palette/> doesn't load properly in Internet Explorer (6.0 and 7.0). Javascript errors abound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1745) Palette javascript errors in
Internet Explorer
Posted by "Robert Zeigler (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler updated TAPESTRY-1745:
-------------------------------------
Attachment: 1745_patch.txt
1745_patch.txt is a patch to palette.js which removes the extraneous comma after the last palette function definition. It also wraps the "to.add(option,before)" line in a try/catch block, and attempts to.add with an index value for the "before" argument on exception.
Tested in IE 7, IE 6, Safari 3, and Opera 9.
> Palette javascript errors in Internet Explorer
> ----------------------------------------------
>
> Key: TAPESTRY-1745
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1745
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: Joel Wiegman
> Attachments: 1745_patch.txt
>
>
> A very simple <t:palette/> doesn't load properly in Internet Explorer (6.0 and 7.0). Javascript errors abound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1745) Palette javascript errors in
Internet Explorer
Posted by "Robert Zeigler (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531999 ]
Robert Zeigler commented on TAPESTRY-1745:
------------------------------------------
I can confirm that the palette is borked in at least IE 6, although the confirmation comes by guiding someone else through navigating to a page containing a palette and verifying that it didn't work... so I don't have exact exception messages at the moment. I'll dig into this one the next time I have window's handy.
> Palette javascript errors in Internet Explorer
> ----------------------------------------------
>
> Key: TAPESTRY-1745
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1745
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: Joel Wiegman
>
> A very simple <t:palette/> doesn't load properly in Internet Explorer (6.0 and 7.0). Javascript errors abound.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org