You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by scottyaslan <gi...@git.apache.org> on 2016/07/21 22:59:25 UTC
[GitHub] nifi pull request #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIF...
GitHub user scottyaslan opened a pull request:
https://github.com/apache/nifi/pull/703
[NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIFI-2134]
-update dialog advanced buttons
-fix Add inline controller service dialog description width
-update provenance details dialog
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottyaslan/nifi devBranch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/703.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #703
----
commit 57a6bd2acd333b249cbfa93ac67bc6a178cef335
Author: Scott Aslan <ja...@hortonworks.com>
Date: 2016-07-21T22:39:59Z
[NIFI-2050] update dialog advanced buttons
commit 8eb525779b1199bde720f148b1c8f1772e3a9b7e
Author: Scott Aslan <ja...@hortonworks.com>
Date: 2016-07-21T22:40:15Z
[NIFI-2076] fix Add inline controller service dialog description width
commit b1ae45c0c7cee5da8c3d3863e7cd2e9c24b7f176
Author: Scott Aslan <ja...@hortonworks.com>
Date: 2016-07-21T22:41:32Z
[NIFI-2136] [NIFI-2139] [NIFI-2134] update provenance details dialog
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIFI-2134]...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/703
Thanks @scottyaslan! Looks good.. this has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIF...
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi/pull/703#discussion_r71937315
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/provenance.css ---
@@ -178,31 +178,26 @@ div.flowfile-container {
width: 282px;
height: 120px;
--- End diff --
@scottyaslan I think we can remove the `height` property all together so the Children FlowFiles heading will not sit so far below Parent FlowFile heading
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIF...
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi/pull/703#discussion_r71936940
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/provenance.css ---
@@ -270,11 +272,13 @@ div.modified-attribute-label {
div.modified-attribute-value {
--- End diff --
@scottyaslan please add `font-weight: 500;` and change `padding-top: 5px;` to `padding-top: 2px;`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIF...
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi/pull/703#discussion_r71937949
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/common-ui.css ---
@@ -150,9 +150,8 @@ ul.links span.header-link-over {
}
.blank, .unset, .sensitive {
--- End diff --
@scottyaslan Where `.unset` is being applied here, it needs `font-size: 13px` and `padding-top: 2px`
Not sure all places the other classes are referenced...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIF...
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi/pull/703#discussion_r71937491
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/provenance.css ---
@@ -178,31 +178,26 @@ div.flowfile-container {
width: 282px;
height: 120px;
--- End diff --
@scottyaslan Also please add `line-height:1.4`. When multiples are listed they sit a little close to each other.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIF...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/703
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---