You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Graham Gear (JIRA)" <ji...@apache.org> on 2012/09/05 20:22:07 UTC
[jira] [Created] (WHIRR-649) Make install_cdh_hadoop.sh idempotent,
fast failing if already run
Graham Gear created WHIRR-649:
---------------------------------
Summary: Make install_cdh_hadoop.sh idempotent, fast failing if already run
Key: WHIRR-649
URL: https://issues.apache.org/jira/browse/WHIRR-649
Project: Whirr
Issue Type: Improvement
Affects Versions: 0.7.1
Reporter: Graham Gear
Currently, install_cdh_hadoop.sh does not check it has already run and return, unlike install_hadoop.sh.
This is inefficient for services that would like to install CDH components which have often already been installed (eg Cloudera Manager).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-649) Make install_cdh_hadoop.sh idempotent,
fast failing if already run
Posted by "Graham Gear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Graham Gear updated WHIRR-649:
------------------------------
Attachment: WHIRR-649.patch
> Make install_cdh_hadoop.sh idempotent, fast failing if already run
> ------------------------------------------------------------------
>
> Key: WHIRR-649
> URL: https://issues.apache.org/jira/browse/WHIRR-649
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Graham Gear
> Attachments: WHIRR-649.patch
>
>
> Currently, install_cdh_hadoop.sh does not check it has already run and return, unlike install_hadoop.sh.
> This is inefficient for services that would like to install CDH components which have often already been installed (eg Cloudera Manager).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WHIRR-649) Make install_cdh_hadoop.sh
idempotent, fast failing if already run
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White resolved WHIRR-649.
-----------------------------
Resolution: Fixed
Fix Version/s: 0.8.1
I just committed this. Thanks Graham!
> Make install_cdh_hadoop.sh idempotent, fast failing if already run
> ------------------------------------------------------------------
>
> Key: WHIRR-649
> URL: https://issues.apache.org/jira/browse/WHIRR-649
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Graham Gear
> Assignee: Graham Gear
> Fix For: 0.8.1
>
> Attachments: WHIRR-649.patch
>
>
> Currently, install_cdh_hadoop.sh does not check it has already run and return, unlike install_hadoop.sh.
> This is inefficient for services that would like to install CDH components which have often already been installed (eg Cloudera Manager).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-649) Make install_cdh_hadoop.sh
idempotent, fast failing if already run
Posted by "Graham Gear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449102#comment-13449102 ]
Graham Gear commented on WHIRR-649:
-----------------------------------
Actually, I can see now from the code that the install pipeline is protected from running a script multiple times so this is not an issue.
This does however optimise install_cdh* scripts that require base CDH installations (eg HBase/YARN etc) so is still a worthwhile patch, once updated to also check INSTALL_HADOOP_DONE.
> Make install_cdh_hadoop.sh idempotent, fast failing if already run
> ------------------------------------------------------------------
>
> Key: WHIRR-649
> URL: https://issues.apache.org/jira/browse/WHIRR-649
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Graham Gear
> Attachments: WHIRR-649.patch
>
>
> Currently, install_cdh_hadoop.sh does not check it has already run and return, unlike install_hadoop.sh.
> This is inefficient for services that would like to install CDH components which have often already been installed (eg Cloudera Manager).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (WHIRR-649) Make install_cdh_hadoop.sh
idempotent, fast failing if already run
Posted by "Graham Gear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449102#comment-13449102 ]
Graham Gear edited comment on WHIRR-649 at 9/6/12 7:37 AM:
-----------------------------------------------------------
Actually, I can see now from the code that the install pipeline is protected from running a script multiple times so this is not an issue.
This does however optimise install_cdh* scripts that require base CDH installations (eg HBase/YARN etc), once updated to also check INSTALL_HADOOP_DONE, so is still a worthwhile patch.
was (Author: graham.gear):
Actually, I can see now from the code that the install pipeline is protected from running a script multiple times so this is not an issue.
This does however optimise install_cdh* scripts that require base CDH installations (eg HBase/YARN etc) so is still a worthwhile patch, once updated to also check INSTALL_HADOOP_DONE.
> Make install_cdh_hadoop.sh idempotent, fast failing if already run
> ------------------------------------------------------------------
>
> Key: WHIRR-649
> URL: https://issues.apache.org/jira/browse/WHIRR-649
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Graham Gear
> Attachments: WHIRR-649.patch
>
>
> Currently, install_cdh_hadoop.sh does not check it has already run and return, unlike install_hadoop.sh.
> This is inefficient for services that would like to install CDH components which have often already been installed (eg Cloudera Manager).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-649) Make install_cdh_hadoop.sh
idempotent, fast failing if already run
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449804#comment-13449804 ]
Tom White commented on WHIRR-649:
---------------------------------
+1 The patch is an improvement.
> Make install_cdh_hadoop.sh idempotent, fast failing if already run
> ------------------------------------------------------------------
>
> Key: WHIRR-649
> URL: https://issues.apache.org/jira/browse/WHIRR-649
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Graham Gear
> Attachments: WHIRR-649.patch
>
>
> Currently, install_cdh_hadoop.sh does not check it has already run and return, unlike install_hadoop.sh.
> This is inefficient for services that would like to install CDH components which have often already been installed (eg Cloudera Manager).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-649) Make install_cdh_hadoop.sh
idempotent, fast failing if already run
Posted by "Graham Gear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449120#comment-13449120 ]
Graham Gear commented on WHIRR-649:
-----------------------------------
I also note, that since a install_hadoop invoked install_cdh_hadoop script includes a tarball paramater, it qualifies as not equal to a parameterless install_cdh_hadoop statement and therefore results in 2 invocations of this function, Eg:
{code:title=bootstrap-*.sh|borderStyle=solid}
install_oab_java || exit 1
install_cdh_hadoop -u http://apache.osuosl.org/hadoop/common/hadoop-0.20.205.0/hadoop-0.20.205.0.tar.gz || exit 1
install_cdh_hadoop || exit 1
install_cm || exit 1
{code}
This patch protects against running this function twice, although there is a bit of code smell around this.
> Make install_cdh_hadoop.sh idempotent, fast failing if already run
> ------------------------------------------------------------------
>
> Key: WHIRR-649
> URL: https://issues.apache.org/jira/browse/WHIRR-649
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Graham Gear
> Attachments: WHIRR-649.patch
>
>
> Currently, install_cdh_hadoop.sh does not check it has already run and return, unlike install_hadoop.sh.
> This is inefficient for services that would like to install CDH components which have often already been installed (eg Cloudera Manager).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-649) Make install_cdh_hadoop.sh idempotent,
fast failing if already run
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-649:
------------------------------
Assignee: Graham Gear
> Make install_cdh_hadoop.sh idempotent, fast failing if already run
> ------------------------------------------------------------------
>
> Key: WHIRR-649
> URL: https://issues.apache.org/jira/browse/WHIRR-649
> Project: Whirr
> Issue Type: Improvement
> Affects Versions: 0.7.1
> Reporter: Graham Gear
> Assignee: Graham Gear
> Attachments: WHIRR-649.patch
>
>
> Currently, install_cdh_hadoop.sh does not check it has already run and return, unlike install_hadoop.sh.
> This is inefficient for services that would like to install CDH components which have often already been installed (eg Cloudera Manager).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira