You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/10 00:22:41 UTC
[GitHub] [arrow-datafusion] jdye64 opened a new pull request #1970: Address typo in ExprVisitable trait documentation
jdye64 opened a new pull request #1970:
URL: https://github.com/apache/arrow-datafusion/pull/1970
# Which issue does this PR close?
N/A very small change and CONTRIBUTING.md lead me to believe it was not needed. If indeed an issue is required I'm happen to open one.
# Rationale for this change
Simple typo in documentation that presents itself in the docs
# What changes are included in this PR?
single line change of docs
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen commented on pull request #1970: Address typo in ExprVisitable trait documentation
Posted by GitBox <gi...@apache.org>.
yjshen commented on pull request #1970:
URL: https://github.com/apache/arrow-datafusion/pull/1970#issuecomment-1064154488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jdye64 commented on pull request #1970: Address typo in ExprVisitable trait documentation
Posted by GitBox <gi...@apache.org>.
jdye64 commented on pull request #1970:
URL: https://github.com/apache/arrow-datafusion/pull/1970#issuecomment-1065899530
I agree. I had simply noticed the multiple instances of "bar" and just naively assumed it should have been changed to "foo". Would you like another PR since this one is merged now or just another commit to this branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen removed a comment on pull request #1970: Address typo in ExprVisitable trait documentation
Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on pull request #1970:
URL: https://github.com/apache/arrow-datafusion/pull/1970#issuecomment-1064154488
```rust
struct Print{}
impl ExpressionVisitor for Print {
fn pre_visit(self, expr: &Expr) -> datafusion_common::Result<Recursion<Self>> where Self: ExpressionVisitor {
println!("pre {}", expr);
Ok(Recursion::Continue(self))
}
fn post_visit(self, expr: &Expr) -> datafusion_common::Result<Self> {
println!("post {}", expr);
Ok(self)
}
}
#[test]
fn a() {
let a = BinaryExpr {
left: Box::new(Expr::Column(Column::from_name("foo"))),
op: Operator::Gt,
right: Box::new(Expr::Column(Column::from_name("bar")))
};
a.accept(Print{}).unwrap();
}
```
and I get
```
pre #foo > #bar
pre #foo
post #foo
pre #bar
post #bar
post #foo > #bar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #1970: Address typo in ExprVisitable trait documentation
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1970:
URL: https://github.com/apache/arrow-datafusion/pull/1970#issuecomment-1065816346
@jdye64 I think the order that @yjshen printed should the be right order instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jdye64 commented on pull request #1970: Address typo in ExprVisitable trait documentation
Posted by GitBox <gi...@apache.org>.
jdye64 commented on pull request #1970:
URL: https://github.com/apache/arrow-datafusion/pull/1970#issuecomment-1065899639
Nevermind. Noticed @alamb PR #1996 after sending my previous message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #1970: Address typo in ExprVisitable trait documentation
Posted by GitBox <gi...@apache.org>.
andygrove merged pull request #1970:
URL: https://github.com/apache/arrow-datafusion/pull/1970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1970: Address typo in ExprVisitable trait documentation
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1970:
URL: https://github.com/apache/arrow-datafusion/pull/1970#issuecomment-1065865226
https://github.com/apache/arrow-datafusion/pull/1996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1970: Address typo in ExprVisitable trait documentation
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1970:
URL: https://github.com/apache/arrow-datafusion/pull/1970#issuecomment-1065938340
> I agree. I had simply noticed the multiple instances of "bar" and just naively assumed it should have been changed to "foo". Would you like another PR since this one is merged now or just another commit to this branch?
@jdye64 thank you -- this PR definitely made the comment *more* correct than it was lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org