[GitHub] [helix] narendly commented on a change in pull request #632: Asynchronously calculating the Baseline

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #632: Asynchronously calculating the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r351633686
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
 ##########
 @@ -822,6 +828,19 @@ public void setGlobalRebalancePreference(Map<GlobalRebalancePreferenceKey, Integ
     return DEFAULT_GLOBAL_REBALANCE_PREFERENCE;
   }
 
+  /**
+   * Set the asynchronous global rebalance option.
+   * @param isAsync true if the global rebalance should be calculated asynchronously
+   */
+  public void setAsyncGlobalRebalance(boolean isAsync) {
+    _record.setBooleanField(ClusterConfigProperty.ASYNC_GLOBAL_REBALANCE.name(), isAsync);
+  }
+
+  public boolean getAsyncGlobalRebalance() {
 
 Review comment:
   Rename to `isAsyncGlobalRebalanceEnabled`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org