[GitHub] [pinot] summerhasama-stripe commented on a diff in pull request #10983: Message batch ingestion lag fix

["summerhasama-stripe (via GitHub)" <gi...@apache.org>]

summerhasama-stripe commented on code in PR #10983:
URL: https://github.com/apache/pinot/pull/10983#discussion_r1245377750


##########
pinot-spi/src/test/java/org/apache/pinot/spi/stream/StreamDataDecoderImplTest.java:
##########
@@ -41,7 +41,7 @@ public void testDecodeValueOnly()
     messageDecoder.init(Collections.emptyMap(), ImmutableSet.of(NAME_FIELD), "");
     String value = "Alice";
     StreamMessage<byte[]> message = new StreamMessage(value.getBytes(StandardCharsets.UTF_8),
-        value.getBytes(StandardCharsets.UTF_8).length);
+        value.getBytes(StandardCharsets.UTF_8).length, null);

Review Comment:
   Yes, this test seems to be focused on the StreamDataDecoder so I added to a different unit test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org