[GitHub] [incubator-superset] villebro commented on a change in pull request #8038: Prevent 'main' database connection creation

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8038: Prevent 'main' database connection creation
URL: https://github.com/apache/incubator-superset/pull/8038#discussion_r321078356
 
 

 ##########
 File path: tests/sqllab_tests.py
 ##########
 @@ -160,11 +148,15 @@ def test_queries_endpoint(self):
     def test_search_query_on_db_id(self):
         self.run_some_queries()
         self.login("admin")
+        examples_dbid = get_example_database().id
+
         # Test search queries on database Id
-        data = self.get_json_resp("/superset/search_queries?database_id=1")
+        data = self.get_json_resp(
+            f"/superset/search_queries?database_id={examples_dbid}"
+        )
 
 Review comment:
   👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org