You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by GitBox <gi...@apache.org> on 2020/10/12 18:34:16 UTC
[GitHub] [roller] mbien opened a new pull request #67: Velocity Renovations
mbien opened a new pull request #67:
URL: https://github.com/apache/roller/pull/67
@snoopdave This PR contains the Velocity changes of the wip branch.
main commit:
upgraded apache velocity from 1.7 to 2.2.
Build-time DB script generation is still using velocity 1.7 but it is now a build-time plugin dependency,
since it is the last version which contained the Texen Ant task.
TODO: GeneratePlanetTask is not ported yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [roller] snoopdave merged pull request #67: Velocity Renovations
Posted by GitBox <gi...@apache.org>.
snoopdave merged pull request #67:
URL: https://github.com/apache/roller/pull/67
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [roller] snoopdave commented on a change in pull request #67: Velocity Renovations
Posted by GitBox <gi...@apache.org>.
snoopdave commented on a change in pull request #67:
URL: https://github.com/apache/roller/pull/67#discussion_r504297651
##########
File path: app/src/main/java/org/apache/roller/weblogger/ui/rendering/velocity/RollerResourceLoader.java
##########
@@ -105,7 +109,7 @@ public InputStream getResourceStream(String name) {
logger.error(uex);
throw new RuntimeException(uex);
- } catch (Exception re) {
+ } catch (WebloggerException | ResourceNotFoundException re) {
Review comment:
Nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org