You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/08/07 22:39:22 UTC
impala git commit: IMPALA-7393: log query IDs for e2e tests
Repository: impala
Updated Branches:
refs/heads/master d33d5b74c -> 96e552eb2
IMPALA-7393: log query IDs for e2e tests
Logging is implemented at the BeeswaxConnection level for expedience.
Implementing at the ImpalaBeeswaxClient level would require logging
in multiple places and non-trivial restructuring since the handle is
not exposed to ImpalaBeeswaxClient.execute()
Testing:
Ran core tests.
Change-Id: Idbb552097ddfda1f96c9d2c5939a54430e0e6e31
Reviewed-on: http://gerrit.cloudera.org:8080/11134
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/96e552eb
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/96e552eb
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/96e552eb
Branch: refs/heads/master
Commit: 96e552eb2fa7138e3115ac1eb9c56aa56d445d6e
Parents: d33d5b7
Author: Tim Armstrong <ta...@cloudera.com>
Authored: Mon Aug 6 16:20:39 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Tue Aug 7 21:23:21 2018 +0000
----------------------------------------------------------------------
tests/beeswax/impala_beeswax.py | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/96e552eb/tests/beeswax/impala_beeswax.py
----------------------------------------------------------------------
diff --git a/tests/beeswax/impala_beeswax.py b/tests/beeswax/impala_beeswax.py
index 9489ed4..1a3bc65 100644
--- a/tests/beeswax/impala_beeswax.py
+++ b/tests/beeswax/impala_beeswax.py
@@ -25,6 +25,7 @@
# client.connect()
# result = client.execute(query_string)
# where result is an object of the class ImpalaBeeswaxResult.
+import logging
import time
import shlex
import getpass
@@ -44,6 +45,8 @@ from thrift.transport.TTransport import TTransportException
from thrift.protocol import TBinaryProtocol
from thrift.Thrift import TApplicationException
+LOG = logging.getLogger('impala_beeswax')
+
# Custom exception wrapper.
# All exceptions coming from thrift/beeswax etc. go through this wrapper.
# __str__ preserves the exception type.
@@ -336,7 +339,9 @@ class ImpalaBeeswaxClient(object):
query.query = query_string
query.hadoop_user = user if user is not None else getpass.getuser()
query.configuration = self.__options_to_string_list()
- return self.__do_rpc(lambda: self.imp_service.query(query,))
+ handle = self.__do_rpc(lambda: self.imp_service.query(query,))
+ LOG.info("Started query {0}".format(handle.id))
+ return handle
def __execute_query(self, query_string, user=None):
"""Executes a query and waits for completion"""