[GitHub] [pulsar-adapters] cbornet opened a new pull request, #44: Remove dependency on org.apache.pulsar.functions.utils.FunctionCommon in kafka-compat

["cbornet (via GitHub)" <gi...@apache.org>]

cbornet opened a new pull request, #44:
URL: https://github.com/apache/pulsar-adapters/pull/44

   ### Motivation
   
   `org.apache.pulsar.functions.utils.FunctionCommon` class is part of pulsar-functions and is built with JDK17 but for the client libs we need compatibility with JDK8.
   
   ### Modifications
   
   Copy `FunctionCommon::getSequenceId` code to a local method.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   no
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no) no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-adapters] cbornet merged pull request #44: Remove dependency on org.apache.pulsar.functions.utils.FunctionCommon in kafka-compat

["cbornet (via GitHub)" <gi...@apache.org>]

cbornet merged PR #44:
URL: https://github.com/apache/pulsar-adapters/pull/44


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org