You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/11 12:50:50 UTC

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1754: esp32-core: Add support for the external SPIFLASH

Ouss4 commented on a change in pull request #1754:
URL: https://github.com/apache/incubator-nuttx/pull/1754#discussion_r487022744



##########
File path: boards/xtensa/esp32/esp32-core/Kconfig
##########
@@ -44,4 +44,23 @@ config ESP32CORE_FLASH_IMAGE
 	---help---
 		Create flash_image.bin mainly used for QEMU.
 
+choice

Review comment:
       We could add any other file system, I just picked some of what we have in the repo.
   The board logic that was added with this PR prepares the driver to be mounted on a file system, but the SPIFLASH driver itself is completely independent from that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org