[GitHub] [geode] dschneider-pivotal opened pull request #2996: GEODE-6102: fail destroy data-source if in use

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

destroy data-source will now fail if it is used by a jdbc-mapping.
Also the command is now only available if gfsh is connected.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2996 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2996: GEODE-6102: fail destroy data-source if in use

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

--name should be --region

[ Full content available at: https://github.com/apache/geode/pull/2996 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2996: GEODE-6102: fail destroy data-source if in use

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

it is adding the name of the region/jdbc-mapping that is using the data source

[ Full content available at: https://github.com/apache/geode/pull/2996 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on issue #2996: GEODE-6102: fail destroy data-source if in use

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

The test failures are not related to this pull request

[ Full content available at: https://github.com/apache/geode/pull/2996 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #2996: GEODE-6102: fail destroy data-source if in use

["agingade (GitHub)" <gi...@apache.org>]

Doesn't look like ex.getMessage() is adding any helpful info here.

[ Full content available at: https://github.com/apache/geode/pull/2996 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal closed pull request #2996: GEODE-6102: fail destroy data-source if in use

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by dschneider-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/2996 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2996: GEODE-6102: fail destroy data-source if in use

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

done

[ Full content available at: https://github.com/apache/geode/pull/2996 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org