You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/08/11 17:45:40 UTC

[GitHub] [hadoop] LALAYANG opened a new pull request #3298: MAPREDUCE-7361. Clean shared state pollution to avoid flaky tests in class TestTaskProgressReporter

LALAYANG opened a new pull request #3298:
URL: https://github.com/apache/hadoop/pull/3298


   Link to issue: [https://issues.apache.org/jira/browse/MAPREDUCE-7361](https://issues.apache.org/jira/browse/MAPREDUCE-7361)
   ## What is the purpose of this change
   This PR is to clean the polluted shared status among the 3 tests: 
   ```
   Test1: org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit
   Test2: org.apache.hadoop.mapred.TestTaskProgressReporter.testScratchDirSize
   Test3: org.apache.hadoop.mapred.TestTaskProgressReporter.testTaskProgress
   ```
   - Test1 and Test2 pollute the shared status with Test3, which can make test3 fail. 
   - It may be better to clean state pollutions so that some other tests won't fail in the future due to the shared state polluted by this test.
   ## Reproduce the test failures
   Run the tests in the same JVM in the following orders:
   - Test1 and Test3
   - Test2 and Test3
   ## Expected result
   The tests should run successfully when multiple tests that use this shared state are run in the same JVM.
   ## Actual result
   - Run Test1 and Test3, Test3 fails:
   ```
   [ERROR]   TestTaskProgressReporter.testTaskProgress:267 expected:<[2]> but was:<[3]>
   ```
   - Run Test2 and Test3, Test3 fails:
   ```
   [ERROR]   TestTaskProgressReporter.testTaskProgress:267 expected:<[2]> but was:<[11]>
   ```
   
   ## Fix
   Clean the value of `statusUpdateTimes` to 0 at the start of Test3 to clean the pollution from Test1 and Test2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org