You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kyteware (via GitHub)" <gi...@apache.org> on 2025/06/19 21:48:54 UTC

[PR] fix: include sqlite-required features in sqlx dep [iceberg-rust]

kyteware opened a new pull request, #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   - Closes #1456.
   
   ## What changes are included in this PR?
   
   <!--
   Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates.
   -->
   
   - Included the needed dependencies to the sql catalog crate
   
   ## Are these changes tested?
   
   <!--
   Specify what test covers (unit test, integration test, etc.).
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   They were already tested, but only the tests had the right features :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: include sqlite-required features in sqlx dep [iceberg-rust]

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 closed pull request #1457: fix: include sqlite-required features in sqlx dep
URL: https://github.com/apache/iceberg-rust/pull/1457


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: include sqlite-required features in sqlx dep [iceberg-rust]

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457#issuecomment-2991634952

   Thanks @kyteware for this pr, but I don't think this should be included in iceberg. Default features of `sqlx` is disabled, so users are free to enable `sqlx` features in their application.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: include sqlite-required features in sqlx dep [iceberg-rust]

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457#issuecomment-2991638049

   I'll close this issue for now as this is not the correct way to go. Feel free to reopen it if you feel it necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: include sqlite-required features in sqlx dep [iceberg-rust]

Posted by "kyteware (via GitHub)" <gi...@apache.org>.
kyteware commented on PR #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457#issuecomment-2989204156

   I haven't fully investigated what the other features in `[dev-dependencies]` for `sqlx` are needed for, but its possible that the rest of them should also be included in the regular deps as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: include sqlite-required features in sqlx dep [iceberg-rust]

Posted by "kyteware (via GitHub)" <gi...@apache.org>.
kyteware commented on PR #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457#issuecomment-2989387696

   I would appreciate a re-run of the test CI, all tests pass but it looks like the VM running it lost connection.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: include sqlite-required features in sqlx dep [iceberg-rust]

Posted by "kyteware (via GitHub)" <gi...@apache.org>.
kyteware commented on PR #1457:
URL: https://github.com/apache/iceberg-rust/pull/1457#issuecomment-2993069781

   @liurenjie1024 Wow, you're totally right! I didn't realize you could do that with cargo features. I'll make another PR to document this instead. Thanks for the insight.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org