You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/23 11:50:44 UTC
[GitHub] [shardingsphere] jiangML opened a new pull request, #23068: Optimize agent
jiangML opened a new pull request, #23068:
URL: https://github.com/apache/shardingsphere/pull/23068
For #23067
Changes proposed in this pull request:
- Remove MethodInvocationResult.
- The method afterMethod() of InstanceMethodAdvice and StaticMethodAdvice adds the original execution result as an input parameter.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23068: Optimize agent
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23068:
URL: https://github.com/apache/shardingsphere/pull/23068#issuecomment-1363912070
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23068?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23068](https://codecov.io/gh/apache/shardingsphere/pull/23068?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ef2a12) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7677c79b68f6a7df19b05137776db8a195a165b2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7677c79) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #23068 +/- ##
=========================================
Coverage 50.03% 50.03%
Complexity 2424 2424
=========================================
Files 4110 4109 -1
Lines 57354 57348 -6
Branches 9048 9044 -4
=========================================
+ Hits 28695 28696 +1
+ Misses 26149 26146 -3
+ Partials 2510 2506 -4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23068?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ing/base/advice/MetaDataContextsFactoryAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23068/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9sb2dnaW5nL2Jhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi9sb2dnaW5nL2Jhc2UvYWR2aWNlL01ldGFEYXRhQ29udGV4dHNGYWN0b3J5QWR2aWNlLmphdmE=) | `0.00% <ø> (ø)` | |
| [...gent/metrics/core/advice/ChannelHandlerAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23068/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvY29yZS9hZHZpY2UvQ2hhbm5lbEhhbmRsZXJBZHZpY2UuamF2YQ==) | `91.66% <ø> (ø)` | |
| [...metrics/core/advice/CommandExecutorTaskAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23068/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvY29yZS9hZHZpY2UvQ29tbWFuZEV4ZWN1dG9yVGFza0FkdmljZS5qYXZh) | `85.71% <ø> (ø)` | |
| [...e/agent/metrics/core/advice/TransactionAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23068/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvY29yZS9hZHZpY2UvVHJhbnNhY3Rpb25BZHZpY2UuamF2YQ==) | `90.00% <ø> (ø)` | |
| [...acing/jaeger/advice/CommandExecutorTaskAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23068/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL3R5cGUvamFlZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vdHJhY2luZy9qYWVnZXIvYWR2aWNlL0NvbW1hbmRFeGVjdXRvclRhc2tBZHZpY2UuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...cing/jaeger/advice/JDBCExecutorCallbackAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23068/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL3R5cGUvamFlZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vdHJhY2luZy9qYWVnZXIvYWR2aWNlL0pEQkNFeGVjdXRvckNhbGxiYWNrQWR2aWNlLmphdmE=) | `92.00% <ø> (ø)` | |
| [...n/tracing/jaeger/advice/SQLParserEngineAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23068/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL3R5cGUvamFlZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9wbHVnaW4vdHJhY2luZy9qYWVnZXIvYWR2aWNlL1NRTFBhcnNlckVuZ2luZUFkdmljZS5qYXZh) | `100.00% <ø> (ø)` | |
| [...pentelemetry/advice/CommandExecutorTaskAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23068/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL3R5cGUvb3BlbnRlbGVtZXRyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL3RyYWNpbmcvb3BlbnRlbGVtZXRyeS9hZHZpY2UvQ29tbWFuZEV4ZWN1dG9yVGFza0FkdmljZS5qYXZh) | `100.00% <ø> (ø)` | |
| [...entelemetry/advice/JDBCExecutorCallbackAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23068/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL3R5cGUvb3BlbnRlbGVtZXRyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL3RyYWNpbmcvb3BlbnRlbGVtZXRyeS9hZHZpY2UvSkRCQ0V4ZWN1dG9yQ2FsbGJhY2tBZHZpY2UuamF2YQ==) | `92.00% <ø> (ø)` | |
| [...ng/opentelemetry/advice/SQLParserEngineAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23068/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy90cmFjaW5nL3R5cGUvb3BlbnRlbGVtZXRyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL3RyYWNpbmcvb3BlbnRlbGVtZXRyeS9hZHZpY2UvU1FMUGFyc2VyRW5naW5lQWR2aWNlLmphdmE=) | `93.33% <ø> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/shardingsphere/pull/23068/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #23068: Optimize agent
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #23068:
URL: https://github.com/apache/shardingsphere/pull/23068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org