You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Sebb (Created) (JIRA)" <ji...@apache.org> on 2012/03/22 19:42:23 UTC

[jira] [Created] (CSV-81) Token.Type.isReady could perhaps be removed

Token.Type.isReady could perhaps be removed
-------------------------------------------

                 Key: CSV-81
                 URL: https://issues.apache.org/jira/browse/CSV-81
             Project: Commons CSV
          Issue Type: Improvement
            Reporter: Sebb


The isReady field is written in lots of places, but only read in 2 places:

1) CSVParser.getRecord() uses it to determine if there was any data found at EOF
2) CSVLexer.nextToken uses it to determine when to exit the loop, but could equally probably check for type == INVALID

It ought to be possible to simplify this considerably since the only usage external to the Lexer is to distinguish the EOF case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CSV-81) Token.Type.isReady could perhaps be removed

Posted by "Sebb (Resolved) (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/CSV-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved CSV-81.
---------------------

    Resolution: Fixed
    
> Token.Type.isReady could perhaps be removed
> -------------------------------------------
>
>                 Key: CSV-81
>                 URL: https://issues.apache.org/jira/browse/CSV-81
>             Project: Commons CSV
>          Issue Type: Improvement
>            Reporter: Sebb
>
> The isReady field is written in lots of places, but only read in 2 places:
> 1) CSVParser.getRecord() uses it to determine if there was any data found at EOF
> 2) CSVLexer.nextToken uses it to determine when to exit the loop, but could equally probably check for type == INVALID
> It ought to be possible to simplify this considerably since the only usage external to the Lexer is to distinguish the EOF case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira