You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@dolphinscheduler.apache.org by GabryWu <wu...@qq.com> on 2020/05/18 05:48:37 UTC

is lock inside LowerWeightHostManager.getWorkerHostWeights necessary ?

hi ,all&nbsp;
I noticed that there is a ReentrantLock to protect workerHostWeights field which is already thread-safe ConcurrentHashMap.
I think this is not necessary ,right ? If not ,why?&nbsp;
One PR created to remove the unnecessary lock , if the lock can be removed ,who can help to review and merge this PR ?
&nbsp;https://github.com/apache/incubator-dolphinscheduler/pull/2730