You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/15 00:32:25 UTC

[GitHub] [flink] tianon commented on pull request #14630: [FLINK-20915][docker] Move docker entrypoint to distribution

tianon commented on pull request #14630:
URL: https://github.com/apache/flink/pull/14630#issuecomment-760564996


   > @wangyang0918 I have outlined this approach and already gotten their approval. [docker-library/official-images#9249 (comment)](https://github.com/docker-library/official-images/pull/9249#issuecomment-756902869)
   > (note that I had the same hunch as you though, and was actually surprised that they were fine with it)
   
   To clarify - I did _not_ mean simply moving the entrypoint script into Flink.  I meant moving the _functionality_ into Flink.  Many of the things that happen in that script are things that probably make sense for other (non-container) users of Flink as well, and it feels wrong for those implementations to happen in the Dockerization scripts.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org