[GitHub] [beam] pcoet commented on a diff in pull request #21731: [Website] add guard expressions to fix-menu and page-nav

[GitBox <gi...@apache.org>]

pcoet commented on code in PR #21731:
URL: https://github.com/apache/beam/pull/21731#discussion_r899188314


##########
website/www/site/assets/js/fix-menu.js:
##########
@@ -64,9 +64,14 @@ $(document).ready(function() {
           }
         });
       },
+      "isMenuPresent": function () {
+        return $("." + idMenu).length.length > 0

Review Comment:
   I would expect it to be undefined, unless I'm missing something...



##########
website/www/site/assets/js/fix-menu.js:
##########
@@ -64,9 +64,14 @@ $(document).ready(function() {
           }
         });
       },
+      "isMenuPresent": function () {
+        return $("." + idMenu).length.length > 0

Review Comment:
   `.length.length` - Is this intended?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org