You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Brian Cho <ch...@gmail.com> on 2015/08/07 17:46:39 UTC
[VOTE] Release Apache REEF 0.12.0-incubating (rc2)
This is to call for a new vote for the source release of Apache REEF
0.12.0-incubating (rc2).
The source tar ball, including signatures, digests, etc can be found at:
https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/
The Git tag is release-0.12.0-incubating-rc2
The Git commit ID is 13a238d1ba4f1ddca06634773090be79dda0f985
Checksums of apache-reef-0.12.0-incubating-rc2.tar.gz:
MD5: 5d74f66220fdb3316f4a50574ef52cd4
SHA:
a5ec246fc5f73427ecb74f4725ce7ac1a8911ee7cf969aa45142b05b4985f385547b9ff47d6752e6c505dbbc98acda762d2fc22f3e2759040e2a7d9a0249398d
Release artifacts are signed with the key. The KEYS file is available here:
https://dist.apache.org/repos/dist/release/incubator/reef/KEYS
Issues Resolved in the release
177 issues were closed/resolved for this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315820&version=12332143
The vote will be open for 72 hours. Please download the release
candidate, check the hashes/signature, build it and test it, and then
please vote:
[ ] +1 Release this package as Apache REEF 0.12.0-incubating
[ ] +0 no opinion
[ ] -1 Do not release this package because ...
Thanks!
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Dongjoon Hyun <do...@apache.org>.
Hi, Brian.
Thank you! I'm really waiting for this. :)
I tested on my Mac/CentOS and it looks good to me.
Here is my +1.
-------
Mac OS X Yosemite: 10.10.4(14E46)
Java(TM) SE Runtime Environment (build 1.7.0_51-b13)
curl -LO
https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/apache-reef-0.12.0-incubating-rc2.tar.gz
curl -LO
https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/apache-reef-0.12.0-incubating-rc2.tar.gz.asc
curl -LO
https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/apache-reef-0.12.0-incubating-rc2.tar.gz.md5
curl -LO
https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/apache-reef-0.12.0-incubating-rc2.tar.gz.sha512.txt
md5 apache-reef-0.12.0-incubating-rc2.tar.gz
shasum -a 512 apache-reef-0.12.0-incubating-rc2.tar.gz
gpg —verify
mvn clean install
-------
CentOS 6.5 (Final)
Java(TM) SE Runtime Environment (build 1.7.0_67-b01)
curl -LO
https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/apache-reef-0.12.0-incubating-rc2.tar.gz
curl -LO
https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/apache-reef-0.12.0-incubating-rc2.tar.gz.asc
curl -LO
https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/apache-reef-0.12.0-incubating-rc2.tar.gz.md5
curl -LO
https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/apache-reef-0.12.0-incubating-rc2.tar.gz.sha512.txt
md5sum apache-reef-0.12.0-incubating-rc2.tar.gz
shasum -a 512 apache-reef-0.12.0-incubating-rc2.tar.gz
gpg --verify apache-reef-0.12.0-incubating-rc2.tar.gz.asc
mvn clean install
------
On Sat, Aug 8, 2015 at 12:46 AM, Brian Cho <ch...@gmail.com> wrote:
> This is to call for a new vote for the source release of Apache REEF
> 0.12.0-incubating (rc2).
>
> The source tar ball, including signatures, digests, etc can be found at:
>
> https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/
>
> The Git tag is release-0.12.0-incubating-rc2
> The Git commit ID is 13a238d1ba4f1ddca06634773090be79dda0f985
>
>
> Checksums of apache-reef-0.12.0-incubating-rc2.tar.gz:
>
> MD5: 5d74f66220fdb3316f4a50574ef52cd4
>
> SHA:
>
> a5ec246fc5f73427ecb74f4725ce7ac1a8911ee7cf969aa45142b05b4985f385547b9ff47d6752e6c505dbbc98acda762d2fc22f3e2759040e2a7d9a0249398d
>
> Release artifacts are signed with the key. The KEYS file is available here:
>
> https://dist.apache.org/repos/dist/release/incubator/reef/KEYS
>
>
>
> Issues Resolved in the release
> 177 issues were closed/resolved for this release:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315820&version=12332143
>
>
>
> The vote will be open for 72 hours. Please download the release
> candidate, check the hashes/signature, build it and test it, and then
> please vote:
>
> [ ] +1 Release this package as Apache REEF 0.12.0-incubating
> [ ] +0 no opinion
> [ ] -1 Do not release this package because ...
>
> Thanks!
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Byung-Gon Chun <bg...@gmail.com>.
I will try Markus's powershell script.
On Sun, Aug 9, 2015 at 1:04 PM, Byung-Gon Chun <bg...@gmail.com> wrote:
> I'm testing the .Net side code.
>
> msbuild under lang/cs has errors (maybe due to my environment setup).
>
> One error log message.
> EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는 네임스페이스
> 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오. [C:\Users\Byung-Gon
> Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evaluator.Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
>
> What's required to run msbuild correctly?
>
>
>
> On Sun, Aug 9, 2015 at 12:12 PM, Markus Weimer <ma...@weimo.de> wrote:
>
>> On 2015-08-08 19:14, Brian Cho wrote:
>> > On another topic, I’ve tested on Linux YARN and Mesos. But, I’d be
>> > happy if someone who is not the release manager does these tests as
>> > well. I don’t believe I have a vote either, so the current tally is
>> > one provisional +0.
>>
>> Why wouldn't you have a vote? If you want to, I think you should be able
>> to vote.
>>
>> Markus
>>
>
>
>
> --
> Byung-Gon Chun
>
--
Byung-Gon Chun
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
Great! Thanks for the thorough tests Julia. I’ll conclude the vote for RC2.
-Brian
On Wed, Aug 12, 2015 at 11:18 AM, Julia Wang (QIUHE) <
Qiuhe.Wang@microsoft.com> wrote:
> I have tested the following:
>
> -Entire .Net testing on Windows
> -Java testing on YARN cluster/HDInsight
> -.Net testing on YARN cluster/HDInsight
> -Verified auto updated NuGet specifications for versions
> -Verified NuGets generated
> -Verified updated build.prop
> -Verified file endings - build.prop file and all nugget specification
> files use LF ending. That is not correct. However, it doesn't impact build
> and tests so far. I am OK to have Jira and follow up it in master branch.
> - Regarding the public key, based on the discussion so far, we might just
> need to update the public key to match the keyfile. Currently, they don’t
> match. I am OK to open a JIRA for it and follow up it in master branch.
>
> +1 for the vote :)
>
> Thanks,
> Julia
>
> -----Original Message-----
> From: Julia Wang (QIUHE) [mailto:Qiuhe.Wang@microsoft.com]
> Sent: Monday, August 10, 2015 11:23 PM
> To: dev@reef.incubator.apache.org
> Subject: RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> The build doesn't need the public key but keyfile.snk only.
>
> The public key is just to make it available for the client.
>
> -----Original Message-----
> From: Brian Cho [mailto:chobrian@gmail.com]
> Sent: Monday, August 10, 2015 10:57 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> On Tue, Aug 11, 2015 at 2:24 PM, Julia Wang (QIUHE) <
> Qiuhe.Wang@microsoft.com> wrote:
>
> > We had some discussions about a few weeks ago. Here is the idea:
> >
> > For Nuget, all the dlls must be signed with the private/public key
> > pair which is in the lang/cs/keyfile.snk. This key file used to
> > generate NuGet for a releases should be maintained per release
> > manager. The one checked in to Git is for daily build/tests.
> >
> > The corresponding lang/cs/publickey.snk is for the clients. We check
> > in it to Git so that clients can pick it up from there. This file
> > should also be published to web site, ...
> >
> >
> Thanks for the references. :)
>
> The need for an updated `publickey.snk` in the git repo (and source
> release) still confuses me though. (a) Does it have a role when a user is
> building from source? (b) Or is it a means to make the public key available?
>
> It doesn’t look like (a). (I’m no expert though.) I’ve tried building the
> dlls for local use after deleting `publickey.snk`, and it seems to work
> fine.
>
> If (b), the KEYS file on the website seems to be enough. If I am a NuGet
> user who just wants to verify the NuGet, the source release of the project
> is not where I’d look for the public key.
>
> Thanks,
> Brian
>
>
>
> > We have
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> > s.apache.org%2fjira%2fbrowse%2fREEF-465&data=01%7c01%7cQiuhe.Wang%40mi
> > crosoft.com%7cfe535fffb8424a6fc11208d2a211a4b6%7c72f988bf86f141af91ab2
> > d7cd011db47%7c1&sdata=DgkMR%2biTbKkrSJbJ2wwCQ3Dk2uPVpjjimVs6K%2ffv9a8%
> > 3d And
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> > s.apache.org%2fjira%2fbrowse%2fREEF-458&data=01%7c01%7cQiuhe.Wang%40mi
> > crosoft.com%7cfe535fffb8424a6fc11208d2a211a4b6%7c72f988bf86f141af91ab2
> > d7cd011db47%7c1&sdata=ZUtlNWiqF%2bQ65khJgTdhCjETmKtnqliYz3QiHEU%2bKeQ%
> > 3d for the issue
> >
> > Thanks,
> > Julia
> >
> >
> > -----Original Message-----
> > From: Brian Cho [mailto:chobrian@gmail.com]
> > Sent: Monday, August 10, 2015 9:51 PM
> > To: dev@reef.incubator.apache.org
> > Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >
> > Thanks Julia,
> >
> > I don’t really know how the public key is related to the client. Can
> > you help me with a brief explanation, or some pointers (e.g., JIRAs)?
> >
> > Do we provide keyfiles for users who will be compiling from source?
> > Without knowing much detail, I thought they would want to use their
> > own keyfiles instead.
> >
> > -Brian
> >
> >
> >
> >
> >
> > On Tue, Aug 11, 2015 at 12:36 PM, Julia Wang (QIUHE) <
> > Qiuhe.Wang@microsoft.com> wrote:
> >
> > > Yeah, the private key file is for us to create dlls when creating
> > > NuGet for .Net binaries. However, public key file will be part of
> > > the source code for client, right?
> > >
> > > Thanks,
> > > Julia
> > >
> > > -----Original Message-----
> > > From: Brian Cho [mailto:chobrian@gmail.com]
> > > Sent: Monday, August 10, 2015 8:22 PM
> > > To: dev@reef.incubator.apache.org
> > > Subject: RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> > >
> > > Hi Julia,
> > > I haven't done that yet. This is only related to creating NuGet
> > > binaries, right?
> > > I might do the NuGet related stuff on a separate branch similar to
> maven.
> > > But first things first, I want to get the source release done.
> > > Thanks,Brian
> > >
> > >
> > >
> > >
> > >
> > >
> > > On Mon, Aug 10, 2015 at 8:15 PM -0700, "Julia Wang (QIUHE)" <
> > > Qiuhe.Wang@microsoft.com> wrote:
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > Hi Brain,
> > >
> > > Did you update publickey file generated from your private key? Two
> > > files from master branch and apache-reef-0.12.0-incubating look the
> same.
> > >
> > > If you pass me your private key pair, I can verify it.
> > >
> > > Thanks,
> > > Julia
> > >
> > > -----Original Message-----
> > > From: Markus Weimer [mailto:markus@weimo.de]
> > > Sent: Monday, August 10, 2015 7:11 PM
> > > To: dev@reef.incubator.apache.org
> > > Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> > >
> > > On 2015-08-10 18:49, Brian Cho wrote:
> > > > That’s a valid point. Let's keep the voting open for another 24
> hours.
> > > > Hopefully we can get a few more tests and votes during that time
> > > > as well :)
> > >
> > > Agreed. I did test the Java side on HDInsight and a local Windows
> > > YARN cluster successfully, BTW.
> > >
> > > Markus
> > >
> >
>
RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
I have tested the following:
-Entire .Net testing on Windows
-Java testing on YARN cluster/HDInsight
-.Net testing on YARN cluster/HDInsight
-Verified auto updated NuGet specifications for versions
-Verified NuGets generated
-Verified updated build.prop
-Verified file endings - build.prop file and all nugget specification files use LF ending. That is not correct. However, it doesn't impact build and tests so far. I am OK to have Jira and follow up it in master branch.
- Regarding the public key, based on the discussion so far, we might just need to update the public key to match the keyfile. Currently, they don’t match. I am OK to open a JIRA for it and follow up it in master branch.
+1 for the vote :)
Thanks,
Julia
-----Original Message-----
From: Julia Wang (QIUHE) [mailto:Qiuhe.Wang@microsoft.com]
Sent: Monday, August 10, 2015 11:23 PM
To: dev@reef.incubator.apache.org
Subject: RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
The build doesn't need the public key but keyfile.snk only.
The public key is just to make it available for the client.
-----Original Message-----
From: Brian Cho [mailto:chobrian@gmail.com]
Sent: Monday, August 10, 2015 10:57 PM
To: dev@reef.incubator.apache.org
Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
On Tue, Aug 11, 2015 at 2:24 PM, Julia Wang (QIUHE) < Qiuhe.Wang@microsoft.com> wrote:
> We had some discussions about a few weeks ago. Here is the idea:
>
> For Nuget, all the dlls must be signed with the private/public key
> pair which is in the lang/cs/keyfile.snk. This key file used to
> generate NuGet for a releases should be maintained per release
> manager. The one checked in to Git is for daily build/tests.
>
> The corresponding lang/cs/publickey.snk is for the clients. We check
> in it to Git so that clients can pick it up from there. This file
> should also be published to web site, ...
>
>
Thanks for the references. :)
The need for an updated `publickey.snk` in the git repo (and source
release) still confuses me though. (a) Does it have a role when a user is building from source? (b) Or is it a means to make the public key available?
It doesn’t look like (a). (I’m no expert though.) I’ve tried building the dlls for local use after deleting `publickey.snk`, and it seems to work fine.
If (b), the KEYS file on the website seems to be enough. If I am a NuGet user who just wants to verify the NuGet, the source release of the project is not where I’d look for the public key.
Thanks,
Brian
> We have
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fREEF-465&data=01%7c01%7cQiuhe.Wang%40mi
> crosoft.com%7cfe535fffb8424a6fc11208d2a211a4b6%7c72f988bf86f141af91ab2
> d7cd011db47%7c1&sdata=DgkMR%2biTbKkrSJbJ2wwCQ3Dk2uPVpjjimVs6K%2ffv9a8%
> 3d And
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fREEF-458&data=01%7c01%7cQiuhe.Wang%40mi
> crosoft.com%7cfe535fffb8424a6fc11208d2a211a4b6%7c72f988bf86f141af91ab2
> d7cd011db47%7c1&sdata=ZUtlNWiqF%2bQ65khJgTdhCjETmKtnqliYz3QiHEU%2bKeQ%
> 3d for the issue
>
> Thanks,
> Julia
>
>
> -----Original Message-----
> From: Brian Cho [mailto:chobrian@gmail.com]
> Sent: Monday, August 10, 2015 9:51 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> Thanks Julia,
>
> I don’t really know how the public key is related to the client. Can
> you help me with a brief explanation, or some pointers (e.g., JIRAs)?
>
> Do we provide keyfiles for users who will be compiling from source?
> Without knowing much detail, I thought they would want to use their
> own keyfiles instead.
>
> -Brian
>
>
>
>
>
> On Tue, Aug 11, 2015 at 12:36 PM, Julia Wang (QIUHE) <
> Qiuhe.Wang@microsoft.com> wrote:
>
> > Yeah, the private key file is for us to create dlls when creating
> > NuGet for .Net binaries. However, public key file will be part of
> > the source code for client, right?
> >
> > Thanks,
> > Julia
> >
> > -----Original Message-----
> > From: Brian Cho [mailto:chobrian@gmail.com]
> > Sent: Monday, August 10, 2015 8:22 PM
> > To: dev@reef.incubator.apache.org
> > Subject: RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >
> > Hi Julia,
> > I haven't done that yet. This is only related to creating NuGet
> > binaries, right?
> > I might do the NuGet related stuff on a separate branch similar to maven.
> > But first things first, I want to get the source release done.
> > Thanks,Brian
> >
> >
> >
> >
> >
> >
> > On Mon, Aug 10, 2015 at 8:15 PM -0700, "Julia Wang (QIUHE)" <
> > Qiuhe.Wang@microsoft.com> wrote:
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > Hi Brain,
> >
> > Did you update publickey file generated from your private key? Two
> > files from master branch and apache-reef-0.12.0-incubating look the same.
> >
> > If you pass me your private key pair, I can verify it.
> >
> > Thanks,
> > Julia
> >
> > -----Original Message-----
> > From: Markus Weimer [mailto:markus@weimo.de]
> > Sent: Monday, August 10, 2015 7:11 PM
> > To: dev@reef.incubator.apache.org
> > Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >
> > On 2015-08-10 18:49, Brian Cho wrote:
> > > That’s a valid point. Let's keep the voting open for another 24 hours.
> > > Hopefully we can get a few more tests and votes during that time
> > > as well :)
> >
> > Agreed. I did test the Java side on HDInsight and a local Windows
> > YARN cluster successfully, BTW.
> >
> > Markus
> >
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Byung-Gon Chun <bg...@gmail.com>.
I'm upgrading my vote to full +1 since we have .NET testing results.
Brian, big thanks for preparing for this release!
On Tue, Aug 11, 2015 at 3:22 PM, Julia Wang (QIUHE) <
Qiuhe.Wang@microsoft.com> wrote:
> The build doesn't need the public key but keyfile.snk only.
>
> The public key is just to make it available for the client.
>
> -----Original Message-----
> From: Brian Cho [mailto:chobrian@gmail.com]
> Sent: Monday, August 10, 2015 10:57 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> On Tue, Aug 11, 2015 at 2:24 PM, Julia Wang (QIUHE) <
> Qiuhe.Wang@microsoft.com> wrote:
>
> > We had some discussions about a few weeks ago. Here is the idea:
> >
> > For Nuget, all the dlls must be signed with the private/public key
> > pair which is in the lang/cs/keyfile.snk. This key file used to
> > generate NuGet for a releases should be maintained per release
> > manager. The one checked in to Git is for daily build/tests.
> >
> > The corresponding lang/cs/publickey.snk is for the clients. We check
> > in it to Git so that clients can pick it up from there. This file
> > should also be published to web site, ...
> >
> >
> Thanks for the references. :)
>
> The need for an updated `publickey.snk` in the git repo (and source
> release) still confuses me though. (a) Does it have a role when a user is
> building from source? (b) Or is it a means to make the public key available?
>
> It doesn’t look like (a). (I’m no expert though.) I’ve tried building the
> dlls for local use after deleting `publickey.snk`, and it seems to work
> fine.
>
> If (b), the KEYS file on the website seems to be enough. If I am a NuGet
> user who just wants to verify the NuGet, the source release of the project
> is not where I’d look for the public key.
>
> Thanks,
> Brian
>
>
>
> > We have
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> > s.apache.org%2fjira%2fbrowse%2fREEF-465&data=01%7c01%7cQiuhe.Wang%40mi
> > crosoft.com%7cfe535fffb8424a6fc11208d2a211a4b6%7c72f988bf86f141af91ab2
> > d7cd011db47%7c1&sdata=DgkMR%2biTbKkrSJbJ2wwCQ3Dk2uPVpjjimVs6K%2ffv9a8%
> > 3d And
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> > s.apache.org%2fjira%2fbrowse%2fREEF-458&data=01%7c01%7cQiuhe.Wang%40mi
> > crosoft.com%7cfe535fffb8424a6fc11208d2a211a4b6%7c72f988bf86f141af91ab2
> > d7cd011db47%7c1&sdata=ZUtlNWiqF%2bQ65khJgTdhCjETmKtnqliYz3QiHEU%2bKeQ%
> > 3d for the issue
> >
> > Thanks,
> > Julia
> >
> >
> > -----Original Message-----
> > From: Brian Cho [mailto:chobrian@gmail.com]
> > Sent: Monday, August 10, 2015 9:51 PM
> > To: dev@reef.incubator.apache.org
> > Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >
> > Thanks Julia,
> >
> > I don’t really know how the public key is related to the client. Can
> > you help me with a brief explanation, or some pointers (e.g., JIRAs)?
> >
> > Do we provide keyfiles for users who will be compiling from source?
> > Without knowing much detail, I thought they would want to use their
> > own keyfiles instead.
> >
> > -Brian
> >
> >
> >
> >
> >
> > On Tue, Aug 11, 2015 at 12:36 PM, Julia Wang (QIUHE) <
> > Qiuhe.Wang@microsoft.com> wrote:
> >
> > > Yeah, the private key file is for us to create dlls when creating
> > > NuGet for .Net binaries. However, public key file will be part of
> > > the source code for client, right?
> > >
> > > Thanks,
> > > Julia
> > >
> > > -----Original Message-----
> > > From: Brian Cho [mailto:chobrian@gmail.com]
> > > Sent: Monday, August 10, 2015 8:22 PM
> > > To: dev@reef.incubator.apache.org
> > > Subject: RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> > >
> > > Hi Julia,
> > > I haven't done that yet. This is only related to creating NuGet
> > > binaries, right?
> > > I might do the NuGet related stuff on a separate branch similar to
> maven.
> > > But first things first, I want to get the source release done.
> > > Thanks,Brian
> > >
> > >
> > >
> > >
> > >
> > >
> > > On Mon, Aug 10, 2015 at 8:15 PM -0700, "Julia Wang (QIUHE)" <
> > > Qiuhe.Wang@microsoft.com> wrote:
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > Hi Brain,
> > >
> > > Did you update publickey file generated from your private key? Two
> > > files from master branch and apache-reef-0.12.0-incubating look the
> same.
> > >
> > > If you pass me your private key pair, I can verify it.
> > >
> > > Thanks,
> > > Julia
> > >
> > > -----Original Message-----
> > > From: Markus Weimer [mailto:markus@weimo.de]
> > > Sent: Monday, August 10, 2015 7:11 PM
> > > To: dev@reef.incubator.apache.org
> > > Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> > >
> > > On 2015-08-10 18:49, Brian Cho wrote:
> > > > That’s a valid point. Let's keep the voting open for another 24
> hours.
> > > > Hopefully we can get a few more tests and votes during that time
> > > > as well :)
> > >
> > > Agreed. I did test the Java side on HDInsight and a local Windows
> > > YARN cluster successfully, BTW.
> > >
> > > Markus
> > >
> >
>
--
Byung-Gon Chun
RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
The build doesn't need the public key but keyfile.snk only.
The public key is just to make it available for the client.
-----Original Message-----
From: Brian Cho [mailto:chobrian@gmail.com]
Sent: Monday, August 10, 2015 10:57 PM
To: dev@reef.incubator.apache.org
Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
On Tue, Aug 11, 2015 at 2:24 PM, Julia Wang (QIUHE) < Qiuhe.Wang@microsoft.com> wrote:
> We had some discussions about a few weeks ago. Here is the idea:
>
> For Nuget, all the dlls must be signed with the private/public key
> pair which is in the lang/cs/keyfile.snk. This key file used to
> generate NuGet for a releases should be maintained per release
> manager. The one checked in to Git is for daily build/tests.
>
> The corresponding lang/cs/publickey.snk is for the clients. We check
> in it to Git so that clients can pick it up from there. This file
> should also be published to web site, ...
>
>
Thanks for the references. :)
The need for an updated `publickey.snk` in the git repo (and source
release) still confuses me though. (a) Does it have a role when a user is building from source? (b) Or is it a means to make the public key available?
It doesn’t look like (a). (I’m no expert though.) I’ve tried building the dlls for local use after deleting `publickey.snk`, and it seems to work fine.
If (b), the KEYS file on the website seems to be enough. If I am a NuGet user who just wants to verify the NuGet, the source release of the project is not where I’d look for the public key.
Thanks,
Brian
> We have
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fREEF-465&data=01%7c01%7cQiuhe.Wang%40mi
> crosoft.com%7cfe535fffb8424a6fc11208d2a211a4b6%7c72f988bf86f141af91ab2
> d7cd011db47%7c1&sdata=DgkMR%2biTbKkrSJbJ2wwCQ3Dk2uPVpjjimVs6K%2ffv9a8%
> 3d And
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fREEF-458&data=01%7c01%7cQiuhe.Wang%40mi
> crosoft.com%7cfe535fffb8424a6fc11208d2a211a4b6%7c72f988bf86f141af91ab2
> d7cd011db47%7c1&sdata=ZUtlNWiqF%2bQ65khJgTdhCjETmKtnqliYz3QiHEU%2bKeQ%
> 3d for the issue
>
> Thanks,
> Julia
>
>
> -----Original Message-----
> From: Brian Cho [mailto:chobrian@gmail.com]
> Sent: Monday, August 10, 2015 9:51 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> Thanks Julia,
>
> I don’t really know how the public key is related to the client. Can
> you help me with a brief explanation, or some pointers (e.g., JIRAs)?
>
> Do we provide keyfiles for users who will be compiling from source?
> Without knowing much detail, I thought they would want to use their
> own keyfiles instead.
>
> -Brian
>
>
>
>
>
> On Tue, Aug 11, 2015 at 12:36 PM, Julia Wang (QIUHE) <
> Qiuhe.Wang@microsoft.com> wrote:
>
> > Yeah, the private key file is for us to create dlls when creating
> > NuGet for .Net binaries. However, public key file will be part of
> > the source code for client, right?
> >
> > Thanks,
> > Julia
> >
> > -----Original Message-----
> > From: Brian Cho [mailto:chobrian@gmail.com]
> > Sent: Monday, August 10, 2015 8:22 PM
> > To: dev@reef.incubator.apache.org
> > Subject: RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >
> > Hi Julia,
> > I haven't done that yet. This is only related to creating NuGet
> > binaries, right?
> > I might do the NuGet related stuff on a separate branch similar to maven.
> > But first things first, I want to get the source release done.
> > Thanks,Brian
> >
> >
> >
> >
> >
> >
> > On Mon, Aug 10, 2015 at 8:15 PM -0700, "Julia Wang (QIUHE)" <
> > Qiuhe.Wang@microsoft.com> wrote:
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > Hi Brain,
> >
> > Did you update publickey file generated from your private key? Two
> > files from master branch and apache-reef-0.12.0-incubating look the same.
> >
> > If you pass me your private key pair, I can verify it.
> >
> > Thanks,
> > Julia
> >
> > -----Original Message-----
> > From: Markus Weimer [mailto:markus@weimo.de]
> > Sent: Monday, August 10, 2015 7:11 PM
> > To: dev@reef.incubator.apache.org
> > Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >
> > On 2015-08-10 18:49, Brian Cho wrote:
> > > That’s a valid point. Let's keep the voting open for another 24 hours.
> > > Hopefully we can get a few more tests and votes during that time
> > > as well :)
> >
> > Agreed. I did test the Java side on HDInsight and a local Windows
> > YARN cluster successfully, BTW.
> >
> > Markus
> >
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
On Tue, Aug 11, 2015 at 2:24 PM, Julia Wang (QIUHE) <
Qiuhe.Wang@microsoft.com> wrote:
> We had some discussions about a few weeks ago. Here is the idea:
>
> For Nuget, all the dlls must be signed with the private/public key pair
> which is in the lang/cs/keyfile.snk. This key file used to generate NuGet
> for a releases should be maintained per release manager. The one checked in
> to Git is for daily build/tests.
>
> The corresponding lang/cs/publickey.snk is for the clients. We check in it
> to Git so that clients can pick it up from there. This file should also be
> published to web site, ...
>
>
Thanks for the references. :)
The need for an updated `publickey.snk` in the git repo (and source
release) still confuses me though. (a) Does it have a role when a user is
building from source? (b) Or is it a means to make the public key available?
It doesn’t look like (a). (I’m no expert though.) I’ve tried building the
dlls for local use after deleting `publickey.snk`, and it seems to work
fine.
If (b), the KEYS file on the website seems to be enough. If I am a NuGet
user who just wants to verify the NuGet, the source release of the project
is not where I’d look for the public key.
Thanks,
Brian
> We have https://issues.apache.org/jira/browse/REEF-465
> And https://issues.apache.org/jira/browse/REEF-458 for the issue
>
> Thanks,
> Julia
>
>
> -----Original Message-----
> From: Brian Cho [mailto:chobrian@gmail.com]
> Sent: Monday, August 10, 2015 9:51 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> Thanks Julia,
>
> I don’t really know how the public key is related to the client. Can you
> help me with a brief explanation, or some pointers (e.g., JIRAs)?
>
> Do we provide keyfiles for users who will be compiling from source?
> Without knowing much detail, I thought they would want to use their own
> keyfiles instead.
>
> -Brian
>
>
>
>
>
> On Tue, Aug 11, 2015 at 12:36 PM, Julia Wang (QIUHE) <
> Qiuhe.Wang@microsoft.com> wrote:
>
> > Yeah, the private key file is for us to create dlls when creating
> > NuGet for .Net binaries. However, public key file will be part of the
> > source code for client, right?
> >
> > Thanks,
> > Julia
> >
> > -----Original Message-----
> > From: Brian Cho [mailto:chobrian@gmail.com]
> > Sent: Monday, August 10, 2015 8:22 PM
> > To: dev@reef.incubator.apache.org
> > Subject: RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >
> > Hi Julia,
> > I haven't done that yet. This is only related to creating NuGet
> > binaries, right?
> > I might do the NuGet related stuff on a separate branch similar to maven.
> > But first things first, I want to get the source release done.
> > Thanks,Brian
> >
> >
> >
> >
> >
> >
> > On Mon, Aug 10, 2015 at 8:15 PM -0700, "Julia Wang (QIUHE)" <
> > Qiuhe.Wang@microsoft.com> wrote:
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > Hi Brain,
> >
> > Did you update publickey file generated from your private key? Two
> > files from master branch and apache-reef-0.12.0-incubating look the same.
> >
> > If you pass me your private key pair, I can verify it.
> >
> > Thanks,
> > Julia
> >
> > -----Original Message-----
> > From: Markus Weimer [mailto:markus@weimo.de]
> > Sent: Monday, August 10, 2015 7:11 PM
> > To: dev@reef.incubator.apache.org
> > Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >
> > On 2015-08-10 18:49, Brian Cho wrote:
> > > That’s a valid point. Let's keep the voting open for another 24 hours.
> > > Hopefully we can get a few more tests and votes during that time as
> > > well :)
> >
> > Agreed. I did test the Java side on HDInsight and a local Windows YARN
> > cluster successfully, BTW.
> >
> > Markus
> >
>
RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
We had some discussions about a few weeks ago. Here is the idea:
For Nuget, all the dlls must be signed with the private/public key pair which is in the lang/cs/keyfile.snk. This key file used to generate NuGet for a releases should be maintained per release manager. The one checked in to Git is for daily build/tests.
The corresponding lang/cs/publickey.snk is for the clients. We check in it to Git so that clients can pick it up from there. This file should also be published to web site, ...
We have https://issues.apache.org/jira/browse/REEF-465
And https://issues.apache.org/jira/browse/REEF-458 for the issue
Thanks,
Julia
-----Original Message-----
From: Brian Cho [mailto:chobrian@gmail.com]
Sent: Monday, August 10, 2015 9:51 PM
To: dev@reef.incubator.apache.org
Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Thanks Julia,
I don’t really know how the public key is related to the client. Can you help me with a brief explanation, or some pointers (e.g., JIRAs)?
Do we provide keyfiles for users who will be compiling from source? Without knowing much detail, I thought they would want to use their own keyfiles instead.
-Brian
On Tue, Aug 11, 2015 at 12:36 PM, Julia Wang (QIUHE) < Qiuhe.Wang@microsoft.com> wrote:
> Yeah, the private key file is for us to create dlls when creating
> NuGet for .Net binaries. However, public key file will be part of the
> source code for client, right?
>
> Thanks,
> Julia
>
> -----Original Message-----
> From: Brian Cho [mailto:chobrian@gmail.com]
> Sent: Monday, August 10, 2015 8:22 PM
> To: dev@reef.incubator.apache.org
> Subject: RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> Hi Julia,
> I haven't done that yet. This is only related to creating NuGet
> binaries, right?
> I might do the NuGet related stuff on a separate branch similar to maven.
> But first things first, I want to get the source release done.
> Thanks,Brian
>
>
>
>
>
>
> On Mon, Aug 10, 2015 at 8:15 PM -0700, "Julia Wang (QIUHE)" <
> Qiuhe.Wang@microsoft.com> wrote:
>
>
>
>
>
>
>
>
>
>
> Hi Brain,
>
> Did you update publickey file generated from your private key? Two
> files from master branch and apache-reef-0.12.0-incubating look the same.
>
> If you pass me your private key pair, I can verify it.
>
> Thanks,
> Julia
>
> -----Original Message-----
> From: Markus Weimer [mailto:markus@weimo.de]
> Sent: Monday, August 10, 2015 7:11 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> On 2015-08-10 18:49, Brian Cho wrote:
> > That’s a valid point. Let's keep the voting open for another 24 hours.
> > Hopefully we can get a few more tests and votes during that time as
> > well :)
>
> Agreed. I did test the Java side on HDInsight and a local Windows YARN
> cluster successfully, BTW.
>
> Markus
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
Thanks Julia,
I don’t really know how the public key is related to the client. Can you
help me with a brief explanation, or some pointers (e.g., JIRAs)?
Do we provide keyfiles for users who will be compiling from source? Without
knowing much detail, I thought they would want to use their own keyfiles
instead.
-Brian
On Tue, Aug 11, 2015 at 12:36 PM, Julia Wang (QIUHE) <
Qiuhe.Wang@microsoft.com> wrote:
> Yeah, the private key file is for us to create dlls when creating NuGet
> for .Net binaries. However, public key file will be part of the source code
> for client, right?
>
> Thanks,
> Julia
>
> -----Original Message-----
> From: Brian Cho [mailto:chobrian@gmail.com]
> Sent: Monday, August 10, 2015 8:22 PM
> To: dev@reef.incubator.apache.org
> Subject: RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> Hi Julia,
> I haven't done that yet. This is only related to creating NuGet binaries,
> right?
> I might do the NuGet related stuff on a separate branch similar to maven.
> But first things first, I want to get the source release done. Thanks,Brian
>
>
>
>
>
>
> On Mon, Aug 10, 2015 at 8:15 PM -0700, "Julia Wang (QIUHE)" <
> Qiuhe.Wang@microsoft.com> wrote:
>
>
>
>
>
>
>
>
>
>
> Hi Brain,
>
> Did you update publickey file generated from your private key? Two files
> from master branch and apache-reef-0.12.0-incubating look the same.
>
> If you pass me your private key pair, I can verify it.
>
> Thanks,
> Julia
>
> -----Original Message-----
> From: Markus Weimer [mailto:markus@weimo.de]
> Sent: Monday, August 10, 2015 7:11 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> On 2015-08-10 18:49, Brian Cho wrote:
> > That’s a valid point. Let's keep the voting open for another 24 hours.
> > Hopefully we can get a few more tests and votes during that time as
> > well :)
>
> Agreed. I did test the Java side on HDInsight and a local Windows YARN
> cluster successfully, BTW.
>
> Markus
>
RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
Yeah, the private key file is for us to create dlls when creating NuGet for .Net binaries. However, public key file will be part of the source code for client, right?
Thanks,
Julia
-----Original Message-----
From: Brian Cho [mailto:chobrian@gmail.com]
Sent: Monday, August 10, 2015 8:22 PM
To: dev@reef.incubator.apache.org
Subject: RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Hi Julia,
I haven't done that yet. This is only related to creating NuGet binaries, right?
I might do the NuGet related stuff on a separate branch similar to maven. But first things first, I want to get the source release done. Thanks,Brian
On Mon, Aug 10, 2015 at 8:15 PM -0700, "Julia Wang (QIUHE)" <Qi...@microsoft.com> wrote:
Hi Brain,
Did you update publickey file generated from your private key? Two files from master branch and apache-reef-0.12.0-incubating look the same.
If you pass me your private key pair, I can verify it.
Thanks,
Julia
-----Original Message-----
From: Markus Weimer [mailto:markus@weimo.de]
Sent: Monday, August 10, 2015 7:11 PM
To: dev@reef.incubator.apache.org
Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
On 2015-08-10 18:49, Brian Cho wrote:
> That’s a valid point. Let's keep the voting open for another 24 hours.
> Hopefully we can get a few more tests and votes during that time as
> well :)
Agreed. I did test the Java side on HDInsight and a local Windows YARN cluster successfully, BTW.
Markus
RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
Hi Julia,
I haven't done that yet. This is only related to creating NuGet binaries, right?
I might do the NuGet related stuff on a separate branch similar to maven. But first things first, I want to get the source release done.
Thanks,Brian
On Mon, Aug 10, 2015 at 8:15 PM -0700, "Julia Wang (QIUHE)" <Qi...@microsoft.com> wrote:
Hi Brain,
Did you update publickey file generated from your private key? Two files from master branch and apache-reef-0.12.0-incubating look the same.
If you pass me your private key pair, I can verify it.
Thanks,
Julia
-----Original Message-----
From: Markus Weimer [mailto:markus@weimo.de]
Sent: Monday, August 10, 2015 7:11 PM
To: dev@reef.incubator.apache.org
Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
On 2015-08-10 18:49, Brian Cho wrote:
> That’s a valid point. Let's keep the voting open for another 24 hours.
> Hopefully we can get a few more tests and votes during that time as
> well :)
Agreed. I did test the Java side on HDInsight and a local Windows YARN cluster successfully, BTW.
Markus
RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
Hi Brain,
Did you update publickey file generated from your private key? Two files from master branch and apache-reef-0.12.0-incubating look the same.
If you pass me your private key pair, I can verify it.
Thanks,
Julia
-----Original Message-----
From: Markus Weimer [mailto:markus@weimo.de]
Sent: Monday, August 10, 2015 7:11 PM
To: dev@reef.incubator.apache.org
Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
On 2015-08-10 18:49, Brian Cho wrote:
> That’s a valid point. Let's keep the voting open for another 24 hours.
> Hopefully we can get a few more tests and votes during that time as
> well :)
Agreed. I did test the Java side on HDInsight and a local Windows YARN cluster successfully, BTW.
Markus
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-10 18:49, Brian Cho wrote:
> That’s a valid point. Let's keep the voting open for another 24
> hours. Hopefully we can get a few more tests and votes during that
> time as well :)
Agreed. I did test the Java side on HDInsight and a local Windows YARN
cluster successfully, BTW.
Markus
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
Thanks Julia,
That’s a valid point. Let's keep the voting open for another 24 hours.
Hopefully we can get a few more tests and votes during that time as well :)
-Brian
On Tue, Aug 11, 2015 at 10:45 AM, Julia Wang (QIUHE) <
Qiuhe.Wang@microsoft.com> wrote:
> Yes, I will do a testing on Yarn cluster.
>
> It is better to keep it open for at least another 24 hours as the vote
> crossed a weekend.
>
> Thanks,
> Julia
>
> -----Original Message-----
> From: Brian Cho [mailto:chobrian@gmail.com]
> Sent: Monday, August 10, 2015 6:42 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> We currently have 3 “full” +1’s:
> - Dongjoon Hyun
> - Yunseong Lee
> - Markus Weimer
>
> We could go ahead and call it a wrap. But, as Markus mentioned it would be
> good to have some HDInsight testing. I’ll keep this open for another 24
> hours or until HDInsight test results come in. Julia, are the YARN tests
> you’re planning to do on HDInsight?
>
> Thanks,
> Brian
>
> On Tue, Aug 11, 2015 at 3:05 AM, Julia Wang (QIUHE) <
> Qiuhe.Wang@microsoft.com> wrote:
>
> > I have tested on .Net locally. Need to test on YARN before voting.
> >
> > -----Original Message-----
> > From: Markus Weimer [mailto:markus@weimo.de]
> > Sent: Monday, August 10, 2015 8:46 AM
> > To: dev@reef.incubator.apache.org
> > Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >
> > I believe we now have three +1s, right? Someone should test on
> > HDInsight and it would be good to have some more people test the C#
> > code. For now, that has only been tested by me.
> >
> > Markus
> >
> >
> > On 2015-08-10 05:55, Yunseong Lee wrote:
> > > Hi,
> > >
> > > +1
> > >
> > > I've checked:
> > > - The signature and digests match.
> > > - Build completes on the OSX and Linux local machine.
> > > - Tests on Linux YARN and Mesos passed.
> > >
> > > Thanks for the great work, Brian.
> > >
> > > Regards,
> > > Yunseong
> > >
> > > On Mon, Aug 10, 2015 at 3:10 PM, Brian Cho <ch...@gmail.com> wrote:
> > >
> > >> Hi Julia,
> > >>
> > >> I don’t think that’s true. The root .gitattributes [1] doesn’t
> > >> match patterns which include `build.props` or `*.nuspec`. Thus, on
> > >> *nix systems they are checked out as LF.
> > >>
> > >> I’ve started a JIRA and PR dealing with this [2].
> > >>
> > >> [1]
> > >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgi
> > >> th
> > >> ub.com%2fapache%2fincubator-reef%2fblob%2fmaster%2f.gitattributes&d
> > >> at
> > >> a=01%7c01%7cQiuhe.Wang%40microsoft.com%7c9e7de2fa84be4ca30e5008d2a1
> > >> 9a
> > >> cc01%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=6e3GV5YsH0byrzxsA
> > >> hb
> > >> er6ySuZfnRpwXS2CHQibpLM4%3d [2]
> > >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
> > >> su
> > >> es.apache.org%2fjira%2fbrowse%2fREEF-579&data=01%7c01%7cQiuhe.Wang%
> > >> 40
> > >> microsoft.com%7c9e7de2fa84be4ca30e5008d2a19acc01%7c72f988bf86f141af
> > >> 91
> > >> ab2d7cd011db47%7c1&sdata=JscwnxkCDSIRtRpq4ksLuZZHaLiIXi%2bZVkqCxLMF
> > >> sw
> > >> 0%3d
> > >>
> > >> Thanks,
> > >> Brian
> > >>
> > >> On Mon, Aug 10, 2015 at 3:05 PM, Julia Wang (QIUHE) <
> > >> Qiuhe.Wang@microsoft.com> wrote:
> > >>
> > >>> .gitattributes does cover the following two files. I guess they
> > >>> got changed when the files are updated as both files are modified
> > >>> by
> > script.
> > >>>
> > >>> Thanks,
> > >>> Julia
> > >>>
> > >>> -----Original Message-----
> > >>> From: Brian Cho [mailto:chobrian@gmail.com]
> > >>> Sent: Sunday, August 9, 2015 5:00 AM
> > >>> To: dev@reef.incubator.apache.org
> > >>> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> > >>>
> > >>> Thanks Julia,
> > >>>
> > >>> If I remember correctly, we use .gitattributes to do this. This
> > >>> would probably be the correct way to get the correct line endings
> > >>> while keeping the files identical to the git repo. Are the files
> > >>> you mentioned covered
> > >> by
> > >>> the following?
> > >>>
> > >>> build.prop
> > >>> *.nuspec
> > >>>
> > >>> Thanks,
> > >>> Brian
> > >>>
> > >>>
> > >>>
> > >>> On Sun, Aug 9, 2015 at 2:25 PM, Julia Wang (QIUHE) <
> > >>> Qiuhe.Wang@microsoft.com
> > >>>> wrote:
> > >>>
> > >>>> The line ending for all nuspec firls and build.prop file is LF.
> > >>>> All .Net file should remain as CRLF.
> > >>>>
> > >>>> -----Original Message-----
> > >>>> From: Markus Weimer [mailto:markus@weimo.de]
> > >>>> Sent: Saturday, August 8, 2015 9:45 PM
> > >>>> To: dev@reef.incubator.apache.org
> > >>>> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> > >>>>
> > >>>> On 2015-08-08 21:04, Byung-Gon Chun wrote:
> > >>>>> I'm testing the .Net side code.
> > >>>>>
> > >>>>> msbuild under lang/cs has errors (maybe due to my environment
> setup).
> > >>>>>
> > >>>>> One error log message.
> > >>>>> EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식
> > >>>>> 또는 네임스페이스 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오.
> > >>>>> [C:\Users\Byung-Gon
> > >>>>> Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Eva
> > >>>>> lu at or .Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
> > >>>>>
> > >>>>> What's required to run msbuild correctly?
> > >>>>
> > >>>> This looks like a setup issue. You need to either run `msbuild`
> > >>>> from the 'Developer Command Line' or setup PowerShell using the
> > >>>> instructions I added to the Wiki.
> > >>>>
> > >>>> Markus
> > >>>>
> > >>>>
> > >>>
> > >>
> > >
> >
>
RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
Yes, I will do a testing on Yarn cluster.
It is better to keep it open for at least another 24 hours as the vote crossed a weekend.
Thanks,
Julia
-----Original Message-----
From: Brian Cho [mailto:chobrian@gmail.com]
Sent: Monday, August 10, 2015 6:42 PM
To: dev@reef.incubator.apache.org
Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
We currently have 3 “full” +1’s:
- Dongjoon Hyun
- Yunseong Lee
- Markus Weimer
We could go ahead and call it a wrap. But, as Markus mentioned it would be good to have some HDInsight testing. I’ll keep this open for another 24 hours or until HDInsight test results come in. Julia, are the YARN tests you’re planning to do on HDInsight?
Thanks,
Brian
On Tue, Aug 11, 2015 at 3:05 AM, Julia Wang (QIUHE) < Qiuhe.Wang@microsoft.com> wrote:
> I have tested on .Net locally. Need to test on YARN before voting.
>
> -----Original Message-----
> From: Markus Weimer [mailto:markus@weimo.de]
> Sent: Monday, August 10, 2015 8:46 AM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> I believe we now have three +1s, right? Someone should test on
> HDInsight and it would be good to have some more people test the C#
> code. For now, that has only been tested by me.
>
> Markus
>
>
> On 2015-08-10 05:55, Yunseong Lee wrote:
> > Hi,
> >
> > +1
> >
> > I've checked:
> > - The signature and digests match.
> > - Build completes on the OSX and Linux local machine.
> > - Tests on Linux YARN and Mesos passed.
> >
> > Thanks for the great work, Brian.
> >
> > Regards,
> > Yunseong
> >
> > On Mon, Aug 10, 2015 at 3:10 PM, Brian Cho <ch...@gmail.com> wrote:
> >
> >> Hi Julia,
> >>
> >> I don’t think that’s true. The root .gitattributes [1] doesn’t
> >> match patterns which include `build.props` or `*.nuspec`. Thus, on
> >> *nix systems they are checked out as LF.
> >>
> >> I’ve started a JIRA and PR dealing with this [2].
> >>
> >> [1]
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgi
> >> th
> >> ub.com%2fapache%2fincubator-reef%2fblob%2fmaster%2f.gitattributes&d
> >> at
> >> a=01%7c01%7cQiuhe.Wang%40microsoft.com%7c9e7de2fa84be4ca30e5008d2a1
> >> 9a
> >> cc01%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=6e3GV5YsH0byrzxsA
> >> hb
> >> er6ySuZfnRpwXS2CHQibpLM4%3d [2]
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
> >> su
> >> es.apache.org%2fjira%2fbrowse%2fREEF-579&data=01%7c01%7cQiuhe.Wang%
> >> 40
> >> microsoft.com%7c9e7de2fa84be4ca30e5008d2a19acc01%7c72f988bf86f141af
> >> 91
> >> ab2d7cd011db47%7c1&sdata=JscwnxkCDSIRtRpq4ksLuZZHaLiIXi%2bZVkqCxLMF
> >> sw
> >> 0%3d
> >>
> >> Thanks,
> >> Brian
> >>
> >> On Mon, Aug 10, 2015 at 3:05 PM, Julia Wang (QIUHE) <
> >> Qiuhe.Wang@microsoft.com> wrote:
> >>
> >>> .gitattributes does cover the following two files. I guess they
> >>> got changed when the files are updated as both files are modified
> >>> by
> script.
> >>>
> >>> Thanks,
> >>> Julia
> >>>
> >>> -----Original Message-----
> >>> From: Brian Cho [mailto:chobrian@gmail.com]
> >>> Sent: Sunday, August 9, 2015 5:00 AM
> >>> To: dev@reef.incubator.apache.org
> >>> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >>>
> >>> Thanks Julia,
> >>>
> >>> If I remember correctly, we use .gitattributes to do this. This
> >>> would probably be the correct way to get the correct line endings
> >>> while keeping the files identical to the git repo. Are the files
> >>> you mentioned covered
> >> by
> >>> the following?
> >>>
> >>> build.prop
> >>> *.nuspec
> >>>
> >>> Thanks,
> >>> Brian
> >>>
> >>>
> >>>
> >>> On Sun, Aug 9, 2015 at 2:25 PM, Julia Wang (QIUHE) <
> >>> Qiuhe.Wang@microsoft.com
> >>>> wrote:
> >>>
> >>>> The line ending for all nuspec firls and build.prop file is LF.
> >>>> All .Net file should remain as CRLF.
> >>>>
> >>>> -----Original Message-----
> >>>> From: Markus Weimer [mailto:markus@weimo.de]
> >>>> Sent: Saturday, August 8, 2015 9:45 PM
> >>>> To: dev@reef.incubator.apache.org
> >>>> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >>>>
> >>>> On 2015-08-08 21:04, Byung-Gon Chun wrote:
> >>>>> I'm testing the .Net side code.
> >>>>>
> >>>>> msbuild under lang/cs has errors (maybe due to my environment setup).
> >>>>>
> >>>>> One error log message.
> >>>>> EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식
> >>>>> 또는 네임스페이스 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오.
> >>>>> [C:\Users\Byung-Gon
> >>>>> Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Eva
> >>>>> lu at or .Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
> >>>>>
> >>>>> What's required to run msbuild correctly?
> >>>>
> >>>> This looks like a setup issue. You need to either run `msbuild`
> >>>> from the 'Developer Command Line' or setup PowerShell using the
> >>>> instructions I added to the Wiki.
> >>>>
> >>>> Markus
> >>>>
> >>>>
> >>>
> >>
> >
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
We currently have 3 “full” +1’s:
- Dongjoon Hyun
- Yunseong Lee
- Markus Weimer
We could go ahead and call it a wrap. But, as Markus mentioned it would be
good to have some HDInsight testing. I’ll keep this open for another 24
hours or until HDInsight test results come in. Julia, are the YARN tests
you’re planning to do on HDInsight?
Thanks,
Brian
On Tue, Aug 11, 2015 at 3:05 AM, Julia Wang (QIUHE) <
Qiuhe.Wang@microsoft.com> wrote:
> I have tested on .Net locally. Need to test on YARN before voting.
>
> -----Original Message-----
> From: Markus Weimer [mailto:markus@weimo.de]
> Sent: Monday, August 10, 2015 8:46 AM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> I believe we now have three +1s, right? Someone should test on HDInsight
> and it would be good to have some more people test the C# code. For now,
> that has only been tested by me.
>
> Markus
>
>
> On 2015-08-10 05:55, Yunseong Lee wrote:
> > Hi,
> >
> > +1
> >
> > I've checked:
> > - The signature and digests match.
> > - Build completes on the OSX and Linux local machine.
> > - Tests on Linux YARN and Mesos passed.
> >
> > Thanks for the great work, Brian.
> >
> > Regards,
> > Yunseong
> >
> > On Mon, Aug 10, 2015 at 3:10 PM, Brian Cho <ch...@gmail.com> wrote:
> >
> >> Hi Julia,
> >>
> >> I don’t think that’s true. The root .gitattributes [1] doesn’t match
> >> patterns which include `build.props` or `*.nuspec`. Thus, on *nix
> >> systems they are checked out as LF.
> >>
> >> I’ve started a JIRA and PR dealing with this [2].
> >>
> >> [1]
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgith
> >> ub.com%2fapache%2fincubator-reef%2fblob%2fmaster%2f.gitattributes&dat
> >> a=01%7c01%7cQiuhe.Wang%40microsoft.com%7c9e7de2fa84be4ca30e5008d2a19a
> >> cc01%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=6e3GV5YsH0byrzxsAhb
> >> er6ySuZfnRpwXS2CHQibpLM4%3d [2]
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissu
> >> es.apache.org%2fjira%2fbrowse%2fREEF-579&data=01%7c01%7cQiuhe.Wang%40
> >> microsoft.com%7c9e7de2fa84be4ca30e5008d2a19acc01%7c72f988bf86f141af91
> >> ab2d7cd011db47%7c1&sdata=JscwnxkCDSIRtRpq4ksLuZZHaLiIXi%2bZVkqCxLMFsw
> >> 0%3d
> >>
> >> Thanks,
> >> Brian
> >>
> >> On Mon, Aug 10, 2015 at 3:05 PM, Julia Wang (QIUHE) <
> >> Qiuhe.Wang@microsoft.com> wrote:
> >>
> >>> .gitattributes does cover the following two files. I guess they got
> >>> changed when the files are updated as both files are modified by
> script.
> >>>
> >>> Thanks,
> >>> Julia
> >>>
> >>> -----Original Message-----
> >>> From: Brian Cho [mailto:chobrian@gmail.com]
> >>> Sent: Sunday, August 9, 2015 5:00 AM
> >>> To: dev@reef.incubator.apache.org
> >>> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >>>
> >>> Thanks Julia,
> >>>
> >>> If I remember correctly, we use .gitattributes to do this. This
> >>> would probably be the correct way to get the correct line endings
> >>> while keeping the files identical to the git repo. Are the files you
> >>> mentioned covered
> >> by
> >>> the following?
> >>>
> >>> build.prop
> >>> *.nuspec
> >>>
> >>> Thanks,
> >>> Brian
> >>>
> >>>
> >>>
> >>> On Sun, Aug 9, 2015 at 2:25 PM, Julia Wang (QIUHE) <
> >>> Qiuhe.Wang@microsoft.com
> >>>> wrote:
> >>>
> >>>> The line ending for all nuspec firls and build.prop file is LF. All
> >>>> .Net file should remain as CRLF.
> >>>>
> >>>> -----Original Message-----
> >>>> From: Markus Weimer [mailto:markus@weimo.de]
> >>>> Sent: Saturday, August 8, 2015 9:45 PM
> >>>> To: dev@reef.incubator.apache.org
> >>>> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >>>>
> >>>> On 2015-08-08 21:04, Byung-Gon Chun wrote:
> >>>>> I'm testing the .Net side code.
> >>>>>
> >>>>> msbuild under lang/cs has errors (maybe due to my environment setup).
> >>>>>
> >>>>> One error log message.
> >>>>> EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는
> >>>>> 네임스페이스 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오.
> >>>>> [C:\Users\Byung-Gon
> >>>>> Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evalu
> >>>>> at or .Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
> >>>>>
> >>>>> What's required to run msbuild correctly?
> >>>>
> >>>> This looks like a setup issue. You need to either run `msbuild`
> >>>> from the 'Developer Command Line' or setup PowerShell using the
> >>>> instructions I added to the Wiki.
> >>>>
> >>>> Markus
> >>>>
> >>>>
> >>>
> >>
> >
>
RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
I have tested on .Net locally. Need to test on YARN before voting.
-----Original Message-----
From: Markus Weimer [mailto:markus@weimo.de]
Sent: Monday, August 10, 2015 8:46 AM
To: dev@reef.incubator.apache.org
Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
I believe we now have three +1s, right? Someone should test on HDInsight and it would be good to have some more people test the C# code. For now, that has only been tested by me.
Markus
On 2015-08-10 05:55, Yunseong Lee wrote:
> Hi,
>
> +1
>
> I've checked:
> - The signature and digests match.
> - Build completes on the OSX and Linux local machine.
> - Tests on Linux YARN and Mesos passed.
>
> Thanks for the great work, Brian.
>
> Regards,
> Yunseong
>
> On Mon, Aug 10, 2015 at 3:10 PM, Brian Cho <ch...@gmail.com> wrote:
>
>> Hi Julia,
>>
>> I don’t think that’s true. The root .gitattributes [1] doesn’t match
>> patterns which include `build.props` or `*.nuspec`. Thus, on *nix
>> systems they are checked out as LF.
>>
>> I’ve started a JIRA and PR dealing with this [2].
>>
>> [1]
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgith
>> ub.com%2fapache%2fincubator-reef%2fblob%2fmaster%2f.gitattributes&dat
>> a=01%7c01%7cQiuhe.Wang%40microsoft.com%7c9e7de2fa84be4ca30e5008d2a19a
>> cc01%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=6e3GV5YsH0byrzxsAhb
>> er6ySuZfnRpwXS2CHQibpLM4%3d [2]
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissu
>> es.apache.org%2fjira%2fbrowse%2fREEF-579&data=01%7c01%7cQiuhe.Wang%40
>> microsoft.com%7c9e7de2fa84be4ca30e5008d2a19acc01%7c72f988bf86f141af91
>> ab2d7cd011db47%7c1&sdata=JscwnxkCDSIRtRpq4ksLuZZHaLiIXi%2bZVkqCxLMFsw
>> 0%3d
>>
>> Thanks,
>> Brian
>>
>> On Mon, Aug 10, 2015 at 3:05 PM, Julia Wang (QIUHE) <
>> Qiuhe.Wang@microsoft.com> wrote:
>>
>>> .gitattributes does cover the following two files. I guess they got
>>> changed when the files are updated as both files are modified by script.
>>>
>>> Thanks,
>>> Julia
>>>
>>> -----Original Message-----
>>> From: Brian Cho [mailto:chobrian@gmail.com]
>>> Sent: Sunday, August 9, 2015 5:00 AM
>>> To: dev@reef.incubator.apache.org
>>> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>>>
>>> Thanks Julia,
>>>
>>> If I remember correctly, we use .gitattributes to do this. This
>>> would probably be the correct way to get the correct line endings
>>> while keeping the files identical to the git repo. Are the files you
>>> mentioned covered
>> by
>>> the following?
>>>
>>> build.prop
>>> *.nuspec
>>>
>>> Thanks,
>>> Brian
>>>
>>>
>>>
>>> On Sun, Aug 9, 2015 at 2:25 PM, Julia Wang (QIUHE) <
>>> Qiuhe.Wang@microsoft.com
>>>> wrote:
>>>
>>>> The line ending for all nuspec firls and build.prop file is LF. All
>>>> .Net file should remain as CRLF.
>>>>
>>>> -----Original Message-----
>>>> From: Markus Weimer [mailto:markus@weimo.de]
>>>> Sent: Saturday, August 8, 2015 9:45 PM
>>>> To: dev@reef.incubator.apache.org
>>>> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>>>>
>>>> On 2015-08-08 21:04, Byung-Gon Chun wrote:
>>>>> I'm testing the .Net side code.
>>>>>
>>>>> msbuild under lang/cs has errors (maybe due to my environment setup).
>>>>>
>>>>> One error log message.
>>>>> EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는
>>>>> 네임스페이스 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오.
>>>>> [C:\Users\Byung-Gon
>>>>> Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evalu
>>>>> at or .Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
>>>>>
>>>>> What's required to run msbuild correctly?
>>>>
>>>> This looks like a setup issue. You need to either run `msbuild`
>>>> from the 'Developer Command Line' or setup PowerShell using the
>>>> instructions I added to the Wiki.
>>>>
>>>> Markus
>>>>
>>>>
>>>
>>
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
I believe we now have three +1s, right? Someone should test on HDInsight
and it would be good to have some more people test the C# code. For now,
that has only been tested by me.
Markus
On 2015-08-10 05:55, Yunseong Lee wrote:
> Hi,
>
> +1
>
> I've checked:
> - The signature and digests match.
> - Build completes on the OSX and Linux local machine.
> - Tests on Linux YARN and Mesos passed.
>
> Thanks for the great work, Brian.
>
> Regards,
> Yunseong
>
> On Mon, Aug 10, 2015 at 3:10 PM, Brian Cho <ch...@gmail.com> wrote:
>
>> Hi Julia,
>>
>> I don’t think that’s true. The root .gitattributes [1] doesn’t match
>> patterns which include `build.props` or `*.nuspec`. Thus, on *nix systems
>> they are checked out as LF.
>>
>> I’ve started a JIRA and PR dealing with this [2].
>>
>> [1] https://github.com/apache/incubator-reef/blob/master/.gitattributes
>> [2] https://issues.apache.org/jira/browse/REEF-579
>>
>> Thanks,
>> Brian
>>
>> On Mon, Aug 10, 2015 at 3:05 PM, Julia Wang (QIUHE) <
>> Qiuhe.Wang@microsoft.com> wrote:
>>
>>> .gitattributes does cover the following two files. I guess they got
>>> changed when the files are updated as both files are modified by script.
>>>
>>> Thanks,
>>> Julia
>>>
>>> -----Original Message-----
>>> From: Brian Cho [mailto:chobrian@gmail.com]
>>> Sent: Sunday, August 9, 2015 5:00 AM
>>> To: dev@reef.incubator.apache.org
>>> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>>>
>>> Thanks Julia,
>>>
>>> If I remember correctly, we use .gitattributes to do this. This would
>>> probably be the correct way to get the correct line endings while keeping
>>> the files identical to the git repo. Are the files you mentioned covered
>> by
>>> the following?
>>>
>>> build.prop
>>> *.nuspec
>>>
>>> Thanks,
>>> Brian
>>>
>>>
>>>
>>> On Sun, Aug 9, 2015 at 2:25 PM, Julia Wang (QIUHE) <
>>> Qiuhe.Wang@microsoft.com
>>>> wrote:
>>>
>>>> The line ending for all nuspec firls and build.prop file is LF. All
>>>> .Net file should remain as CRLF.
>>>>
>>>> -----Original Message-----
>>>> From: Markus Weimer [mailto:markus@weimo.de]
>>>> Sent: Saturday, August 8, 2015 9:45 PM
>>>> To: dev@reef.incubator.apache.org
>>>> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>>>>
>>>> On 2015-08-08 21:04, Byung-Gon Chun wrote:
>>>>> I'm testing the .Net side code.
>>>>>
>>>>> msbuild under lang/cs has errors (maybe due to my environment setup).
>>>>>
>>>>> One error log message.
>>>>> EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는
>>>>> 네임스페이스 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오.
>>>>> [C:\Users\Byung-Gon
>>>>> Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evaluat
>>>>> or .Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
>>>>>
>>>>> What's required to run msbuild correctly?
>>>>
>>>> This looks like a setup issue. You need to either run `msbuild` from
>>>> the 'Developer Command Line' or setup PowerShell using the
>>>> instructions I added to the Wiki.
>>>>
>>>> Markus
>>>>
>>>>
>>>
>>
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Yunseong Lee <yu...@gmail.com>.
Hi,
+1
I've checked:
- The signature and digests match.
- Build completes on the OSX and Linux local machine.
- Tests on Linux YARN and Mesos passed.
Thanks for the great work, Brian.
Regards,
Yunseong
On Mon, Aug 10, 2015 at 3:10 PM, Brian Cho <ch...@gmail.com> wrote:
> Hi Julia,
>
> I don’t think that’s true. The root .gitattributes [1] doesn’t match
> patterns which include `build.props` or `*.nuspec`. Thus, on *nix systems
> they are checked out as LF.
>
> I’ve started a JIRA and PR dealing with this [2].
>
> [1] https://github.com/apache/incubator-reef/blob/master/.gitattributes
> [2] https://issues.apache.org/jira/browse/REEF-579
>
> Thanks,
> Brian
>
> On Mon, Aug 10, 2015 at 3:05 PM, Julia Wang (QIUHE) <
> Qiuhe.Wang@microsoft.com> wrote:
>
> > .gitattributes does cover the following two files. I guess they got
> > changed when the files are updated as both files are modified by script.
> >
> > Thanks,
> > Julia
> >
> > -----Original Message-----
> > From: Brian Cho [mailto:chobrian@gmail.com]
> > Sent: Sunday, August 9, 2015 5:00 AM
> > To: dev@reef.incubator.apache.org
> > Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >
> > Thanks Julia,
> >
> > If I remember correctly, we use .gitattributes to do this. This would
> > probably be the correct way to get the correct line endings while keeping
> > the files identical to the git repo. Are the files you mentioned covered
> by
> > the following?
> >
> > build.prop
> > *.nuspec
> >
> > Thanks,
> > Brian
> >
> >
> >
> > On Sun, Aug 9, 2015 at 2:25 PM, Julia Wang (QIUHE) <
> > Qiuhe.Wang@microsoft.com
> > > wrote:
> >
> > > The line ending for all nuspec firls and build.prop file is LF. All
> > > .Net file should remain as CRLF.
> > >
> > > -----Original Message-----
> > > From: Markus Weimer [mailto:markus@weimo.de]
> > > Sent: Saturday, August 8, 2015 9:45 PM
> > > To: dev@reef.incubator.apache.org
> > > Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> > >
> > > On 2015-08-08 21:04, Byung-Gon Chun wrote:
> > > > I'm testing the .Net side code.
> > > >
> > > > msbuild under lang/cs has errors (maybe due to my environment setup).
> > > >
> > > > One error log message.
> > > > EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는
> > > > 네임스페이스 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오.
> > > > [C:\Users\Byung-Gon
> > > > Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evaluat
> > > > or .Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
> > > >
> > > > What's required to run msbuild correctly?
> > >
> > > This looks like a setup issue. You need to either run `msbuild` from
> > > the 'Developer Command Line' or setup PowerShell using the
> > > instructions I added to the Wiki.
> > >
> > > Markus
> > >
> > >
> >
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
Hi Julia,
I don’t think that’s true. The root .gitattributes [1] doesn’t match
patterns which include `build.props` or `*.nuspec`. Thus, on *nix systems
they are checked out as LF.
I’ve started a JIRA and PR dealing with this [2].
[1] https://github.com/apache/incubator-reef/blob/master/.gitattributes
[2] https://issues.apache.org/jira/browse/REEF-579
Thanks,
Brian
On Mon, Aug 10, 2015 at 3:05 PM, Julia Wang (QIUHE) <
Qiuhe.Wang@microsoft.com> wrote:
> .gitattributes does cover the following two files. I guess they got
> changed when the files are updated as both files are modified by script.
>
> Thanks,
> Julia
>
> -----Original Message-----
> From: Brian Cho [mailto:chobrian@gmail.com]
> Sent: Sunday, August 9, 2015 5:00 AM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> Thanks Julia,
>
> If I remember correctly, we use .gitattributes to do this. This would
> probably be the correct way to get the correct line endings while keeping
> the files identical to the git repo. Are the files you mentioned covered by
> the following?
>
> build.prop
> *.nuspec
>
> Thanks,
> Brian
>
>
>
> On Sun, Aug 9, 2015 at 2:25 PM, Julia Wang (QIUHE) <
> Qiuhe.Wang@microsoft.com
> > wrote:
>
> > The line ending for all nuspec firls and build.prop file is LF. All
> > .Net file should remain as CRLF.
> >
> > -----Original Message-----
> > From: Markus Weimer [mailto:markus@weimo.de]
> > Sent: Saturday, August 8, 2015 9:45 PM
> > To: dev@reef.incubator.apache.org
> > Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
> >
> > On 2015-08-08 21:04, Byung-Gon Chun wrote:
> > > I'm testing the .Net side code.
> > >
> > > msbuild under lang/cs has errors (maybe due to my environment setup).
> > >
> > > One error log message.
> > > EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는
> > > 네임스페이스 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오.
> > > [C:\Users\Byung-Gon
> > > Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evaluat
> > > or .Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
> > >
> > > What's required to run msbuild correctly?
> >
> > This looks like a setup issue. You need to either run `msbuild` from
> > the 'Developer Command Line' or setup PowerShell using the
> > instructions I added to the Wiki.
> >
> > Markus
> >
> >
>
RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
.gitattributes does cover the following two files. I guess they got changed when the files are updated as both files are modified by script.
Thanks,
Julia
-----Original Message-----
From: Brian Cho [mailto:chobrian@gmail.com]
Sent: Sunday, August 9, 2015 5:00 AM
To: dev@reef.incubator.apache.org
Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Thanks Julia,
If I remember correctly, we use .gitattributes to do this. This would probably be the correct way to get the correct line endings while keeping the files identical to the git repo. Are the files you mentioned covered by the following?
build.prop
*.nuspec
Thanks,
Brian
On Sun, Aug 9, 2015 at 2:25 PM, Julia Wang (QIUHE) <Qiuhe.Wang@microsoft.com
> wrote:
> The line ending for all nuspec firls and build.prop file is LF. All
> .Net file should remain as CRLF.
>
> -----Original Message-----
> From: Markus Weimer [mailto:markus@weimo.de]
> Sent: Saturday, August 8, 2015 9:45 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> On 2015-08-08 21:04, Byung-Gon Chun wrote:
> > I'm testing the .Net side code.
> >
> > msbuild under lang/cs has errors (maybe due to my environment setup).
> >
> > One error log message.
> > EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는
> > 네임스페이스 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오.
> > [C:\Users\Byung-Gon
> > Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evaluat
> > or .Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
> >
> > What's required to run msbuild correctly?
>
> This looks like a setup issue. You need to either run `msbuild` from
> the 'Developer Command Line' or setup PowerShell using the
> instructions I added to the Wiki.
>
> Markus
>
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-09 18:17, Brian Cho wrote:
> Also, how bad is this issue for windows users/developers? Is it a
> deal-breaker that should lead to rc3?
Hmm, I was able to build and test just fine with these line endings.
Also, Visual Studio can open them just like all the other files. Hence,
I'd be OK to release with UNIX line endings on `build.props` and the
`.nuspec` files. If we have another issue, it might make sense to go to
RC3 and resolve this as well, though.
Markus
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
On Sun, Aug 9, 2015 at 8:59 PM, Brian Cho <ch...@gmail.com> wrote:
> Thanks Julia,
>
> If I remember correctly, we use .gitattributes to do this. This would
> probably be the correct way to get the correct line endings while keeping
> the files identical to the git repo. Are the files you mentioned covered by
> the following?
>
> build.prop
> *.nuspec
>
>
Alternatively, what do you think about just adding a .gitattributes per
lang directory i.e. /lang/cs/.gitattributes and /lang/java/.gitattributes ?
Also, how bad is this issue for windows users/developers? Is it a
deal-breaker that should lead to rc3?
-Brian
> Thanks,
> Brian
>
>
>
> On Sun, Aug 9, 2015 at 2:25 PM, Julia Wang (QIUHE) <
> Qiuhe.Wang@microsoft.com> wrote:
>
>> The line ending for all nuspec firls and build.prop file is LF. All .Net
>> file should remain as CRLF.
>>
>> -----Original Message-----
>> From: Markus Weimer [mailto:markus@weimo.de]
>> Sent: Saturday, August 8, 2015 9:45 PM
>> To: dev@reef.incubator.apache.org
>> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>>
>> On 2015-08-08 21:04, Byung-Gon Chun wrote:
>> > I'm testing the .Net side code.
>> >
>> > msbuild under lang/cs has errors (maybe due to my environment setup).
>> >
>> > One error log message.
>> > EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는
>> > 네임스페이스 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오.
>> > [C:\Users\Byung-Gon
>> > Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evaluator
>> > .Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
>> >
>> > What's required to run msbuild correctly?
>>
>> This looks like a setup issue. You need to either run `msbuild` from the
>> 'Developer Command Line' or setup PowerShell using the instructions I added
>> to the Wiki.
>>
>> Markus
>>
>>
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
Thanks Julia,
If I remember correctly, we use .gitattributes to do this. This would
probably be the correct way to get the correct line endings while keeping
the files identical to the git repo. Are the files you mentioned covered by
the following?
build.prop
*.nuspec
Thanks,
Brian
On Sun, Aug 9, 2015 at 2:25 PM, Julia Wang (QIUHE) <Qiuhe.Wang@microsoft.com
> wrote:
> The line ending for all nuspec firls and build.prop file is LF. All .Net
> file should remain as CRLF.
>
> -----Original Message-----
> From: Markus Weimer [mailto:markus@weimo.de]
> Sent: Saturday, August 8, 2015 9:45 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
>
> On 2015-08-08 21:04, Byung-Gon Chun wrote:
> > I'm testing the .Net side code.
> >
> > msbuild under lang/cs has errors (maybe due to my environment setup).
> >
> > One error log message.
> > EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는
> > 네임스페이스 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오.
> > [C:\Users\Byung-Gon
> > Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evaluator
> > .Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
> >
> > What's required to run msbuild correctly?
>
> This looks like a setup issue. You need to either run `msbuild` from the
> 'Developer Command Line' or setup PowerShell using the instructions I added
> to the Wiki.
>
> Markus
>
>
RE: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
The line ending for all nuspec firls and build.prop file is LF. All .Net file should remain as CRLF.
-----Original Message-----
From: Markus Weimer [mailto:markus@weimo.de]
Sent: Saturday, August 8, 2015 9:45 PM
To: dev@reef.incubator.apache.org
Subject: Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
On 2015-08-08 21:04, Byung-Gon Chun wrote:
> I'm testing the .Net side code.
>
> msbuild under lang/cs has errors (maybe due to my environment setup).
>
> One error log message.
> EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는
> 네임스페이스 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오.
> [C:\Users\Byung-Gon
> Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evaluator
> .Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
>
> What's required to run msbuild correctly?
This looks like a setup issue. You need to either run `msbuild` from the 'Developer Command Line' or setup PowerShell using the instructions I added to the Wiki.
Markus
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Byung-Gon Chun <bg...@gmail.com>.
big +1 for using VS 2015 as a goal for 0.13.
On Sun, Aug 9, 2015 at 11:47 PM, Markus Weimer <ma...@weimo.de> wrote:
> On 2015-08-09 03:03, Byung-Gon Chun wrote:
> > The current setup requires VS 2013. I'm currently using VS 2015
> Community.
> > Unless we change ToolsVersion, I cannot test it.
>
> Yes, the build only works with VS 2013. It is unlikely to be fixed in
> 0.12, but it would be a good goal for 0.13 to use VS 2015.
>
> Markus
>
--
Byung-Gon Chun
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-09 03:03, Byung-Gon Chun wrote:
> The current setup requires VS 2013. I'm currently using VS 2015 Community.
> Unless we change ToolsVersion, I cannot test it.
Yes, the build only works with VS 2013. It is unlikely to be fixed in
0.12, but it would be a good goal for 0.13 to use VS 2015.
Markus
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Byung-Gon Chun <bg...@gmail.com>.
The current setup requires VS 2013. I'm currently using VS 2015 Community.
Unless we change ToolsVersion, I cannot test it.
===
+1 Java side
The signature, digests match.
Local tests pass in my mac.
On Sun, Aug 9, 2015 at 1:45 PM, Markus Weimer <ma...@weimo.de> wrote:
> On 2015-08-08 21:04, Byung-Gon Chun wrote:
> > I'm testing the .Net side code.
> >
> > msbuild under lang/cs has errors (maybe due to my environment setup).
> >
> > One error log message.
> > EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는 네임스페이스
> > 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오. [C:\Users\Byung-Gon
> >
> Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evaluator.Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
> >
> > What's required to run msbuild correctly?
>
> This looks like a setup issue. You need to either run `msbuild` from the
> 'Developer Command Line' or setup PowerShell using the instructions I
> added to the Wiki.
>
> Markus
>
>
--
Byung-Gon Chun
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-08 21:04, Byung-Gon Chun wrote:
> I'm testing the .Net side code.
>
> msbuild under lang/cs has errors (maybe due to my environment setup).
>
> One error log message.
> EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는 네임스페이스
> 이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오. [C:\Users\Byung-Gon
> Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evaluator.Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
>
> What's required to run msbuild correctly?
This looks like a setup issue. You need to either run `msbuild` from the
'Developer Command Line' or setup PowerShell using the instructions I
added to the Wiki.
Markus
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Byung-Gon Chun <bg...@gmail.com>.
I'm testing the .Net side code.
msbuild under lang/cs has errors (maybe due to my environment setup).
One error log message.
EvaluatorTests.cs(35,6): error CS0246: 'TestClassAttribute' 형식 또는 네임스페이스
이름을 찾을 수 없습니다. using 지시문 또는 어셈블리 참조가 있는지 확인하십시오. [C:\Users\Byung-Gon
Chun\Documents\GitHub\incubator-reef\lang\cs\Org.Apache.REEF.Evaluator.Tests\Org.Apache.REEF.Evaluator.Tests.csproj]
What's required to run msbuild correctly?
On Sun, Aug 9, 2015 at 12:12 PM, Markus Weimer <ma...@weimo.de> wrote:
> On 2015-08-08 19:14, Brian Cho wrote:
> > On another topic, I’ve tested on Linux YARN and Mesos. But, I’d be
> > happy if someone who is not the release manager does these tests as
> > well. I don’t believe I have a vote either, so the current tally is
> > one provisional +0.
>
> Why wouldn't you have a vote? If you want to, I think you should be able
> to vote.
>
> Markus
>
--
Byung-Gon Chun
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-08 19:14, Brian Cho wrote:
> On another topic, I’ve tested on Linux YARN and Mesos. But, I’d be
> happy if someone who is not the release manager does these tests as
> well. I don’t believe I have a vote either, so the current tally is
> one provisional +0.
Why wouldn't you have a vote? If you want to, I think you should be able
to vote.
Markus
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-08 19:14, Brian Cho wrote:
> Yes, sadly adding .txt does work. :)
Excellent. While I am still curious to find out which side messed up
(the server setting the wrong content type or the browser wrongfully
converting it to binary), let's settle on just calling them .txt from
hereon out.
On a related quest, I found out that PowerShell supports all hashing
functions we use[0]. Once we standardize on a hash-file-format, it
should be possible to whip up a PowerShell function that validates them.
Markus
[0]:https://technet.microsoft.com/en-us/library/dn520872.aspx
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
Thanks Markus,
Yes, sadly adding .txt does work. :) As we seem to be the only ones who
have started checking things, I went ahead and changed the files.
I renamed .sha to .sha512.txt and also changed the content of the files.
They now match what `md5sum -b`/`sha512sum -b` will give on Linux (I also
assume on Windows) and can be checked as follows:
ubuntu@node09:~/reef-test/release$ md5sum -c
apache-reef-0.12.0-incubating-rc2.tar.gz.md5
apache-reef-0.12.0-incubating-rc2.tar.gz: OK
ubuntu@node09:~/reef-test/release$ sha512sum -c
apache-reef-0.12.0-incubating-rc2.tar.gz.sha512.txt
apache-reef-0.12.0-incubating-rc2.tar.gz: OK
If this works for everyone, we can change the release scripts accordingly.
===
On another topic, I’ve tested on Linux YARN and Mesos. But, I’d be happy if
someone who is not the release manager does these tests as well. I don’t
believe I have a vote either, so the current tally is one provisional +0.
Thanks,
Brian
On Sun, Aug 9, 2015 at 5:32 AM, Markus Weimer <ma...@weimo.de> wrote:
> On 2015-08-08 11:30, Tobin Baker wrote:
> > Just kibitzing here,
>
> Thanks! BTW: You are of course also free to test this release candidate
> in your environment and let us know whether it worked. In fact, this is
> one of the best ways we have to spot hard-to-find issues.
>
> > but could this be related to Windows seeing an isolated line feed
> > character ('\n') with no accompanying carriage return ('\r'), and
> > interpreting it as a non-text character?
>
> Could be. However, the crazy thing is that the file itself changes
> content when it is downloaded, as shown by the changed MD5 of the SHA512
> file. Maybe the server sets some binary header which confuses Windows?
> Or that gets wrongfully ignored on UNIX?
>
> Brian: Can you upload the SHA512 with file ending .SHA512.txt? Sad as it
> sounds, but file extensions still matter...
>
> Markus
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-08 11:30, Tobin Baker wrote:
> Just kibitzing here,
Thanks! BTW: You are of course also free to test this release candidate
in your environment and let us know whether it worked. In fact, this is
one of the best ways we have to spot hard-to-find issues.
> but could this be related to Windows seeing an isolated line feed
> character ('\n') with no accompanying carriage return ('\r'), and
> interpreting it as a non-text character?
Could be. However, the crazy thing is that the file itself changes
content when it is downloaded, as shown by the changed MD5 of the SHA512
file. Maybe the server sets some binary header which confuses Windows?
Or that gets wrongfully ignored on UNIX?
Brian: Can you upload the SHA512 with file ending .SHA512.txt? Sad as it
sounds, but file extensions still matter...
Markus
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Tobin Baker <td...@cs.washington.edu>.
Just kibitzing here, but could this be related to Windows seeing an
isolated line feed character ('\n') with no accompanying carriage return
('\r'), and interpreting it as a non-text character?
On Sat, Aug 8, 2015 at 11:18 AM, Markus Weimer <ma...@weimo.de> wrote:
>
>
> On 2015-08-08 10:58, Brian Cho wrote:
> > The behavior is bizarre, and seems to happen on other similar files as
> > well. Can you try:
> >
> >
> https://dist.apache.org/repos/dist/dev/incubator/brooklyn/apache-brooklyn-0.7.0-incubating-rc1/apache-brooklyn-0.7.0-incubating-rc1-bin.tar.gz.sha256
> >
> > This has the same behavior for me: looks fine on Mac, and becomes a
> strange
> > binary file on Windows 7 VM for me.
>
> Confirmed. The file turns to binary when I download it via Firefox on
> Windows. Not sure how that happens.
>
> I don't think we should block the release because of it, but we should
> get to the bottom of this issue.
>
> Markus
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-08 10:58, Brian Cho wrote:
> The behavior is bizarre, and seems to happen on other similar files as
> well. Can you try:
>
> https://dist.apache.org/repos/dist/dev/incubator/brooklyn/apache-brooklyn-0.7.0-incubating-rc1/apache-brooklyn-0.7.0-incubating-rc1-bin.tar.gz.sha256
>
> This has the same behavior for me: looks fine on Mac, and becomes a strange
> binary file on Windows 7 VM for me.
Confirmed. The file turns to binary when I download it via Firefox on
Windows. Not sure how that happens.
I don't think we should block the release because of it, but we should
get to the bottom of this issue.
Markus
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
On Sun, Aug 9, 2015 at 2:36 AM, Brian Cho <ch...@gmail.com> wrote:
>
>
> On Sun, Aug 9, 2015 at 2:17 AM, Markus Weimer <ma...@weimo.de> wrote:
>
>> On 2015-08-08 08:45, Brian Cho wrote:
>> > Both md5 and sha512 were created by running the corresponding
>> > functions from python hashlib, then concatenating strings and
>> > writing to a file. [1]
>> >
>> > It’s weird that one would be text, but the other binary. On my Mac
>> > laptop they both print out fine and look like text.
>>
>> I just double-checked and even downloaded the file via curl instead of
>> Firefox. Either way, the .sha file doesn't contain any text. Did you
>> download it from the web server before testing? Maybe the server did
>> some transformation to it?
>>
>
> This is strange. I’ve tried downloading from Mac and linux (via Chrome and
> wget). I get the same file. The md5 of the sha file is:
>
> be819de7dc75267c80c50d60c175504f
>
> I then tried downloading on a Windows 7 VM (via IE). Checking that file I
> get md5 of the sha file as:
>
> 15a8920ffc66aba293b86f5b0477b85f
>
> What Windows does to this file, and how to prevent it is beyond me. Maybe
> someone with more experience with Windows knows?
>
>
The behavior is bizarre, and seems to happen on other similar files as
well. Can you try:
https://dist.apache.org/repos/dist/dev/incubator/brooklyn/apache-brooklyn-0.7.0-incubating-rc1/apache-brooklyn-0.7.0-incubating-rc1-bin.tar.gz.sha256
This has the same behavior for me: looks fine on Mac, and becomes a strange
binary file on Windows 7 VM for me.
Thanks,
Brian
>
>
>>
>> > We should standardize on this or something else if it gets in the
>> > way of testing releases.
>>
>> Agreed. But we have competing interests here: In the extreme case, we'd
>> just provide the verification script. That would be extremely
>> convenient, but also quite self-defeating, as we'd distribute the
>> verification tool in the same package :-)
>>
>> I like the OpenOffice approach of just enumerating many, many tools that
>> can be used to verify. That ecosystem of tools ensures safety. As long
>> as our hash files are text :-)
>>
>> One minor nitpick: Please rename the file to `.SHA512` for the final
>> release. That way, people will just know which algo to apply.
>>
>
> Yes, I’ll update that after this vote ends (so as not to confuse people
> during the vote).
>
>
>>
>> Markus
>>
>
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
On Sun, Aug 9, 2015 at 2:17 AM, Markus Weimer <ma...@weimo.de> wrote:
> On 2015-08-08 08:45, Brian Cho wrote:
> > Both md5 and sha512 were created by running the corresponding
> > functions from python hashlib, then concatenating strings and
> > writing to a file. [1]
> >
> > It’s weird that one would be text, but the other binary. On my Mac
> > laptop they both print out fine and look like text.
>
> I just double-checked and even downloaded the file via curl instead of
> Firefox. Either way, the .sha file doesn't contain any text. Did you
> download it from the web server before testing? Maybe the server did
> some transformation to it?
>
This is strange. I’ve tried downloading from Mac and linux (via Chrome and
wget). I get the same file. The md5 of the sha file is:
be819de7dc75267c80c50d60c175504f
I then tried downloading on a Windows 7 VM (via IE). Checking that file I
get md5 of the sha file as:
15a8920ffc66aba293b86f5b0477b85f
What Windows does to this file, and how to prevent it is beyond me. Maybe
someone with more experience with Windows knows?
>
> > We should standardize on this or something else if it gets in the
> > way of testing releases.
>
> Agreed. But we have competing interests here: In the extreme case, we'd
> just provide the verification script. That would be extremely
> convenient, but also quite self-defeating, as we'd distribute the
> verification tool in the same package :-)
>
> I like the OpenOffice approach of just enumerating many, many tools that
> can be used to verify. That ecosystem of tools ensures safety. As long
> as our hash files are text :-)
>
> One minor nitpick: Please rename the file to `.SHA512` for the final
> release. That way, people will just know which algo to apply.
>
Yes, I’ll update that after this vote ends (so as not to confuse people
during the vote).
>
> Markus
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-08 08:45, Brian Cho wrote:
> Both md5 and sha512 were created by running the corresponding
> functions from python hashlib, then concatenating strings and
> writing to a file. [1]
>
> It’s weird that one would be text, but the other binary. On my Mac
> laptop they both print out fine and look like text.
I just double-checked and even downloaded the file via curl instead of
Firefox. Either way, the .sha file doesn't contain any text. Did you
download it from the web server before testing? Maybe the server did
some transformation to it?
> We should standardize on this or something else if it gets in the
> way of testing releases.
Agreed. But we have competing interests here: In the extreme case, we'd
just provide the verification script. That would be extremely
convenient, but also quite self-defeating, as we'd distribute the
verification tool in the same package :-)
I like the OpenOffice approach of just enumerating many, many tools that
can be used to verify. That ecosystem of tools ensures safety. As long
as our hash files are text :-)
One minor nitpick: Please rename the file to `.SHA512` for the final
release. That way, people will just know which algo to apply.
Markus
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
Hi Markus,
On Sun, Aug 9, 2015 at 12:18 AM, Markus Weimer <ma...@weimo.de> wrote:
> Overall, I am +0 on the release. As always, we need to have confirmation
> of test success on all platforms before raising that to a +1.
>
> I tested on Windows 8.1 Pro x64 with Java 1.8.0_20.
>
> The good news
> -------------
>
> * Verified the signature. I also signed Brian's key from the KEYS file
> and uploaded it to the keyserver. It is now (loosely) connected to
> the Apache Web of Trust. Gon, Julia: Maybe do the same?
>
Thanks, that’s great :)
> * The Java and .NET projects build and test just fine.
>
> The OK news
> -----------
>
> MD5 is correct, but can't be verified with my copy of `md5sum -c`
>
> The somewhat bad news
> ---------------------
>
> I don't know how to validate the SHA file. It seems to be binary? For
> reference:
>
> > $> gpg --print-md SHA512 apache-reef-0.12.0-incubating-rc2.tar.gz
> > apache-reef-0.12.0-incubating-rc2.tar.gz:
> > A5EC246F C5F73427 ECB74F47 25CE7AC1 A8911EE7 CF969AA4 5142B05B 4985F385
> 547B9FF4
> > 7D6752E6 C505DBBC 98ACDA76 2D2FC22F 3E275904 0E2A7D9A 0249398D
>
> This SHA512 agrees with the one in the email below. I'm fine releasing
> like this *if* we can provide instructions on how to verify the hash.
>
Both md5 and sha512 were created by running the corresponding functions
from python hashlib, then concatenating strings and writing to a file. [1]
It’s weird that one would be text, but the other binary. On my Mac laptop
they both print out fine and look like text.
As far as the format, different utilities produce different output.
(OpenOffice has a list for those interested [2].) The md5 output is
identical to (again on my Mac laptop) using `openssl`:
$ openssl dgst -md5 apache-reef-0.12.0-incubating-rc2.tar.gz
This is slightly different from what I get on my laptop using `md5`. There
is no `md5sum` on my laptop.
The sha output text is slightly different from what `openssl` gives me.
(The sum itself is the same.)
Do you know of any required or recommended hash tools that Apache endorses?
We should standardize on this or something else if it gets in the way of
testing releases. We could adjust the script (which is cross-platform) to
print out the right strings.
[1] https://github.com/apache/incubator-reef/pull/331
[2] http://www.openoffice.org/download/checksums.html
Thanks,
Brian
> How do you validate the file on UNIX systems? Maybe we can find a
> reputable source of hash implementations on Windows and link to it in
> the install section? Personally, I like GnuPG for that sort of thing, as
> OSS devs have it anyway for code signing.
>
> Markus
>
> On 2015-08-07 08:46, Brian Cho wrote:
> > This is to call for a new vote for the source release of Apache REEF
> > 0.12.0-incubating (rc2).
> >
> > The source tar ball, including signatures, digests, etc can be found at:
> >
> https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/
> >
> > The Git tag is release-0.12.0-incubating-rc2
> > The Git commit ID is 13a238d1ba4f1ddca06634773090be79dda0f985
> >
> >
> > Checksums of apache-reef-0.12.0-incubating-rc2.tar.gz:
> >
> > MD5: 5d74f66220fdb3316f4a50574ef52cd4
> >
> > SHA:
> >
> a5ec246fc5f73427ecb74f4725ce7ac1a8911ee7cf969aa45142b05b4985f385547b9ff47d6752e6c505dbbc98acda762d2fc22f3e2759040e2a7d9a0249398d
> >
> > Release artifacts are signed with the key. The KEYS file is available
> here:
> >
> > https://dist.apache.org/repos/dist/release/incubator/reef/KEYS
> >
> >
> >
> > Issues Resolved in the release
> > 177 issues were closed/resolved for this release:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315820&version=12332143
> >
> >
> >
> > The vote will be open for 72 hours. Please download the release
> > candidate, check the hashes/signature, build it and test it, and then
> > please vote:
> >
> > [ ] +1 Release this package as Apache REEF 0.12.0-incubating
> > [ ] +0 no opinion
> > [ ] -1 Do not release this package because ...
> >
> > Thanks!
> >
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-08 08:18, Markus Weimer wrote:
> Overall, I am +0 on the release. As always, we need to have
> confirmation of test success on all platforms before raising that to
> a +1.
I'm raising to a +1. We have confirmation of the code running on YARN
and Mesos on Linux, and I just validated the java tests on a Windows
cluster as well as on HDInsight.
All that is missing now are some more confirmed successes on Windows
with the .NET code.
Markus
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
Overall, I am +0 on the release. As always, we need to have confirmation
of test success on all platforms before raising that to a +1.
I tested on Windows 8.1 Pro x64 with Java 1.8.0_20.
The good news
-------------
* Verified the signature. I also signed Brian's key from the KEYS file
and uploaded it to the keyserver. It is now (loosely) connected to
the Apache Web of Trust. Gon, Julia: Maybe do the same?
* The Java and .NET projects build and test just fine.
The OK news
-----------
MD5 is correct, but can't be verified with my copy of `md5sum -c`
The somewhat bad news
---------------------
I don't know how to validate the SHA file. It seems to be binary? For
reference:
> $> gpg --print-md SHA512 apache-reef-0.12.0-incubating-rc2.tar.gz
> apache-reef-0.12.0-incubating-rc2.tar.gz:
> A5EC246F C5F73427 ECB74F47 25CE7AC1 A8911EE7 CF969AA4 5142B05B 4985F385 547B9FF4
> 7D6752E6 C505DBBC 98ACDA76 2D2FC22F 3E275904 0E2A7D9A 0249398D
This SHA512 agrees with the one in the email below. I'm fine releasing
like this *if* we can provide instructions on how to verify the hash.
How do you validate the file on UNIX systems? Maybe we can find a
reputable source of hash implementations on Windows and link to it in
the install section? Personally, I like GnuPG for that sort of thing, as
OSS devs have it anyway for code signing.
Markus
On 2015-08-07 08:46, Brian Cho wrote:
> This is to call for a new vote for the source release of Apache REEF
> 0.12.0-incubating (rc2).
>
> The source tar ball, including signatures, digests, etc can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/reef/0.12.0-incubating-rc2/
>
> The Git tag is release-0.12.0-incubating-rc2
> The Git commit ID is 13a238d1ba4f1ddca06634773090be79dda0f985
>
>
> Checksums of apache-reef-0.12.0-incubating-rc2.tar.gz:
>
> MD5: 5d74f66220fdb3316f4a50574ef52cd4
>
> SHA:
> a5ec246fc5f73427ecb74f4725ce7ac1a8911ee7cf969aa45142b05b4985f385547b9ff47d6752e6c505dbbc98acda762d2fc22f3e2759040e2a7d9a0249398d
>
> Release artifacts are signed with the key. The KEYS file is available here:
>
> https://dist.apache.org/repos/dist/release/incubator/reef/KEYS
>
>
>
> Issues Resolved in the release
> 177 issues were closed/resolved for this release:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315820&version=12332143
>
>
>
> The vote will be open for 72 hours. Please download the release
> candidate, check the hashes/signature, build it and test it, and then
> please vote:
>
> [ ] +1 Release this package as Apache REEF 0.12.0-incubating
> [ ] +0 no opinion
> [ ] -1 Do not release this package because ...
>
> Thanks!
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Brian Cho <ch...@gmail.com>.
Yes, SHA512. I will make that more explicit in the general@ mail.
FYI, SHA1 is no longer recommended.
Thanks,
Brian
On Sat, Aug 8, 2015 at 12:54 AM, Markus Weimer <ma...@weimo.de> wrote:
> On 2015-08-07 08:46, Brian Cho wrote:
> > SHA:
> >
> a5ec246fc5f73427ecb74f4725ce7ac1a8911ee7cf969aa45142b05b4985f385547b9ff47d6752e6c505dbbc98acda762d2fc22f3e2759040e2a7d9a0249398d
>
> Which SHA algo was used? SHA512?
>
> Markus
>
Re: [VOTE] Release Apache REEF 0.12.0-incubating (rc2)
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-07 08:46, Brian Cho wrote:
> SHA:
> a5ec246fc5f73427ecb74f4725ce7ac1a8911ee7cf969aa45142b05b4985f385547b9ff47d6752e6c505dbbc98acda762d2fc22f3e2759040e2a7d9a0249398d
Which SHA algo was used? SHA512?
Markus