[GitHub] [maven-pmd-plugin] adangel opened a new pull request, #101: [MPMD-335] - Aggregate mode doesn't use additional repositories

[GitBox <gi...@apache.org>]

adangel opened a new pull request, #101:
URL: https://github.com/apache/maven-pmd-plugin/pull/101

   https://issues.apache.org/jira/browse/MPMD-335
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPMD) filed
          for the change (usually before you start working on it).  Trivial changes like typos do not
          require a JIRA issue.  Your pull request should address just this issue, without
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[MPMD-XXX] - Subject of the JIRA Ticket`,
          where you replace `MPMD-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the
          commit message.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
          be performed on your pull request automatically.
    - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-pmd-plugin] adangel commented on a diff in pull request #101: [MPMD-335] - Aggregate mode doesn't use additional repositories

[GitBox <gi...@apache.org>]

adangel commented on code in PR #101:
URL: https://github.com/apache/maven-pmd-plugin/pull/101#discussion_r1031494338


##########
src/it/MPMD-335-aggregate-classpath-repositories/verify.groovy:
##########
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+File buildLog = new File( basedir, 'build.log' )
+assert buildLog.exists()
+assert !buildLog.text.contains( 'The POM for org.apache.maven.plugins.pmd.it:mpmd335-dependency1:jar:1.0.0-SNAPSHOT is missing, no dependency information available' )
+assert !buildLog.text.contains( 'org.eclipse.aether.resolution.DependencyResolutionException: Could not find artifact org.apache.maven.plugins.pmd.it:mpmd335-dependency1:jar:1.0.0-SNAPSHOT' )

Review Comment:
   This verifies actually a wrong log message. the test dependency is now package pom and not jar anymore...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-pmd-plugin] adangel merged pull request #101: [MPMD-335] - Aggregate mode doesn't use additional repositories

[GitBox <gi...@apache.org>]

adangel merged PR #101:
URL: https://github.com/apache/maven-pmd-plugin/pull/101


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org