You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2012/03/26 15:08:27 UTC
[jira] [Created] (LUCENE-3923) fail the build on wrong
svn:eol-style
fail the build on wrong svn:eol-style
-------------------------------------
Key: LUCENE-3923
URL: https://issues.apache.org/jira/browse/LUCENE-3923
Project: Lucene - Java
Issue Type: Task
Components: general/build
Reporter: Robert Muir
I'm tired of fixing this before releases. Jenkins should detect and fail on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3923) fail the build on wrong
svn:eol-style
Posted by "Mark Miller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247861#comment-13247861 ]
Mark Miller commented on LUCENE-3923:
-------------------------------------
bq.Also to me tags like Date here are bogus (which date?! is it?),
+1
bq. and Author is no different from @author.
Right - there should be no author info in the source - we decided on that a long time ago.
> fail the build on wrong svn:eol-style
> -------------------------------------
>
> Key: LUCENE-3923
> URL: https://issues.apache.org/jira/browse/LUCENE-3923
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
>
> I'm tired of fixing this before releases. Jenkins should detect and fail on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3923) fail the build on wrong
svn:eol-style
Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238355#comment-13238355 ]
Michael McCandless commented on LUCENE-3923:
--------------------------------------------
+1
And, ideally, "ant test" as well...
> fail the build on wrong svn:eol-style
> -------------------------------------
>
> Key: LUCENE-3923
> URL: https://issues.apache.org/jira/browse/LUCENE-3923
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
>
> I'm tired of fixing this before releases. Jenkins should detect and fail on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3923) fail the build on wrong
svn:eol-style
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247827#comment-13247827 ]
Robert Muir commented on LUCENE-3923:
-------------------------------------
I don't think we should set those... i think eol-style is the main
one suggested by apache (it creates real problems otherwise,
like entire file is changed by a one-liner etc).
I also don't think these solr files should have all these svn
keywords exposed, it makes applying patches difficult.
> fail the build on wrong svn:eol-style
> -------------------------------------
>
> Key: LUCENE-3923
> URL: https://issues.apache.org/jira/browse/LUCENE-3923
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
>
> I'm tired of fixing this before releases. Jenkins should detect and fail on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3923) fail the build on wrong
svn:eol-style
Posted by "Mark Miller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247859#comment-13247859 ]
Mark Miller commented on LUCENE-3923:
-------------------------------------
We have talked about removing those svn keywords in the past - i think its just that no one has done it. I have mainly targeted the id stuff in the past because it screwed with patches - either most of that is gone, or new svn stuff handles it better - not sure. But +1 on removing any of it.
> fail the build on wrong svn:eol-style
> -------------------------------------
>
> Key: LUCENE-3923
> URL: https://issues.apache.org/jira/browse/LUCENE-3923
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
>
> I'm tired of fixing this before releases. Jenkins should detect and fail on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3923) fail the build on wrong
svn:eol-style
Posted by "Ryan McKinley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247812#comment-13247812 ]
Ryan McKinley commented on LUCENE-3923:
---------------------------------------
Perhaps we should also fail if a .java file does not have keywords set.
Lots of javadocs use
@version $Id$
{code}
svn propset svn:keywords "Date Author Id Revision HeadURL" *.java
{code}
In solr, MBeans expose $URL$, but we often don't set it
> fail the build on wrong svn:eol-style
> -------------------------------------
>
> Key: LUCENE-3923
> URL: https://issues.apache.org/jira/browse/LUCENE-3923
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
>
> I'm tired of fixing this before releases. Jenkins should detect and fail on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3923) fail the build on wrong
svn:eol-style
Posted by "Jan Høydahl (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238945#comment-13238945 ]
Jan Høydahl commented on LUCENE-3923:
-------------------------------------
+1
> fail the build on wrong svn:eol-style
> -------------------------------------
>
> Key: LUCENE-3923
> URL: https://issues.apache.org/jira/browse/LUCENE-3923
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
>
> I'm tired of fixing this before releases. Jenkins should detect and fail on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3923) fail the build on wrong
svn:eol-style
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247830#comment-13247830 ]
Robert Muir commented on LUCENE-3923:
-------------------------------------
Also to me tags like Date here are bogus (which date?! is it?),
and Author is no different from @author.
> fail the build on wrong svn:eol-style
> -------------------------------------
>
> Key: LUCENE-3923
> URL: https://issues.apache.org/jira/browse/LUCENE-3923
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
>
> I'm tired of fixing this before releases. Jenkins should detect and fail on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3923) fail the build on wrong
svn:eol-style
Posted by "Ryan McKinley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248176#comment-13248176 ]
Ryan McKinley commented on LUCENE-3923:
---------------------------------------
All the $Id$ and $Revision$ tags have been removed (SOLR-3329)
> fail the build on wrong svn:eol-style
> -------------------------------------
>
> Key: LUCENE-3923
> URL: https://issues.apache.org/jira/browse/LUCENE-3923
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
>
> I'm tired of fixing this before releases. Jenkins should detect and fail on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org