You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/19 21:48:56 UTC
[GitHub] codecov-io edited a comment on issue #5241: [Explore] Handle empty
metrics control data
codecov-io edited a comment on issue #5241: [Explore] Handle empty metrics control data
URL: https://github.com/apache/incubator-superset/pull/5241#issuecomment-398557451
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5241?src=pr&el=h1) Report
> Merging [#5241](https://codecov.io/gh/apache/incubator-superset/pull/5241?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/70679d4c937e932636ccf5e6d872c849c1eae384?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5241?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5241 +/- ##
==========================================
+ Coverage 60.76% 60.78% +0.01%
==========================================
Files 258 258
Lines 19701 19700 -1
Branches 1970 1970
==========================================
+ Hits 11972 11974 +2
+ Misses 7720 7717 -3
Partials 9 9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5241?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5241/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQWRob2NGaWx0ZXJDb250cm9sLmpzeA==) | `78.72% <ø> (+1.06%)` | :arrow_up: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5241/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvTWV0cmljc0NvbnRyb2wuanN4) | `80% <100%> (+1.23%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5241?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5241?src=pr&el=footer). Last update [70679d4...b1c6771](https://codecov.io/gh/apache/incubator-superset/pull/5241?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org