[GitHub] [incubator-superset] geido commented on a change in pull request #11928: Extract copy functionality to utils

[GitBox <gi...@apache.org>]

geido commented on a change in pull request #11928:
URL: https://github.com/apache/incubator-superset/pull/11928#discussion_r536164589



##########
File path: superset-frontend/src/views/CRUD/data/components/SyntaxHighlighterCopy/index.tsx
##########
@@ -27,6 +27,7 @@ import github from 'react-syntax-highlighter/dist/cjs/styles/hljs/github';
 import SyntaxHighlighter from 'react-syntax-highlighter/dist/cjs/light';
 import { ToastProps } from 'src/messageToasts/enhancers/withToasts';
 import Icon from 'src/components/Icon';
+import copyTextToClipboard from '../../../../../utils/copy';

Review comment:
       I think here it might be better to use an absolute path to the utils

##########
File path: superset-frontend/src/views/CRUD/data/savedquery/SavedQueryList.tsx
##########
@@ -41,6 +41,7 @@ import { IconName } from 'src/components/Icon';
 import { commonMenuData } from 'src/views/CRUD/data/common';
 import { SavedQueryObject } from 'src/views/CRUD/types';
 import SavedQueryPreviewModal from './SavedQueryPreviewModal';
+import copyTextToClipboard from '../../../../utils/copy';

Review comment:
       Same comment. It might use an absolute path




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org