You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/09/23 20:58:32 UTC
[GitHub] incubator-beam pull request #994: [BEAM-615] Add support for processing time...
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/994
[BEAM-615] Add support for processing time timers in FlinkRunner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @aljoscha or @mxm
I coded this very quickly without learning probably what I need to about the `FlinkRunner` or Flink. It seems to work for the naive examples I am experimenting with. Perhaps you can find errors and suggest corrections, or pull it and do it right?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam flink-processing-time
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/994.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #994
----
commit 29684fec8a0885ac202f6614f458af1221ed8bb6
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-09-23T20:54:21Z
Add support for processing time timers in FlinkRunner
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #994: [BEAM-615] Add support for processing time...
Posted by kennknowles <gi...@git.apache.org>.
Github user kennknowles closed the pull request at:
https://github.com/apache/incubator-beam/pull/994
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---