[GitHub] [airflow] syedahsn commented on a diff in pull request #31646: Add deferrable option to EmrTerminateJobFlowOperator

["syedahsn (via GitHub)" <gi...@apache.org>]

syedahsn commented on code in PR #31646:
URL: https://github.com/apache/airflow/pull/31646#discussion_r1222215613


##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -830,11 +849,32 @@ def execute(self, context: Context) -> None:
         self.log.info("Terminating JobFlow %s", self.job_flow_id)
         response = emr.terminate_job_flows(JobFlowIds=[self.job_flow_id])
 
+        if self.deferrable:

Review Comment:
   Yea, deferring essentially enforces a `wait_for_completion`. It makes sense to add that functionality in for the synchronous path as well. 
   See [this comment](https://github.com/apache/airflow/pull/30864#discussion_r1178385960) in a previous PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org