You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/08/15 00:19:54 UTC
Review Request 68353: ATLAS-2823: updated hooks to support
asynchronous notifications
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68353/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, Ramesh Mani, and Sarath Subramanian.
Bugs: ATLAS-2823
https://issues.apache.org/jira/browse/ATLAS-2823
Repository: atlas
Description
-------
updated hooks to support asynchronous notifications
Diffs
-----
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 77177b49f
notification/src/main/java/org/apache/atlas/hook/AtlasHook.java bf6a36c59
Diff: https://reviews.apache.org/r/68353/diff/1/
Testing
-------
Verified that pre-commit tests pass successfully - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/567/
Thanks,
Madhan Neethiraj
Re: Review Request 68353: ATLAS-2823: updated hooks to support
asynchronous notifications
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68353/#review207283
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Aug. 14, 2018, 5:19 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68353/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 5:19 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, Ramesh Mani, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2823
> https://issues.apache.org/jira/browse/ATLAS-2823
>
>
> Repository: atlas
>
>
> Description
> -------
>
> updated hooks to support asynchronous notifications
>
>
> Diffs
> -----
>
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 77177b49f
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java bf6a36c59
>
>
> Diff: https://reviews.apache.org/r/68353/diff/1/
>
>
> Testing
> -------
>
> Verified that pre-commit tests pass successfully - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/567/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 68353: ATLAS-2823: updated hooks to support
asynchronous notifications
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68353/#review207282
-----------------------------------------------------------
notification/src/main/java/org/apache/atlas/hook/AtlasHook.java
Lines 153 (patched)
<https://reviews.apache.org/r/68353/#comment290613>
the condition is reversed here:
if (executor != null) {
executor.submit(.....);
} else {
notifyEntitiesInternal(.....);
}
- Sarath Subramanian
On Aug. 14, 2018, 5:19 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68353/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 5:19 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, Ramesh Mani, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2823
> https://issues.apache.org/jira/browse/ATLAS-2823
>
>
> Repository: atlas
>
>
> Description
> -------
>
> updated hooks to support asynchronous notifications
>
>
> Diffs
> -----
>
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 77177b49f
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java bf6a36c59
>
>
> Diff: https://reviews.apache.org/r/68353/diff/1/
>
>
> Testing
> -------
>
> Verified that pre-commit tests pass successfully - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/567/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 68353: ATLAS-2823: updated hooks to support
asynchronous notifications
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68353/#review207366
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Aug. 15, 2018, 1:43 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68353/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2018, 1:43 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, Ramesh Mani, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2823
> https://issues.apache.org/jira/browse/ATLAS-2823
>
>
> Repository: atlas
>
>
> Description
> -------
>
> updated hooks to support asynchronous notifications
>
>
> Diffs
> -----
>
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 77177b49f
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 09998cfd0
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 78f2e8304
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ac4960122
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java 17493f616
> notification/src/main/java/org/apache/atlas/hook/AtlasHook.java bf6a36c59
> notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java 0a0620fe2
>
>
> Diff: https://reviews.apache.org/r/68353/diff/4/
>
>
> Testing
> -------
>
> Verified that pre-commit tests pass successfully - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/576/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 68353: ATLAS-2823: updated hooks to support
asynchronous notifications
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68353/
-----------------------------------------------------------
(Updated Aug. 15, 2018, 8:43 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, Ramesh Mani, and Sarath Subramanian.
Bugs: ATLAS-2823
https://issues.apache.org/jira/browse/ATLAS-2823
Repository: atlas
Description
-------
updated hooks to support asynchronous notifications
Diffs (updated)
-----
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 77177b49f
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 09998cfd0
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 78f2e8304
addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ac4960122
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java 17493f616
notification/src/main/java/org/apache/atlas/hook/AtlasHook.java bf6a36c59
notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java 0a0620fe2
Diff: https://reviews.apache.org/r/68353/diff/4/
Changes: https://reviews.apache.org/r/68353/diff/3-4/
Testing (updated)
-------
Verified that pre-commit tests pass successfully - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/576/
Thanks,
Madhan Neethiraj
Re: Review Request 68353: ATLAS-2823: updated hooks to support
asynchronous notifications
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68353/
-----------------------------------------------------------
(Updated Aug. 15, 2018, 9:14 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, Ramesh Mani, and Sarath Subramanian.
Changes
-------
updated to send notifications using ugi privileged action
Bugs: ATLAS-2823
https://issues.apache.org/jira/browse/ATLAS-2823
Repository: atlas
Description
-------
updated hooks to support asynchronous notifications
Diffs (updated)
-----
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 77177b49f
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 09998cfd0
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 78f2e8304
addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ac4960122
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java 17493f616
notification/src/main/java/org/apache/atlas/hook/AtlasHook.java bf6a36c59
notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java 0a0620fe2
Diff: https://reviews.apache.org/r/68353/diff/3/
Changes: https://reviews.apache.org/r/68353/diff/2-3/
Testing
-------
Verified that pre-commit tests pass successfully - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/567/
Thanks,
Madhan Neethiraj
Re: Review Request 68353: ATLAS-2823: updated hooks to support
asynchronous notifications
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68353/
-----------------------------------------------------------
(Updated Aug. 15, 2018, 1:21 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Nixon Rodrigues, Ramesh Mani, and Sarath Subramanian.
Changes
-------
- updated for the review comment
- additional refactoring to move maxRetries configuration to AtlasHook
Bugs: ATLAS-2823
https://issues.apache.org/jira/browse/ATLAS-2823
Repository: atlas
Description
-------
updated hooks to support asynchronous notifications
Diffs (updated)
-----
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java 77177b49f
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 09998cfd0
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 78f2e8304
addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java ac4960122
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java 17493f616
notification/src/main/java/org/apache/atlas/hook/AtlasHook.java bf6a36c59
Diff: https://reviews.apache.org/r/68353/diff/2/
Changes: https://reviews.apache.org/r/68353/diff/1-2/
Testing
-------
Verified that pre-commit tests pass successfully - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/567/
Thanks,
Madhan Neethiraj