You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by se...@apache.org on 2013/07/09 13:49:36 UTC

svn commit: r1501206 - /jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java

Author: sebb
Date: Tue Jul  9 11:49:36 2013
New Revision: 1501206

URL: http://svn.apache.org/r1501206
Log:
Remove code from try/catch that does not need to be there
Fetch fileName once

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java?rev=1501206&r1=1501205&r2=1501206&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/action/SelectTemplateDialog.java Tue Jul  9 11:49:36 2013
@@ -227,14 +227,15 @@ public class SelectTemplateDialog extend
      * @param e {@link ActionEvent}
      */
     private void doOpen(ActionEvent e) {
+        final String selectedTemplate = templateList.getText();
+        final Template template = TemplateManager.getInstance().getTemplateByName(selectedTemplate);   
+        final String fileName = template.getFileName();
+        final File fileToCopy = new File(JMeterUtils.getJMeterHome(), fileName);
+        final File targetFile = new File( System.getProperty("user.dir"), 
+                fileName.substring(fileName.lastIndexOf("/")));
         InputStream inputStream = null;
         OutputStream outputStream = null;
         try {
-            String selectedTemplate = templateList.getText();
-            Template template = TemplateManager.getInstance().getTemplateByName(selectedTemplate);   
-            File fileToCopy = new File(JMeterUtils.getJMeterHome(), template.getFileName());
-            File targetFile = new File( System.getProperty("user.dir"), 
-                    template.getFileName().substring(template.getFileName().lastIndexOf("/")));
             inputStream = new BufferedInputStream(new FileInputStream(fileToCopy));
             outputStream = new BufferedOutputStream(new FileOutputStream(targetFile));
             IOUtils.copy(inputStream, outputStream);