[GitHub] IvanVergiliev commented on a change in pull request #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer

[GitBox <gi...@apache.org>]

IvanVergiliev commented on a change in pull request #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer
URL: https://github.com/apache/spark/pull/23766#discussion_r256316993
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
 ##########
 @@ -332,6 +334,24 @@ abstract class OrcSuite extends OrcTest with BeforeAndAfterAll {
       assert(version === SPARK_VERSION_SHORT)
     }
   }
+
+  test("[SPARK-26859] Reading ORC files with explicit schema can result in wrong data") {
+    withSQLConf(SQLConf.ORC_VECTORIZED_READER_ENABLED.key -> "false") {
 
 Review comment:
   @viirya the `OrcDeserializer` class (which is the one that contains the bug) is only used for the non-vectorized reader AFAICT, so the vectorized doesn't go through the buggy codepath.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org