You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/12/28 10:59:14 UTC
[GitHub] [james-project] vttranlina opened a new pull request, #1365: JAMES-3871 - Fix bug - No eventBus associated to EventDispatcher$Disp…
vttranlina opened a new pull request, #1365:
URL: https://github.com/apache/james-project/pull/1365
…atchingFailureGroup
jira: https://issues.apache.org/jira/browse/JAMES-3871
resolve: https://github.com/linagora/james-project/issues/4692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1365: JAMES-3871 - Fix bug - No eventBus associated to EventDispatcher$DispatchingFailureGroup
Posted by GitBox <gi...@apache.org>.
chibenwa commented on code in PR #1365:
URL: https://github.com/apache/james-project/pull/1365#discussion_r1058682746
##########
event-bus/api/src/main/java/org/apache/james/events/MailboxDispatchingFailureGroup.java:
##########
@@ -0,0 +1,62 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information *
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the *
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the *
+ * specific language governing permissions and limitations *
+ * under the License. *
+ ****************************************************************/
+
+package org.apache.james.events;
+
+import java.util.Objects;
+
+import com.google.common.base.Preconditions;
+
+public class MailboxDispatchingFailureGroup extends Group {
Review Comment:
```suggestion
public class DispatchingFailureGroup extends Group {
```
No mailbox specific stuff in event-bus-api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1365: JAMES-3871 - Fix bug - No eventBus associated to EventDispatcher$DispatchingFailureGroup
Posted by GitBox <gi...@apache.org>.
chibenwa merged PR #1365:
URL: https://github.com/apache/james-project/pull/1365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1365: JAMES-3871 - Fix bug - No eventBus associated to EventDispatcher$DispatchingFailureGroup
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1365:
URL: https://github.com/apache/james-project/pull/1365#issuecomment-1367124278
| Test Result (2 failures / +2)org.apache.james.events.DispatchingFailureGroupTest.groupDeserializeShouldReturnGroupWhenValidInputorg.apache.james.events.DispatchingFailureGroupTest.asStringShouldReturnEventBusName
-- | --
[Test Result](https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1365/3/testReport/) (2 failures / +2)
[org.apache.james.events.DispatchingFailureGroupTest.groupDeserializeShouldReturnGroupWhenValidInput](https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1365/3/testReport/junit/org.apache.james.events/DispatchingFailureGroupTest/groupDeserializeShouldReturnGroupWhenValidInput/)
[org.apache.james.events.DispatchingFailureGroupTest.asStringShouldReturnEventBusName](https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1365/3/testReport/junit/org.apache.james.events/DispatchingFailureGroupTest/asStringShouldReturnEventBusName/)
Related...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org