[GitHub] [arrow] sanjibansg edited a comment on pull request #12426: ARROW-15672: [C++] Enable CSV writer to control the field delimiter

[GitBox <gi...@apache.org>]

sanjibansg edited a comment on pull request #12426:
URL: https://github.com/apache/arrow/pull/12426#issuecomment-1047511108


   > Appveyor test failure looks related to this PR, needs be fixed. https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/42659260/job/qk6x3kld8ffabyuu#L2758
   
   I checked the test logs. It shows an older piece of code which is failing now.
   https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/42659260/job/qk6x3kld8ffabyuu#L2745
   
   Here, the error log shows this 
   `assert t == read_csv(buf, read_options=read_options)`
   while the [updated code](https://github.com/apache/arrow/pull/12426/files#diff-d09f577a8ebe28cba37f0339c75f9eba3bedd1dade08e10521b345667447294cR1897) has this
    ```
           assert t == read_csv(buf, read_options=read_options,
                                parse_options=parse_options)
   ```
   
   
   
   > Correction (Updated on 24/02/2022)
   > Missed the parse_options in Line 1890, which actually caused the error, we need parse_options along with read_options for custom delimiter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org