You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/18 06:59:44 UTC
[GitHub] [shardingsphere] zjcnb opened a new pull request, #16892: Restructure metadata node to support PG Three-tier structure.
zjcnb opened a new pull request, #16892:
URL: https://github.com/apache/shardingsphere/pull/16892
For #14004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #16892: Restructure metadata node to support PG Three-tier structure.
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #16892:
URL: https://github.com/apache/shardingsphere/pull/16892#discussion_r851984666
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-cluster-mode/shardingsphere-cluster-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/registry/cache/subscriber/ScalingRegistrySubscriberTest.java:
##########
@@ -34,26 +34,20 @@ public final class ScalingRegistrySubscriberTest {
private ClusterPersistRepository repository;
@Mock
- private SchemaVersionPersistService schemaVersionPersistService;
+ private DatabaseVersionPersistService databaseVersionPersistService;
private ScalingRegistrySubscriber scalingRegistrySubscriber;
@Before
public void setUp() throws ReflectiveOperationException {
scalingRegistrySubscriber = new ScalingRegistrySubscriber(repository);
- Field persistServiceField = ScalingRegistrySubscriber.class.getDeclaredField("schemaVersionPersistService");
+ Field persistServiceField = ScalingRegistrySubscriber.class.getDeclaredField("databaseVersionPersistService");
persistServiceField.setAccessible(true);
- persistServiceField.set(scalingRegistrySubscriber, schemaVersionPersistService);
+ persistServiceField.set(scalingRegistrySubscriber, databaseVersionPersistService);
}
@Test
public void assertCacheRuleConfiguration() {
// TODO finish test case
}
-
Review Comment:
Why comment this code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #16892: Restructure metadata node to support PG Three-tier structure.
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #16892:
URL: https://github.com/apache/shardingsphere/pull/16892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on pull request #16892: Restructure metadata node to support PG Three-tier structure.
Posted by GitBox <gi...@apache.org>.
zjcnb commented on PR #16892:
URL: https://github.com/apache/shardingsphere/pull/16892#issuecomment-1101180447
<img width="365" alt="image" src="https://user-images.githubusercontent.com/33742097/163773532-f3f843bd-bdba-4dc4-8f15-b4dfe2bbbdf9.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on a diff in pull request #16892: Restructure metadata node to support PG Three-tier structure.
Posted by GitBox <gi...@apache.org>.
zjcnb commented on code in PR #16892:
URL: https://github.com/apache/shardingsphere/pull/16892#discussion_r851987628
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-cluster-mode/shardingsphere-cluster-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/registry/cache/subscriber/ScalingRegistrySubscriberTest.java:
##########
@@ -34,26 +34,20 @@ public final class ScalingRegistrySubscriberTest {
private ClusterPersistRepository repository;
@Mock
- private SchemaVersionPersistService schemaVersionPersistService;
+ private DatabaseVersionPersistService databaseVersionPersistService;
private ScalingRegistrySubscriber scalingRegistrySubscriber;
@Before
public void setUp() throws ReflectiveOperationException {
scalingRegistrySubscriber = new ScalingRegistrySubscriber(repository);
- Field persistServiceField = ScalingRegistrySubscriber.class.getDeclaredField("schemaVersionPersistService");
+ Field persistServiceField = ScalingRegistrySubscriber.class.getDeclaredField("databaseVersionPersistService");
persistServiceField.setAccessible(true);
- persistServiceField.set(scalingRegistrySubscriber, schemaVersionPersistService);
+ persistServiceField.set(scalingRegistrySubscriber, databaseVersionPersistService);
}
@Test
public void assertCacheRuleConfiguration() {
// TODO finish test case
}
-
Review Comment:
This unit test originally there. I don't know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org