You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/06/30 21:11:49 UTC

[GitHub] [ignite] ololo3000 commented on a change in pull request #7978: IGNITE-13197: Import order rule added.

ololo3000 commented on a change in pull request #7978:
URL: https://github.com/apache/ignite/pull/7978#discussion_r447981663



##########
File path: modules/direct-io/src/main/java/org/apache/ignite/internal/processors/cache/persistence/file/IgniteNativeIoLib.java
##########
@@ -150,10 +150,10 @@ else if (verIntComps.get(verIdx) == 2) {
 
             if (compsCnt > majorRevIdx && verIntComps.get(majorRevIdx) > 4)
                 return true;
-            else if (compsCnt > minorRevIdx
-                && verIntComps.get(majorRevIdx) == 4
-                && verIntComps.get(minorRevIdx) >= 10)
-                return true;
+            else

Review comment:
       It seems that braces are required here according to https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-BracesandIdentation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org