You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/09 16:59:11 UTC
[GitHub] [arrow] pitrou opened a new pull request #12596: ARROW-15888: [Doc][Python] Modernize development instructions
pitrou opened a new pull request #12596:
URL: https://github.com/apache/arrow/pull/12596
Some Python development instructions are slightly outdated, update them.
Also fix a couple issues that raised some Sphinx warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12596: ARROW-15888: [Doc][Python] Modernize development instructions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12596:
URL: https://github.com/apache/arrow/pull/12596#issuecomment-1063966676
Benchmark runs are scheduled for baseline = 89b1b1bb5c25c7baf9310168ceffe90cbc9caf82 and contender = 8088f71c5d545349a24812b9e516ab07c850d0c6. 8088f71c5d545349a24812b9e516ab07c850d0c6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c7265acba7a5493b9ce98668ca5ae159...bc4d9738d85b4832b831972bbb5530bf/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d6a913bfb73d4a03a50333398cdad51c...c18cd0ac842142069e49fa32f4497609/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/61af36ac59dd4c32b8b1bf3bb79c70a3...ac60a406cc29465f8cfe9705b7ce0191/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d52b62ad90cd474c993903bf2d6d421a...f30493597e2f4b7ba8f931164119346e/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12596: ARROW-15888: [Doc][Python] Modernize development instructions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12596:
URL: https://github.com/apache/arrow/pull/12596#issuecomment-1063146873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12596: ARROW-15888: [Doc][Python] Modernize development instructions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12596:
URL: https://github.com/apache/arrow/pull/12596#issuecomment-1063966676
Benchmark runs are scheduled for baseline = 89b1b1bb5c25c7baf9310168ceffe90cbc9caf82 and contender = 8088f71c5d545349a24812b9e516ab07c850d0c6. 8088f71c5d545349a24812b9e516ab07c850d0c6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c7265acba7a5493b9ce98668ca5ae159...bc4d9738d85b4832b831972bbb5530bf/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d6a913bfb73d4a03a50333398cdad51c...c18cd0ac842142069e49fa32f4497609/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/61af36ac59dd4c32b8b1bf3bb79c70a3...ac60a406cc29465f8cfe9705b7ce0191/)
[Finished :arrow_down:0.55% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d52b62ad90cd474c993903bf2d6d421a...f30493597e2f4b7ba8f931164119346e/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12596: ARROW-15888: [Doc][Python] Modernize development instructions
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #12596:
URL: https://github.com/apache/arrow/pull/12596#discussion_r823582603
##########
File path: docs/source/developers/python.rst
##########
@@ -378,20 +378,8 @@ Docker examples
If you are having difficulty building the Python library from source, take a
look at the ``python/examples/minimal_build`` directory which illustrates a
-complete build and test from source both with the conda and pip/virtualenv
-build methods.
-
-Building with CUDA support
-~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-The :mod:`pyarrow.cuda` module offers support for using Arrow platform
-components with Nvidia's CUDA-enabled GPU devices. To build with this support,
-pass ``-DARROW_CUDA=ON`` when building the C++ libraries, and set the following
-environment variable when building pyarrow:
Review comment:
This section is also included elsewhere?
##########
File path: docs/source/developers/python.rst
##########
@@ -146,15 +146,18 @@ Pull in the test data and setup the environment variables:
.. code-block:: shell
pushd arrow
- git submodule init
- git submodule update
+ git submodule update --init
export PARQUET_TEST_DATA="${PWD}/cpp/submodules/parquet-testing/data"
export ARROW_TEST_DATA="${PWD}/testing/data"
popd
Using Conda
~~~~~~~~~~~
+The `conda <https://conda.io/>`_ package managers allows installing build-time
Review comment:
```suggestion
The `conda <https://conda.io/>`_ package manager allows installing build-time
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12596: ARROW-15888: [Doc][Python] Modernize development instructions
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12596:
URL: https://github.com/apache/arrow/pull/12596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12596: ARROW-15888: [Doc][Python] Modernize development instructions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12596:
URL: https://github.com/apache/arrow/pull/12596#issuecomment-1063966676
Benchmark runs are scheduled for baseline = 89b1b1bb5c25c7baf9310168ceffe90cbc9caf82 and contender = 8088f71c5d545349a24812b9e516ab07c850d0c6. 8088f71c5d545349a24812b9e516ab07c850d0c6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c7265acba7a5493b9ce98668ca5ae159...bc4d9738d85b4832b831972bbb5530bf/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d6a913bfb73d4a03a50333398cdad51c...c18cd0ac842142069e49fa32f4497609/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/61af36ac59dd4c32b8b1bf3bb79c70a3...ac60a406cc29465f8cfe9705b7ce0191/)
[Finished :arrow_down:0.55% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d52b62ad90cd474c993903bf2d6d421a...f30493597e2f4b7ba8f931164119346e/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12596: ARROW-15888: [Doc][Python] Modernize development instructions
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12596:
URL: https://github.com/apache/arrow/pull/12596#issuecomment-1063966676
Benchmark runs are scheduled for baseline = 89b1b1bb5c25c7baf9310168ceffe90cbc9caf82 and contender = 8088f71c5d545349a24812b9e516ab07c850d0c6. 8088f71c5d545349a24812b9e516ab07c850d0c6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c7265acba7a5493b9ce98668ca5ae159...bc4d9738d85b4832b831972bbb5530bf/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d6a913bfb73d4a03a50333398cdad51c...c18cd0ac842142069e49fa32f4497609/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/61af36ac59dd4c32b8b1bf3bb79c70a3...ac60a406cc29465f8cfe9705b7ce0191/)
[Finished :arrow_down:0.55% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d52b62ad90cd474c993903bf2d6d421a...f30493597e2f4b7ba8f931164119346e/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12596: ARROW-15888: [Doc][Python] Modernize development instructions
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12596:
URL: https://github.com/apache/arrow/pull/12596#issuecomment-1063966676
Benchmark runs are scheduled for baseline = 89b1b1bb5c25c7baf9310168ceffe90cbc9caf82 and contender = 8088f71c5d545349a24812b9e516ab07c850d0c6. 8088f71c5d545349a24812b9e516ab07c850d0c6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c7265acba7a5493b9ce98668ca5ae159...bc4d9738d85b4832b831972bbb5530bf/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d6a913bfb73d4a03a50333398cdad51c...c18cd0ac842142069e49fa32f4497609/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/61af36ac59dd4c32b8b1bf3bb79c70a3...ac60a406cc29465f8cfe9705b7ce0191/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d52b62ad90cd474c993903bf2d6d421a...f30493597e2f4b7ba8f931164119346e/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12596: ARROW-15888: [Doc][Python] Modernize development instructions
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12596:
URL: https://github.com/apache/arrow/pull/12596#discussion_r823585364
##########
File path: docs/source/developers/python.rst
##########
@@ -378,20 +378,8 @@ Docker examples
If you are having difficulty building the Python library from source, take a
look at the ``python/examples/minimal_build`` directory which illustrates a
-complete build and test from source both with the conda and pip/virtualenv
-build methods.
-
-Building with CUDA support
-~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-The :mod:`pyarrow.cuda` module offers support for using Arrow platform
-components with Nvidia's CUDA-enabled GPU devices. To build with this support,
-pass ``-DARROW_CUDA=ON`` when building the C++ libraries, and set the following
-environment variable when building pyarrow:
Review comment:
It's simply covered by the bulleted list of optional components above. There is no need for a CUDA-specific paragraph IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org